From: Thomas Monjalon <thomas@monjalon.net>
To: Ferruh Yigit <ferruh.yigit@intel.com>, harish.patil@cavium.com
Cc: stable@dpdk.org, Jingjing Wu <jingjing.wu@intel.com>,
jianfeng.tan@intel.com, shijith.thotton@caviumnetworks.com,
gregory@weka.io, beilei.xing@intel.com, dev@dpdk.org
Subject: Re: [dpdk-stable] [PATCH 2/2] igb_uio: fix interrupt enablement after FLR in VM
Date: Fri, 13 Oct 2017 23:15:52 +0200 [thread overview]
Message-ID: <26004513.65WVqXSdeM@xps> (raw)
In-Reply-To: <95051c86-9088-19a7-99f8-27eb1d8b525c@intel.com>
13/10/2017 22:54, Ferruh Yigit:
> On 10/9/2017 9:31 PM, Jingjing Wu wrote:
> > If pass-through a VF by vfio-pci to a Qemu VM, after FLR
> > in VM, the interrupt setting is not recoverd correctly
> > to host as below:
> > in VM guest:
> > Capabilities: [70] MSI-X: Enable+ Count=5 Masked-
> > in Host:
> > Capabilities: [70] MSI-X: Enable+ Count=5 Masked-
> >
> > That was because in pci_reset_function, it first reads the
> > PCI configure and set FLR reset, and then writes PCI configure
> > as restoration. But not all the writing are successful to Host.
> > Becuase vfio-pci driver doesn't allow directly write PCI MSI-X
> > Cap.
> >
> > To fix this issue, we need to move the interrupt enablement from
> > igb_uio probe to open device file. While is also the similar as
> > the behaviour in vfio_pci kernel module code.
>
> So I guess this also explains why pci_reset in open() cause the problem,
> when this is called for VF, interrupts stays disable for both VF and PF?
>
> >
> > Fixes: b58eedfc7dd5 ("igb_uio: issue FLR during open and release of device file")
> >
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Jingjing Wu <jingjing.wu@intel.com>
> > Signed-off-by: Jianfeng Tan <jianfeng.tan@intel.com>
>
> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
>
>
> We have two options, getting this patch or revert the original patch,
> Thomas already has a patch for reverting.
>
> The original patch is to make igb_uio safer. To not leave device in
> unwanted stated. Problem related to this has been reported a few times,
> I believe it is good to fix this problem. And since we already have some
> movement towards fix, I say lets continue instead of revert.
>
> Only problem is the scope of the patch is wide, and in previous release
> it already break some uses cases, this is a little scary, please support
> on testing this more.
>
> I suggest getting this fix for rc1 and let it to be tested properly, and
> if we hit some problem, we can always revert and work on problem for
> next release.
OK, let's try.
Harish, please help testing this patch with qede.
Thanks
next prev parent reply other threads:[~2017-10-13 21:15 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-09 20:31 [dpdk-stable] [PATCH 1/2] net/i40e: fix VF initialization error Jingjing Wu
2017-10-09 20:31 ` [dpdk-stable] [PATCH 2/2] igb_uio: fix interrupt enablement after FLR in VM Jingjing Wu
2017-10-09 22:09 ` [dpdk-stable] [PATCH v2 " Jingjing Wu
2017-10-12 5:43 ` Wu, Jingjing
2017-10-13 8:12 ` Shijith Thotton
2017-10-13 21:11 ` Ferruh Yigit
2017-10-13 21:21 ` [dpdk-stable] [dpdk-dev] " Patil, Harish
2017-10-15 3:10 ` [dpdk-stable] " Gregory Etelson
2017-10-16 22:49 ` Patil, Harish
2017-10-16 23:52 ` Ferruh Yigit
2017-10-17 1:32 ` Patil, Harish
2017-10-17 1:37 ` Wu, Jingjing
2017-10-13 20:54 ` [dpdk-stable] [PATCH " Ferruh Yigit
2017-10-13 21:15 ` Thomas Monjalon [this message]
2017-10-13 21:38 ` Ferruh Yigit
2017-10-09 22:08 ` [dpdk-stable] [PATCH v2 1/2] net/i40e: fix VF initialization error Jingjing Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=26004513.65WVqXSdeM@xps \
--to=thomas@monjalon.net \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=gregory@weka.io \
--cc=harish.patil@cavium.com \
--cc=jianfeng.tan@intel.com \
--cc=jingjing.wu@intel.com \
--cc=shijith.thotton@caviumnetworks.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).