From: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>,
Sunil Kumar Kori <skori@marvell.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "jerinj@marvell.com" <jerinj@marvell.com>
Subject: Re: [dpdk-dev] [PATCH v2 1/3] lib/librte_ip_frag: Remove PKT_TX_IP_CKSUM offload flags
Date: Fri, 5 Jul 2019 08:31:58 +0000 [thread overview]
Message-ID: <2601191342CEEE43887BDE71AB9772580168A508B7@irsmsx105.ger.corp.intel.com> (raw)
In-Reply-To: <1706997.HcbFlGSI5x@xps>
> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> Sent: Thursday, July 4, 2019 5:53 PM
> To: Sunil Kumar Kori <skori@marvell.com>
> Cc: dev@dpdk.org; Ananyev, Konstantin <konstantin.ananyev@intel.com>; jerinj@marvell.com
> Subject: Re: [dpdk-dev] [PATCH v2 1/3] lib/librte_ip_frag: Remove PKT_TX_IP_CKSUM offload flags
>
> 26/06/2019 23:10, Thomas Monjalon:
> > 18/05/2019 17:18, Ananyev, Konstantin:
> > >
> > > Hi,
> > >
> > > > Currently PKT_TX_IP_CKSUM is being set into mbuf->ol_flags
> > > > during fragmentation and reassemble operation implicitly.
> > > > Because of this, application is forced to use checksum offload
> > > > whether it is supported by platform or not.
> > > >
> > > > Also documentation does not provide any expected value of ol_flags
> > > > in returned mbuf (reassembled or fragmented) so application will never
> > > > come to know that which offloads are enabled. So transmission may be failed
> > > > for the platforms which does not support checksum offload.
> > > >
> > > > Also, IPv6 does not contain any checksum field in header so setting
> > > > mbuf->ol_flags with PKT_TX_IP_CKSUM is itself invalid.
> > > >
> > > > So removing mentioned flag from the library.
> > >
> > > As there is a change in public API behavior, I think it deserves update in release notes.
> > > Apart from that:
> > > Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
> >
> > Is it safe to do this behaviour change?
> > You did not reply about updating the release notes.
> > Why did you drop this patch in v3?
>
> No reply?
> May I consider this series won't go in 19.08 release?
I think we better push it into 19.08.
It is a real problem, I hit it myself while working on adding reassemble/fragmentation
support into ipsec-secgw.
Sunil, can you prepare new version as asked by Thomas?
Konstantin
next prev parent reply other threads:[~2019-07-05 8:32 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-16 11:24 [dpdk-dev] [PATCH 0/3] Removing PKT_TX_IP_CKSUM from fragmentation/reassembly lib Sunil Kumar Kori
2019-05-16 11:24 ` [dpdk-dev] [PATCH 1/3] lib/librte_ip_frag: Remove PKT_TX_IP_CKSUM offload flags Sunil Kumar Kori
2019-05-16 11:24 ` [dpdk-dev] [PATCH 2/3] examples/ip_fragmentation: Enabling IP checksum offload in mbuf Sunil Kumar Kori
2019-05-16 11:24 ` [dpdk-dev] [PATCH 3/3] examples/ip_reassembly: " Sunil Kumar Kori
2019-05-16 11:42 ` [dpdk-dev] [PATCH v2 0/3] Removing PKT_TX_IP_CKSUM from fragmentation/reassembly lib Sunil Kumar Kori
2019-05-16 11:42 ` [dpdk-dev] [PATCH v2 1/3] lib/librte_ip_frag: Remove PKT_TX_IP_CKSUM offload flags Sunil Kumar Kori
2019-05-18 15:18 ` Ananyev, Konstantin
2019-06-26 21:10 ` Thomas Monjalon
2019-07-04 16:52 ` Thomas Monjalon
2019-07-05 8:31 ` Ananyev, Konstantin [this message]
2019-05-16 11:42 ` [dpdk-dev] [PATCH v2 2/3] examples/ip_fragmentation: Enabling IP checksum offload in mbuf Sunil Kumar Kori
2019-05-18 15:21 ` Ananyev, Konstantin
2019-05-20 8:09 ` Sunil Kumar Kori
2019-05-20 8:15 ` Ananyev, Konstantin
2019-05-20 10:59 ` [dpdk-dev] [PATCH v3 1/2] " Sunil Kumar Kori
2019-05-20 10:59 ` [dpdk-dev] [PATCH v3 2/2] examples/ip_reassembly: " Sunil Kumar Kori
2019-05-20 11:29 ` Ananyev, Konstantin
2019-05-20 11:28 ` [dpdk-dev] [PATCH v3 1/2] examples/ip_fragmentation: " Ananyev, Konstantin
2019-07-08 4:32 ` [dpdk-dev] [PATCH v4 1/3] lib/librte_ip_frag: remove IP checkum offload flag jerinj
2019-07-08 4:32 ` [dpdk-dev] [PATCH v4 2/3] examples/ip_fragmentation: enable IP checksum offload jerinj
2019-07-08 4:33 ` [dpdk-dev] [PATCH v4 3/3] examples/ip_reassembly: " jerinj
2019-07-08 9:07 ` [dpdk-dev] [PATCH v4 1/3] lib/librte_ip_frag: remove IP checkum offload flag Thomas Monjalon
2019-05-16 11:42 ` [dpdk-dev] [PATCH v2 3/3] examples/ip_reassembly: Enabling IP checksum offload in mbuf Sunil Kumar Kori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2601191342CEEE43887BDE71AB9772580168A508B7@irsmsx105.ger.corp.intel.com \
--to=konstantin.ananyev@intel.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=skori@marvell.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).