From: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
To: "Iremonger, Bernard" <bernard.iremonger@intel.com>,
"Zhu, TaoX" <taox.zhu@intel.com>,
"Nicolau, Radu" <radu.nicolau@intel.com>,
"akhil.goyal@nxp.com" <akhil.goyal@nxp.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "Zhu, TaoX" <taox.zhu@intel.com>
Subject: Re: [dpdk-dev] [PATCH] examples/ipsec-secgw: add parameter --mtu parse option
Date: Thu, 18 Jul 2019 10:58:48 +0000 [thread overview]
Message-ID: <2601191342CEEE43887BDE71AB9772580168A56F59@irsmsx105.ger.corp.intel.com> (raw)
In-Reply-To: <8CEF83825BEC744B83065625E567D7C260DD1866@IRSMSX108.ger.corp.intel.com>
Hi guys,
>
> Hi Tao
>
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of
> > taox.zhu@intel.com
> > Sent: Thursday, July 18, 2019 3:22 PM
> > To: Nicolau, Radu <radu.nicolau@intel.com>; akhil.goyal@nxp.com
> > Cc: dev@dpdk.org; Zhu, TaoX <taox.zhu@intel.com>
> > Subject: [dpdk-dev] [PATCH] examples/ipsec-secgw: add parameter --mtu
> > parse option
> >
> > From: Zhu Tao <taox.zhu@intel.com>
> >
> > This patch add parameter --mtu parse key and enumeration value.
> >
> > Signed-off-by: Zhu Tao <taox.zhu@intel.com>
> > ---
> > examples/ipsec-secgw/ipsec-secgw.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/examples/ipsec-secgw/ipsec-secgw.c b/examples/ipsec-
> > secgw/ipsec-secgw.c
> > index b1ecbb975..05fffa967 100644
> > --- a/examples/ipsec-secgw/ipsec-secgw.c
> > +++ b/examples/ipsec-secgw/ipsec-secgw.c
> > @@ -159,6 +159,7 @@ static const struct option lgopts[] = {
> > {CMD_LINE_OPT_RX_OFFLOAD, 1, 0,
> > CMD_LINE_OPT_RX_OFFLOAD_NUM},
> > {CMD_LINE_OPT_TX_OFFLOAD, 1, 0,
> > CMD_LINE_OPT_TX_OFFLOAD_NUM},
> > {CMD_LINE_OPT_REASSEMBLE, 1, 0,
> > CMD_LINE_OPT_REASSEMBLE_NUM},
> > + {CMD_LINE_OPT_MTU, 1, 0, CMD_LINE_OPT_MTU_NUM},
> > {NULL, 0, 0, 0}
> > };
> >
> > --
> > 2.17.1
Thanks for fixing it for me, don't know where I lost that line.
>
> This patch looks like a fix, if so it should have a fixes line and Cc: stable@dpdk.org if it is to be back ported.
I am agree with Bernard about fixes line, though no need to CC stable,
as this bug was introduced in 19.08 timeframe.
>
> Also
> ./devtools/check-git-log.sh -1
> Wrong headline lowercase:
> examples/ipsec-secgw: add parameter --mtu parse option
>
Apart from the nits mentioned above:
Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
Tested-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
next prev parent reply other threads:[~2019-07-18 10:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-18 14:21 taox.zhu
2019-07-18 9:39 ` Iremonger, Bernard
2019-07-18 10:58 ` Ananyev, Konstantin [this message]
2019-07-18 15:21 ` Akhil Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2601191342CEEE43887BDE71AB9772580168A56F59@irsmsx105.ger.corp.intel.com \
--to=konstantin.ananyev@intel.com \
--cc=akhil.goyal@nxp.com \
--cc=bernard.iremonger@intel.com \
--cc=dev@dpdk.org \
--cc=radu.nicolau@intel.com \
--cc=taox.zhu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).