From: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
To: Hemant Agrawal <hemant.agrawal@nxp.com>,
"pbhagavatula@marvell.com" <pbhagavatula@marvell.com>,
Sachin Saxena <sachin.saxena@nxp.com>,
"Akhil Goyal" <akhil.goyal@nxp.com>,
Igor Russkikh <igor.russkikh@aquantia.com>,
Pavel Belous <pavel.belous@aquantia.com>,
Ravi Kumar <ravi1.kumar@amd.com>, Rasesh Mody <rmody@marvell.com>,
Shahed Shaikh <shshaikh@marvell.com>,
"Rahul Lakkireddy" <rahul.lakkireddy@chelsio.com>,
Marcin Wojtas <mw@semihalf.com>,
Michal Krawczyk <mk@semihalf.com>,
Guy Tzalik <gtzalik@amazon.com>,
"Evgeny Schemeilin" <evgenys@amazon.com>,
Igor Chauskin <igorch@amazon.com>,
"John Daley" <johndale@cisco.com>,
Hyong Youb Kim <hyonkim@cisco.com>,
"Wei Hu (Xavier)" <xavier.huwei@huawei.com>,
"Min Hu (Connor)" <humin29@huawei.com>,
Yisen Zhuang <yisen.zhuang@huawei.com>,
"Xing, Beilei" <beilei.xing@intel.com>,
"Zhang, Qi Z" <qi.z.zhang@intel.com>,
"Wu, Jingjing" <jingjing.wu@intel.com>,
"Lu, Wenzhuo" <wenzhuo.lu@intel.com>,
"Yang, Qiming" <qiming.yang@intel.com>,
Alejandro Lucero <alejandro.lucero@netronome.com>,
Andrew Rybchenko <arybchenko@solarflare.com>,
Jerin Jacob <jerinj@marvell.com>,
Maciej Czekaj <mczekaj@marvell.com>,
"Xu, Rosen" <rosen.xu@intel.com>,
"Zhang, Tianfei" <tianfei.zhang@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 2/3] drivers: use RTE_DIM instead of ARRAY_SIZE
Date: Fri, 11 Oct 2019 09:32:04 +0000 [thread overview]
Message-ID: <2601191342CEEE43887BDE71AB97725801919757C3@irsmsx105.ger.corp.intel.com> (raw)
In-Reply-To: <VI1PR0401MB25415E1BE04D135EFE0B0EF189970@VI1PR0401MB2541.eurprd04.prod.outlook.com>
> Hi Pavan,
>
> >
> > From: Pavan Nikhilesh <pbhagavatula@marvell.com>
> >
> > Use RTE_DIM instead of re-defining ARRAY_SIZE.
> >
> > Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
> > ---
> > drivers/bus/dpaa/base/qbman/qman.c | 6 ++--
> > drivers/bus/dpaa/include/compat.h | 5 ----
> > drivers/crypto/dpaa2_sec/hw/compat.h | 8 -----
> > drivers/crypto/dpaa2_sec/hw/rta/jump_cmd.h | 6 ++--
> > drivers/crypto/dpaa2_sec/hw/rta/nfifo_cmd.h | 2 +-
> > drivers/net/atlantic/atl_hw_regs.h | 1 -
> > drivers/net/atlantic/hw_atl/hw_atl_utils.c | 4 +--
> > .../net/atlantic/hw_atl/hw_atl_utils_fw2x.c | 2 +-
> > drivers/net/axgbe/axgbe_common.h | 3 --
> > drivers/net/axgbe/axgbe_dev.c | 2 +-
> > drivers/net/bnx2x/bnx2x.c | 6 ++--
> > drivers/net/bnx2x/bnx2x.h | 6 ----
> > drivers/net/bnx2x/ecore_init.h | 8 ++---
> > drivers/net/bnx2x/ecore_sp.c | 2 +-
> > drivers/net/bnx2x/elink.c | 14 ++++-----
> > drivers/net/bnx2x/elink.h | 1 -
> > drivers/net/cxgbe/base/t4_hw.c | 16 +++++-----
> > drivers/net/cxgbe/base/t4vf_hw.c | 4 +--
> > drivers/net/cxgbe/cxgbe_compat.h | 2 --
> > drivers/net/cxgbe/cxgbe_flow.c | 4 +--
> > drivers/net/cxgbe/cxgbe_main.c | 10 +++----
> > drivers/net/cxgbe/sge.c | 2 +-
> > drivers/net/ena/ena_ethdev.c | 8 ++---
> > drivers/net/enic/base/vnic_dev.c | 4 +--
> > drivers/net/enic/base/vnic_devcmd.h | 2 --
> > drivers/net/hns3/hns3_cmd.c | 2 +-
> > drivers/net/hns3/hns3_ethdev.h | 2 --
> > drivers/net/hns3/hns3_flow.c | 18 +++++------
> > drivers/net/i40e/base/i40e_diag.c | 2 +-
> > drivers/net/i40e/base/i40e_osdep.h | 2 --
> > drivers/net/iavf/base/iavf_osdep.h | 2 --
> > drivers/net/ice/base/ice_fdir.c | 2 +-
> > drivers/net/ice/base/ice_flex_pipe.c | 2 +-
> > drivers/net/ice/base/ice_flow.c | 2 +-
> > drivers/net/ice/base/ice_osdep.h | 1 -
> > drivers/net/ice/base/ice_switch.c | 2 +-
> > .../net/nfp/nfpcore/nfp-common/nfp_platform.h | 4 ---
> > drivers/net/nfp/nfpcore/nfp_cppcore.c | 2 +-
> > drivers/net/nfp/nfpcore/nfp_nsp.c | 2 +-
> > drivers/net/nfp/nfpcore/nfp_nsp_eth.c | 4 +--
> > drivers/net/sfc/base/ef10_ev.c | 4 +--
> > drivers/net/sfc/base/ef10_filter.c | 12 ++++----
> > drivers/net/sfc/base/ef10_mac.c | 18 +++++------
> > drivers/net/sfc/base/ef10_nic.c | 4 +--
> > drivers/net/sfc/base/ef10_nvram.c | 6 ++--
> > drivers/net/sfc/base/efx.h | 3 --
> > drivers/net/sfc/base/efx_port.c | 2 +-
> > drivers/net/sfc/base/efx_rx.c | 2 +-
> > drivers/net/sfc/base/siena_mac.c | 2 +-
> > drivers/net/sfc/base/siena_nic.c | 20 ++++++-------
> > drivers/net/sfc/base/siena_nvram.c | 6 ++--
> > drivers/net/thunderx/base/nicvf_hw.c | 30 +++++++++----------
> > drivers/net/thunderx/base/nicvf_hw.h | 2 --
> > .../raw/ifpga/base/osdep_rte/osdep_generic.h | 2 --
> > 54 files changed, 120 insertions(+), 170 deletions(-)
> >
> > diff --git a/drivers/bus/dpaa/base/qbman/qman.c
> > b/drivers/bus/dpaa/base/qbman/qman.c
> > index e43fc65ef..019be95e2 100644
> > --- a/drivers/bus/dpaa/base/qbman/qman.c
> > +++ b/drivers/bus/dpaa/base/qbman/qman.c
> > @@ -1956,7 +1956,7 @@ int qman_query_wq(u8 query_dedicated, struct
> > qm_mcr_querywq *wq)
> > int i, array_len;
> >
> > wq->channel.id = be16_to_cpu(mcr->querywq.channel.id);
> > - array_len = ARRAY_SIZE(mcr->querywq.wq_len);
> > + array_len = RTE_DIM(mcr->querywq.wq_len);
>
> [Hemant] some of these files are common Flibs and they are shared with other projects (Linux/uboot) etc. It will be more appropriate to
> map the ARRAY_SIZE to RTE_DIM in compat.h instead of changing this code inline.
> This way we need not to maintain diff from the common HW lib codes.
+1 to this suggestion
next prev parent reply other threads:[~2019-10-11 9:32 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-11 4:07 [dpdk-dev] [PATCH 1/3] app/test: " pbhagavatula
2019-10-11 4:07 ` [dpdk-dev] [PATCH 2/3] drivers: " pbhagavatula
2019-10-11 4:37 ` Hemant Agrawal
2019-10-11 9:32 ` Ananyev, Konstantin [this message]
2019-10-11 13:48 ` Ferruh Yigit
2019-10-11 6:14 ` Andrew Rybchenko
2019-10-11 9:03 ` Igor Russkikh
2019-10-11 9:00 ` Hyong Youb Kim (hyonkim)
2019-10-11 4:07 ` [dpdk-dev] [PATCH 3/3] bitrate: " pbhagavatula
2019-10-11 14:20 ` [dpdk-dev] [PATCH 1/3] app/test: " Eads, Gage
2019-10-17 12:09 ` [dpdk-dev] [PATCH v2 1/2] " pbhagavatula
2019-10-17 12:10 ` [dpdk-dev] [PATCH v2 2/2] bitrate: " pbhagavatula
2019-10-27 13:36 ` David Marchand
2019-10-27 13:35 ` [dpdk-dev] [PATCH v2 1/2] app/test: " David Marchand
2019-10-14 6:58 [dpdk-dev] [PATCH 2/3] drivers: " Pavan Nikhilesh Bhagavatula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2601191342CEEE43887BDE71AB97725801919757C3@irsmsx105.ger.corp.intel.com \
--to=konstantin.ananyev@intel.com \
--cc=akhil.goyal@nxp.com \
--cc=alejandro.lucero@netronome.com \
--cc=arybchenko@solarflare.com \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=evgenys@amazon.com \
--cc=gtzalik@amazon.com \
--cc=hemant.agrawal@nxp.com \
--cc=humin29@huawei.com \
--cc=hyonkim@cisco.com \
--cc=igor.russkikh@aquantia.com \
--cc=igorch@amazon.com \
--cc=jerinj@marvell.com \
--cc=jingjing.wu@intel.com \
--cc=johndale@cisco.com \
--cc=mczekaj@marvell.com \
--cc=mk@semihalf.com \
--cc=mw@semihalf.com \
--cc=pavel.belous@aquantia.com \
--cc=pbhagavatula@marvell.com \
--cc=qi.z.zhang@intel.com \
--cc=qiming.yang@intel.com \
--cc=rahul.lakkireddy@chelsio.com \
--cc=ravi1.kumar@amd.com \
--cc=rmody@marvell.com \
--cc=rosen.xu@intel.com \
--cc=sachin.saxena@nxp.com \
--cc=shshaikh@marvell.com \
--cc=tianfei.zhang@intel.com \
--cc=wenzhuo.lu@intel.com \
--cc=xavier.huwei@huawei.com \
--cc=yisen.zhuang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).