From: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
To: "Wiles, Roger Keith (Wind River)" <keith.wiles@windriver.com>
Cc: "<dev@dpdk.org>" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] Function __mempool_get_bulk() returns wrong count.
Date: Sun, 28 Sep 2014 23:00:22 +0000 [thread overview]
Message-ID: <2601191342CEEE43887BDE71AB977258213851F7@IRSMSX104.ger.corp.intel.com> (raw)
In-Reply-To: <2085FE90-8322-4249-B22D-776E8F213A36@windriver.com>
> -----Original Message-----
> From: Wiles, Roger Keith [mailto:keith.wiles@windriver.com]
> Sent: Sunday, September 28, 2014 11:57 PM
> To: Ananyev, Konstantin
> Cc: <dev@dpdk.org>
> Subject: Re: [dpdk-dev] [PATCH] Function __mempool_get_bulk() returns wrong count.
>
>
> On Sep 28, 2014, at 5:25 PM, Ananyev, Konstantin <konstantin.ananyev@intel.com> wrote:
>
> >
> >
> >> -----Original Message-----
> >> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Wiles, Roger Keith
> >> Sent: Saturday, September 27, 2014 7:42 PM
> >> To: <dev@dpdk.org>
> >> Subject: [dpdk-dev] [PATCH] Function __mempool_get_bulk() returns wrong count.
> >>
> >>
> >> When __mempool_get_bulk() grabs entries from the cache it
> >> returns zero instead of the number of entries obtained. Plus
> >> the stats were increased by the wrong count of objects.
> >>
> >> Signed-off-by: Keith Wiles <keith.wiles@windriver.com>
> >> ---
> >> lib/librte_mempool/rte_mempool.h | 6 +++---
> >> 1 file changed, 3 insertions(+), 3 deletions(-)
> >>
> >> diff --git a/lib/librte_mempool/rte_mempool.h b/lib/librte_mempool/rte_mempool.h
> >> index 299d4d7..6750e78 100644
> >> --- a/lib/librte_mempool/rte_mempool.h
> >> +++ b/lib/librte_mempool/rte_mempool.h
> >> @@ -988,9 +988,9 @@ __mempool_get_bulk(struct rte_mempool *mp, void **obj_table,
> >>
> >> cache->len -= n;
> >>
> >> - __MEMPOOL_STAT_ADD(mp, get_success, n_orig);
> >> + __MEMPOOL_STAT_ADD(mp, get_success, n);
> >
> > As I can see n == n_orig.
> > We can completely remove n_orig, but from other side - I don't see any harm here.
>
> In the RFC patch I sent I remove n_orig.
> >
> >>
> >> - return 0;
> >> + return n;
> >
> > As I can see, __mempool_get_bulk supposed to return 0,
> > if all n objects were allocated from mbuf, or a negative error code otherwise.
> > Check all usages of __mempool_get_bulk(), plus the fact that it does below:
> > ret = rte_ring_mc_dequeue_bulk(mp->ring, obj_table, n);
> > and rte_ring_mc_dequeue_bulk() is just wrapper for __rte_ring_mc_do_dequeue(..., n, RTE_RING_QUEUE_FIXED);
> > I.e. - either allocate all n objects, or return with failure.
> > So, yes we should return 0 here.
> > The only thing that probably needs to be done here: fix the comments.
> > Instead of:
> > - >=0: Success; number of objects supplied.
> > Something like:
> > - 0: Success; n objects supplied.
> >
> >>
> >> ring_dequeue:
> >> #endif /* RTE_MEMPOOL_CACHE_MAX_SIZE > 0 */
> >> @@ -1004,7 +1004,7 @@ ring_dequeue:
> >> if (ret < 0)
> >> __MEMPOOL_STAT_ADD(mp, get_fail, n_orig);
> >> else
> >> - __MEMPOOL_STAT_ADD(mp, get_success, n_orig);
> >> + __MEMPOOL_STAT_ADD(mp, get_success, ret);
> >
> > That seems incorrect tom me.
> > ret would be either 0 on success, or negative error value.
>
> Notice 'if (ret < 0)' above so ret can not be negative in this case only zero or positive.
It can't be positive here. Only zero.
See above why.
> >
> > Konstantin
> >
> >
> >>
> >> return ret;
> >> }
> >> --
> >> 2.1.0Keith Wiles, Principal Technologist with CTO office, Wind River mobile 972-213-5533
> >
> >
> > As I can see
>
> Keith Wiles, Principal Technologist with CTO office, Wind River mobile 972-213-5533
>
prev parent reply other threads:[~2014-09-28 22:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-27 18:41 Wiles, Roger Keith
2014-09-28 0:38 ` Neil Horman
2014-09-28 22:25 ` Ananyev, Konstantin
2014-09-28 22:57 ` Wiles, Roger Keith
2014-09-28 23:00 ` Ananyev, Konstantin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2601191342CEEE43887BDE71AB977258213851F7@IRSMSX104.ger.corp.intel.com \
--to=konstantin.ananyev@intel.com \
--cc=dev@dpdk.org \
--cc=keith.wiles@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).