From: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
To: "Wang, Liang-min" <liang-min.wang@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v4 1/4] ethdev: add apis to support access device info
Date: Thu, 11 Jun 2015 13:07:10 +0000 [thread overview]
Message-ID: <2601191342CEEE43887BDE71AB97725836A08BD4@irsmsx105.ger.corp.intel.com> (raw)
In-Reply-To: <B6CB929FEBC10D4FAC4BCA7EF2298E257176822E@FMSMSX110.amr.corp.intel.com>
> -----Original Message-----
> From: Wang, Liang-min
> Sent: Thursday, June 11, 2015 1:58 PM
> To: Ananyev, Konstantin; dev@dpdk.org
> Subject: RE: [dpdk-dev] [PATCH v4 1/4] ethdev: add apis to support access device info
>
> Hi Konstantin,
>
> > -----Original Message-----
> > From: Ananyev, Konstantin
> > Sent: Thursday, June 11, 2015 8:26 AM
> > To: Wang, Liang-min; dev@dpdk.org
> > Cc: Wang, Liang-min
> > Subject: RE: [dpdk-dev] [PATCH v4 1/4] ethdev: add apis to support access
> > device info
> >
> > Hi Larry,
> >
> > > -----Original Message-----
> > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Liang-Min Larry
> > > Wang
> > > Sent: Wednesday, June 10, 2015 4:10 PM
> > > To: dev@dpdk.org
> > > Cc: Wang, Liang-min
> > > Subject: [dpdk-dev] [PATCH v4 1/4] ethdev: add apis to support access
> > > device info
> > >
> > > add new apis:
> > > - rte_eth_dev_default_mac_addr_set
> > > - rte_eth_dev_reg_leng
> > > - rte_eth_dev_reg_info
> > > - rte_eth_dev_eeprom_leng
> > > - rte_eth_dev_get_eeprom
> > > - rte_eth_dev_set_eeprom
> > > - rte_eth_dev_get_ringparam
> > > - rte_eth_dev_set_ringparam
> > >
> > > to enable reading device parameters (mac-addr, register, eeprom, ring)
> > > based upon ethtool alike data parameter specification.
> > >
> > > Signed-off-by: Liang-Min Larry Wang <liang-min.wang@intel.com>
> > > ---
> > > lib/librte_ether/Makefile | 1 +
> > > lib/librte_ether/rte_eth_dev_info.h | 80 +++++++++++++++++
> > > lib/librte_ether/rte_ethdev.c | 159
> > +++++++++++++++++++++++++++++++++
> > > lib/librte_ether/rte_ethdev.h | 158
> > ++++++++++++++++++++++++++++++++
> > > lib/librte_ether/rte_ether_version.map | 8 ++
> > > 5 files changed, 406 insertions(+)
> > > create mode 100644 lib/librte_ether/rte_eth_dev_info.h
> > >
> > > diff --git a/lib/librte_ether/Makefile b/lib/librte_ether/Makefile
> > > index c0e5768..05209e9 100644
> > > --- a/lib/librte_ether/Makefile
> > > +++ b/lib/librte_ether/Makefile
> > > @@ -51,6 +51,7 @@ SRCS-y += rte_ethdev.c SYMLINK-y-include +=
> > > rte_ether.h SYMLINK-y-include += rte_ethdev.h SYMLINK-y-include +=
> > > rte_eth_ctrl.h
> > > +SYMLINK-y-include += rte_eth_dev_info.h
> > >
> > > # this lib depends upon:
> > > DEPDIRS-y += lib/librte_eal lib/librte_mempool lib/librte_ring
> > > lib/librte_mbuf diff --git a/lib/librte_ether/rte_eth_dev_info.h
> > > b/lib/librte_ether/rte_eth_dev_info.h
> > > new file mode 100644
> > > index 0000000..002c4b5
> > > --- /dev/null
> > > +++ b/lib/librte_ether/rte_eth_dev_info.h
> > > @@ -0,0 +1,80 @@
> > > +/*-
> > > + * BSD LICENSE
> > > + *
> > > + * Copyright(c) 2015 Intel Corporation. All rights reserved.
> > > + * All rights reserved.
> > > + *
> > > + * Redistribution and use in source and binary forms, with or without
> > > + * modification, are permitted provided that the following conditions
> > > + * are met:
> > > + *
> > > + * * Redistributions of source code must retain the above copyright
> > > + * notice, this list of conditions and the following disclaimer.
> > > + * * Redistributions in binary form must reproduce the above copyright
> > > + * notice, this list of conditions and the following disclaimer in
> > > + * the documentation and/or other materials provided with the
> > > + * distribution.
> > > + * * Neither the name of Intel Corporation nor the names of its
> > > + * contributors may be used to endorse or promote products derived
> > > + * from this software without specific prior written permission.
> > > + *
> > > + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND
> > CONTRIBUTORS
> > > + * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT
> > NOT
> > > + * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND
> > FITNESS FOR
> > > + * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE
> > COPYRIGHT
> > > + * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT,
> > INCIDENTAL,
> > > + * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING,
> > BUT NOT
> > > + * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
> > LOSS OF USE,
> > > + * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED
> > AND ON ANY
> > > + * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR
> > TORT
> > > + * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT
> > OF THE USE
> > > + * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH
> > DAMAGE.
> > > + */
> > > +
> > > +#ifndef _RTE_ETH_DEV_INFO_H_
> > > +#define _RTE_ETH_DEV_INFO_H_
> > > +
> > > +
> > > +/*
> > > + * Placeholder for accessing device registers */ struct
> > > +rte_dev_reg_info {
> > > + void *buf; /**< Buffer for register */
> > > + uint32_t offset; /**< Offset for 1st register to fetch */
> > > + uint32_t leng; /**< Number of registers to fetch */
> > > + uint32_t version; /**< Device version */ };
> > > +
> > > +/*
> > > + * Placeholder for accessing device eeprom */ struct
> > > +rte_dev_eeprom_info {
> > > + void *buf; /**< Buffer for eeprom */
> > > + uint32_t offset; /**< Offset for 1st eeprom location to access */
> > > + uint32_t leng; /**< Length of eeprom region to access */
> > > + uint32_t magic; /**< Device ID */
> > > +};
> > > +
> > > +/*
> > > + * Placeholder for accessing device ring parameters */ struct
> > > +rte_dev_ring_info {
> > > + uint32_t rx_pending; /**< Number of outstanding Rx ring */
> > > + uint32_t tx_pending; /**< Number of outstanding Tx ring */
> > > + uint32_t rx_max_pending; /**< Maximum number of outstanding Rx
> > ring */
> > > + uint32_t tx_max_pending; /**< Maximum number of outstanding Tx
> > ring
> > > +*/ };
> > > +
> > > +/*
> > > + * A data structure captures information as defined in struct
> > > +ifla_vf_info
> > > + * for user-space api
> > > + */
> > > +struct rte_dev_vf_info {
> > > + uint32_t vf;
> > > + uint8_t mac[ETHER_ADDR_LEN];
> > > + uint32_t vlan;
> > > + uint32_t tx_rate;
> > > + uint32_t spoofchk;
> > > +};
> >
> >
> > Wonder what that structure is for?
> > I can't see it used in any function below?
> >
>
> Good catch, this is designed for other ethtool ops that I did not include in this release, I will remove this from next fix.
>
> > > +
> > > +#endif /* _RTE_ETH_DEV_INFO_H_ */
> > > diff --git a/lib/librte_ether/rte_ethdev.c
> > > b/lib/librte_ether/rte_ethdev.c index 5a94654..186e85c 100644
> > > --- a/lib/librte_ether/rte_ethdev.c
> > > +++ b/lib/librte_ether/rte_ethdev.c
> > > @@ -2751,6 +2751,32 @@ rte_eth_dev_mac_addr_remove(uint8_t
> > port_id,
> > > struct ether_addr *addr) }
> > >
> > > int
> > > +rte_eth_dev_default_mac_addr_set(uint8_t port_id, struct ether_addr
> > > +*addr) {
> > > + struct rte_eth_dev *dev;
> > > + const int index = 0;
> > > + const uint32_t pool = 0;
> > > +
> > > + if (!rte_eth_dev_is_valid_port(port_id)) {
> > > + PMD_DEBUG_TRACE("Invalid port_id=%d\n", port_id);
> > > + return -ENODEV;
> > > + }
> > > +
> > > + dev = &rte_eth_devices[port_id];
> > > + FUNC_PTR_OR_ERR_RET(*dev->dev_ops->mac_addr_remove, -
> > ENOTSUP);
> > > + FUNC_PTR_OR_ERR_RET(*dev->dev_ops->mac_addr_add, -
> > ENOTSUP);
> > > +
> > > + /* Update NIC default MAC address*/
> > > + (*dev->dev_ops->mac_addr_remove)(dev, index);
> > > + (*dev->dev_ops->mac_addr_add)(dev, addr, index, pool);
> > > +
> > > + /* Update default address in NIC data structure */
> > > + ether_addr_copy(addr, &dev->data->mac_addrs[index]);
> > > +
> > > + return 0;
> > > +}
> > > +
> > > +int
> > > rte_eth_dev_set_vf_rxmode(uint8_t port_id, uint16_t vf,
> > > uint16_t rx_mode, uint8_t on)
> > > {
> > > @@ -3627,3 +3653,136 @@ rte_eth_remove_tx_callback(uint8_t port_id,
> > uint16_t queue_id,
> > > /* Callback wasn't found. */
> > > return -EINVAL;
> > > }
> > > +
> > > +int
> > > +rte_eth_dev_reg_leng(uint8_t port_id) {
> > > + struct rte_eth_dev *dev;
> > > +
> > > + if (!rte_eth_dev_is_valid_port(port_id)) {
> > > + PMD_DEBUG_TRACE("Invalid port_id=%d\n", port_id);
> > > + return -ENODEV;
> > > + }
> > > +
> > > + if ((dev= &rte_eth_devices[port_id]) == NULL) {
> > > + PMD_DEBUG_TRACE("Invalid port device\n");
> > > + return -ENODEV;
> > > + }
> > > +
> > > + FUNC_PTR_OR_ERR_RET(*dev->dev_ops->get_reg_length, -
> > ENOTSUP);
> > > + return (*dev->dev_ops->get_reg_length)(dev);
> > > +}
> > > +
> > > +int
> > > +rte_eth_dev_reg_info(uint8_t port_id, struct rte_dev_reg_info *info)
> > > +{
> > > + struct rte_eth_dev *dev;
> > > +
> > > + if (!rte_eth_dev_is_valid_port(port_id)) {
> > > + PMD_DEBUG_TRACE("Invalid port_id=%d\n", port_id);
> > > + return -ENODEV;
> > > + }
> > > +
> > > + if ((dev= &rte_eth_devices[port_id]) == NULL) {
> > > + PMD_DEBUG_TRACE("Invalid port device\n");
> > > + return -ENODEV;
> > > + }
> > > +
> > > + FUNC_PTR_OR_ERR_RET(*dev->dev_ops->get_reg, -ENOTSUP);
> > > + return (*dev->dev_ops->get_reg)(dev, info); }
> >
> > Seems that *get_reg* stuff, will be really good addition for DPDK debugging
> > abilities.
> > Though, I'd suggest we change it a bit to make more generic and flexible:
> >
> > Introduce rte_eth_reg_read/rte_eth_reg_write(),
> > or probably even better rte_pcidev_reg_read /rte_pcidev_reg_write at EAL.
> > Something similar to what port_pci_reg_read/port_pci_reg_write() are
> > doing now at testpmd.h.
> >
> > struct rte_pcidev_reg_info {
> > const char *name;
> > uint32_t endianes, bar, offset, size, count; };
> >
> > int rte_pcidev_reg_read(const struct rte_pci_device *, const struct
> > rte_pcidev_reg_info *, uint64_t *reg_val);
> >
> > Then:
> > int rte_eth_dev_get_reg_info(port_id, const struct rte_pcidev_reg_info
> > **info);
> >
> > So each device would store in info a pointer to an array of it's register
> > descriptions (finished by zero elem?).
> >
> > Then your ethtool (or any other upper layer) can do the following to read all
> > device regs:
> >
>
> The proposed reg info structure allows future improvement to support individual register read/write.
> Also, because each NIC device has a very distinguish register definition.
> So, the plan is to have more comprehensive interface to support query operation (for example, register name) before introduce
> individual/group register access.
> Points taken, the support will be in future release.
Sorry, didn't get you.
So you are ok to make these changes in next patch version?
>
> > const struct rte_eth_dev_reg_info *reg_info; struct rte_eth_dev_info
> > dev_info;
> >
> > rte_eth_dev_info_get(pid, &dev_info);
> > rte_eth_dev_get_reg_info(port_id, ®_info);
> >
> > for (i = 0; reg_info[i].name != NULL; i++) {
> > ...
> > rte_pcidev_read_reg(dev_info. pci_dev, reg_info[i], &v);
> > ..
> > }
> >
> > > +
> > > +int
> > > +rte_eth_dev_eeprom_leng(uint8_t port_id) {
> > > + struct rte_eth_dev *dev;
> > > +
> > > + if (!rte_eth_dev_is_valid_port(port_id)) {
> > > + PMD_DEBUG_TRACE("Invalid port_id=%d\n", port_id);
> > > + return -ENODEV;
> > > + }
> > > +
> > > + if ((dev= &rte_eth_devices[port_id]) == NULL) {
> > > + PMD_DEBUG_TRACE("Invalid port device\n");
> > > + return -ENODEV;
> > > + }
> > > +
> > > + FUNC_PTR_OR_ERR_RET(*dev->dev_ops->get_eeprom_length, -
> > ENOTSUP);
> > > + return (*dev->dev_ops->get_eeprom_length)(dev);
> > > +}
> > > +
> > > +int
> > > +rte_eth_dev_get_eeprom(uint8_t port_id, struct rte_dev_eeprom_info
> > > +*info) {
> > > + struct rte_eth_dev *dev;
> > > +
> > > + if (!rte_eth_dev_is_valid_port(port_id)) {
> > > + PMD_DEBUG_TRACE("Invalid port_id=%d\n", port_id);
> > > + return -ENODEV;
> > > + }
> > > +
> > > + if ((dev= &rte_eth_devices[port_id]) == NULL) {
> > > + PMD_DEBUG_TRACE("Invalid port device\n");
> > > + return -ENODEV;
> > > + }
> > > +
> > > + FUNC_PTR_OR_ERR_RET(*dev->dev_ops->get_eeprom, -
> > ENOTSUP);
> > > + return (*dev->dev_ops->get_eeprom)(dev, info); }
> > > +
> > > +int
> > > +rte_eth_dev_set_eeprom(uint8_t port_id, struct rte_dev_eeprom_info
> > > +*info) {
> > > + struct rte_eth_dev *dev;
> > > +
> > > + if (!rte_eth_dev_is_valid_port(port_id)) {
> > > + PMD_DEBUG_TRACE("Invalid port_id=%d\n", port_id);
> > > + return -ENODEV;
> > > + }
> > > +
> > > + if ((dev= &rte_eth_devices[port_id]) == NULL) {
> > > + PMD_DEBUG_TRACE("Invalid port device\n");
> > > + return -ENODEV;
> > > + }
> > > +
> > > + FUNC_PTR_OR_ERR_RET(*dev->dev_ops->set_eeprom, -
> > ENOTSUP);
> > > + return (*dev->dev_ops->set_eeprom)(dev, info); }
> > > +
> > > +int
> > > +rte_eth_dev_get_ringparam(uint8_t port_id, struct rte_dev_ring_info
> > > +*info) {
> > > + struct rte_eth_dev *dev;
> > > +
> > > + if (!rte_eth_dev_is_valid_port(port_id)) {
> > > + PMD_DEBUG_TRACE("Invalid port_id=%d\n", port_id);
> > > + return -ENODEV;
> > > + }
> > > +
> > > + if ((dev= &rte_eth_devices[port_id]) == NULL) {
> > > + PMD_DEBUG_TRACE("Invalid port device\n");
> > > + return -ENODEV;
> > > + }
> > > +
> > > + FUNC_PTR_OR_ERR_RET(*dev->dev_ops->get_ringparam, -
> > ENOTSUP);
> > > + return (*dev->dev_ops->get_ringparam)(dev, info); }
> >
> > I think it will be a useful addition to the ethdev API to have an ability to
> > retrieve current RX/TX queue parameters.
> > Though again, it need to be more generic, so it could be useful for non-
> > ethtool upper layer too.
> > So I suggest to modify it a bit.
> > Something like that:
> >
> > struct rte_eth_tx_queue_info {
> > struct rte_eth_txconf txconf;
> > uint32_t nb_tx_desc;
> > uint32_t nb_max_tx_desc; /*max allowable TXDs for that queue */
> > uint32_t nb_tx_free; /* number of free TXDs at the moment of call.
> > */
> > /* other tx queue data. */
> > };
> >
> > int rte_etdev_get_tx_queue_info(portid, queue_id, struct
> > rte_eth_tx_queue_info *qinfo)
> >
> > Then, your upper layer ethtool wrapper, can implement yours
> > ethtool_get_ringparam() by:
> >
> > ...
> > struct rte_eth_tx_queue_info qinfo;
> > rte_ethdev_get_tx_queue_info(port, 0, &qinfo); ring_param->tx_pending
> > = qinfo.nb_tx_desc - rte_eth_rx_queue_count(port, 0);
> >
> > Or probably even:
> > ring_param->tx_pending = qinfo.nb_tx_desc - qinfo.nb_tx_free;
> >
> > Same for RX.
> >
> For now, this descriptor ring information is used by the ethtool op.
> To make this interface simple, i.e. caller doesn't need to access other queue information.
I just repeat what I said to you in off-line conversation:
ethdev API is not equal ethtool API.
It is ok to add a new function/structure to ethdev if it really needed, but we should do mechanical one to one copy.
It is much better to add a function/structure that would be more generic, and suit other users, not only ethtool.
There is no point to have dozen functions in rte_ethdev API providing similar information.
BTW, I don't see how API I proposed is much more complex, then yours one.
Konstantin
> The plan it so keep this information as it is.
> For the expansion, the ethdev can invoke the same dev op to add this information.
> > > +
> > > +int
> > > +rte_eth_dev_set_ringparam(uint8_t port_id, struct rte_dev_ring_info
> > > +*info) {
> > > + struct rte_eth_dev *dev;
> > > +
> > > + if (!rte_eth_dev_is_valid_port(port_id)) {
> > > + PMD_DEBUG_TRACE("Invalid port_id=%d\n", port_id);
> > > + return -ENODEV;
> > > + }
> > > +
> > > + if ((dev= &rte_eth_devices[port_id]) == NULL) {
> > > + PMD_DEBUG_TRACE("Invalid port device\n");
> > > + return -ENODEV;
> > > + }
> > > +
> > > + FUNC_PTR_OR_ERR_RET(*dev->dev_ops->set_ringparam, -
> > ENOTSUP);
> > > + return (*dev->dev_ops->set_ringparam)(dev, info); }
> >
> >
> > I am a bit confused, what particular value of rte_dev_ring_info will be
> > allowed to change?
> > You can't change number of RXD/TXD at runtime.
> > You have to stop the device first, and then reconfigure particular queue(s).
> > Again, you can't reset RXF/TXD without stopping RX/TX first.
> > So what that function is supposed to do?
> > As I can see currently, none of the PMD in your patch support it.
> >
>
> Exactly, setting RXD/TXD will require some change on kernel (RX/TX burst) function.
> As you already observe that there is no dev_op registered for set_ring.
> The API is created as a placeholder for future implementation.
> There are a couple of idea thrown around (such as mono- increase/decrease to avoid buffer overrun).
> Any suggestion is welcome.
>
> > Konstantin
> >
> > > diff --git a/lib/librte_ether/rte_ethdev.h
> > > b/lib/librte_ether/rte_ethdev.h index 16dbe00..8f99f0d 100644
> > > --- a/lib/librte_ether/rte_ethdev.h
> > > +++ b/lib/librte_ether/rte_ethdev.h
> > > @@ -182,6 +182,7 @@ extern "C" {
> > > #include <rte_devargs.h>
> > > #include "rte_ether.h"
> > > #include "rte_eth_ctrl.h"
> > > +#include "rte_eth_dev_info.h"
> > >
> > > struct rte_mbuf;
> > >
> > > @@ -1228,6 +1229,31 @@ typedef int (*eth_udp_tunnel_del_t)(struct
> > rte_eth_dev *dev,
> > > struct rte_eth_udp_tunnel *tunnel_udp);
> > /**< @internal
> > > Delete tunneling UDP info */
> > >
> > > +typedef int (*eth_get_reg_length_t)(struct rte_eth_dev *dev); /**<
> > > +@internal Retrieve device register count */
> > > +
> > > +typedef int (*eth_get_reg_t)(struct rte_eth_dev *dev,
> > > + struct rte_dev_reg_info *info);
> > > +/**< @internal Retrieve registers */
> > > +
> > > +typedef int (*eth_get_eeprom_length_t)(struct rte_eth_dev *dev);
> > /**<
> > > +@internal Retrieve eeprom size */
> > > +
> > > +typedef int (*eth_get_eeprom_t)(struct rte_eth_dev *dev,
> > > + struct rte_dev_eeprom_info *info); /**<
> > @internal Retrieve eeprom
> > > +data */
> > > +
> > > +typedef int (*eth_set_eeprom_t)(struct rte_eth_dev *dev,
> > > + struct rte_dev_eeprom_info *info); /**<
> > @internal Program eeprom
> > > +data */
> > > +
> > > +typedef int (*eth_get_ringparam_t)(struct rte_eth_dev *dev,
> > > + struct rte_dev_ring_info *info);
> > > +/**< @internal Retrieve device ring descriptor */
> > > +
> > > +typedef int (*eth_set_ringparam_t)(struct rte_eth_dev *dev,
> > > + struct rte_dev_ring_info *info);
> > > +/**< @internal Set device ring descriptor */
> > >
> > > #ifdef RTE_NIC_BYPASS
> > >
> > > @@ -1368,6 +1394,21 @@ struct eth_dev_ops {
> > > reta_update_t reta_update;
> > > /** Query redirection table. */
> > > reta_query_t reta_query;
> > > +
> > > + eth_get_reg_length_t get_reg_length;
> > > + /**< Get # of registers */
> > > + eth_get_reg_t get_reg;
> > > + /**< Get registers */
> > > + eth_get_eeprom_length_t get_eeprom_length;
> > > + /**< Get eeprom length */
> > > + eth_get_eeprom_t get_eeprom;
> > > + /**< Get eeprom data */
> > > + eth_set_eeprom_t set_eeprom;
> > > + /**< Set eeprom */
> > > + eth_get_ringparam_t get_ringparam;
> > > + /**< Get descriptor ring parameters */
> > > + eth_set_ringparam_t set_ringparam;
> > > + /**< Set descriptor ring parameters */
> > > /* bypass control */
> > > #ifdef RTE_NIC_BYPASS
> > > bypass_init_t bypass_init;
> > > @@ -2982,6 +3023,20 @@ int rte_eth_dev_mac_addr_add(uint8_t port,
> > > struct ether_addr *mac_addr, int
> > rte_eth_dev_mac_addr_remove(uint8_t
> > > port, struct ether_addr *mac_addr);
> > >
> > > /**
> > > + * Set the default MAC address.
> > > + *
> > > + * @param port
> > > + * The port identifier of the Ethernet device.
> > > + * @param mac_addr
> > > + * New default MAC address.
> > > + * @return
> > > + * - (0) if successful, or *mac_addr* didn't exist.
> > > + * - (-ENOTSUP) if hardware doesn't support.
> > > + * - (-ENODEV) if *port* invalid.
> > > + */
> > > +int rte_eth_dev_default_mac_addr_set(uint8_t port, struct ether_addr
> > > +*mac_addr);
> > > +
> > > +/**
> > > * Update Redirection Table(RETA) of Receive Side Scaling of Ethernet
> > device.
> > > *
> > > * @param port
> > > @@ -3611,6 +3666,109 @@ int rte_eth_remove_rx_callback(uint8_t
> > > port_id, uint16_t queue_id, int rte_eth_remove_tx_callback(uint8_t
> > port_id, uint16_t queue_id,
> > > struct rte_eth_rxtx_callback *user_cb);
> > >
> > > +/**
> > > + * Retrieve number of available registers for access
> > > + *
> > > + * @param port_id
> > > + * The port identifier of the Ethernet device.
> > > + * @return
> > > + * - (>=0) number of registers if successful.
> > > + * - (-ENOTSUP) if hardware doesn't support.
> > > + * - (-ENODEV) if *port_id* invalid.
> > > + * - others depends on the specific operations implementation.
> > > + */
> > > +int rte_eth_dev_reg_leng(uint8_t port_id);
> > > +
> > > +/**
> > > + * Retrieve device registers and register attributes
> > > + *
> > > + * @param port_id
> > > + * The port identifier of the Ethernet device.
> > > + * @param info
> > > + * The template includes buffer for register data and attribute to be
> > filled.
> > > + * @return
> > > + * - (0) if successful.
> > > + * - (-ENOTSUP) if hardware doesn't support.
> > > + * - (-ENODEV) if *port_id* invalid.
> > > + * - others depends on the specific operations implementation.
> > > + */
> > > +int rte_eth_dev_reg_info(uint8_t port_id, struct rte_dev_reg_info
> > > +*info);
> > > +
> > > +/**
> > > + * Retrieve size of device EEPROM
> > > + *
> > > + * @param port_id
> > > + * The port identifier of the Ethernet device.
> > > + * @return
> > > + * - (>=0) EEPROM size if successful.
> > > + * - (-ENOTSUP) if hardware doesn't support.
> > > + * - (-ENODEV) if *port_id* invalid.
> > > + * - others depends on the specific operations implementation.
> > > + */
> > > +int rte_eth_dev_eeprom_leng(uint8_t port_id);
> > > +
> > > +/**
> > > + * Retrieve EEPROM and EEPROM attribute
> > > + *
> > > + * @param port_id
> > > + * The port identifier of the Ethernet device.
> > > + * @param info
> > > + * The template includes buffer for return EEPROM data and
> > > + * EEPROM attributes to be filled.
> > > + * @return
> > > + * - (0) if successful.
> > > + * - (-ENOTSUP) if hardware doesn't support.
> > > + * - (-ENODEV) if *port_id* invalid.
> > > + * - others depends on the specific operations implementation.
> > > + */
> > > +int rte_eth_dev_get_eeprom(uint8_t port_id, struct
> > > +rte_dev_eeprom_info *info);
> > > +
> > > +/**
> > > + * Program EEPROM with provided data
> > > + *
> > > + * @param port_id
> > > + * The port identifier of the Ethernet device.
> > > + * @param info
> > > + * The template includes EEPROM data for programming and
> > > + * EEPROM attributes to be filled
> > > + * @return
> > > + * - (0) if successful.
> > > + * - (-ENOTSUP) if hardware doesn't support.
> > > + * - (-ENODEV) if *port_id* invalid.
> > > + * - others depends on the specific operations implementation.
> > > + */
> > > +int rte_eth_dev_set_eeprom(uint8_t port_id, struct
> > > +rte_dev_eeprom_info *info);
> > > +
> > > +/**
> > > + * Retrieve device descriptor ring information
> > > + *
> > > + * @param port_id
> > > + * The port identifier of the Ethernet device.
> > > + * @param info
> > > + * The template includes device ring descriptor usage information.
> > > + * @return
> > > + * - (0) if successful.
> > > + * - (-ENOTSUP) if hardware doesn't support.
> > > + * - (-ENODEV) if *port_id* invalid.
> > > + * - others depends on the specific operations implementation.
> > > + */
> > > +int rte_eth_dev_get_ringparam(uint8_t port_id, struct
> > > +rte_dev_ring_info *info);
> > > +
> > > +/**
> > > + * Set device ring descriptor parameters
> > > + *
> > > + * @param port_id
> > > + * The port identifier of the Ethernet device.
> > > + * @param info
> > > + * The template includes descriptor ring parameters to be set.
> > > + * @return
> > > + * - (0) if successful.
> > > + * - (-ENOTSUP) if hardware doesn't support.
> > > + * - (-ENODEV) if *port_id* invalid.
> > > + * - others depends on the specific operations implementation.
> > > + */
> > > +int rte_eth_dev_set_ringparam(uint8_t port_id, struct
> > > +rte_dev_ring_info *info);
> > > +
> > > #ifdef __cplusplus
> > > }
> > > #endif
> > > diff --git a/lib/librte_ether/rte_ether_version.map
> > > b/lib/librte_ether/rte_ether_version.map
> > > index a2d25a6..1b1e092 100644
> > > --- a/lib/librte_ether/rte_ether_version.map
> > > +++ b/lib/librte_ether/rte_ether_version.map
> > > @@ -102,6 +102,14 @@ DPDK_2.0 {
> > > rte_eth_tx_queue_setup;
> > > rte_eth_xstats_get;
> > > rte_eth_xstats_reset;
> > > + rte_eth_dev_default_mac_addr_set;
> > > + rte_eth_dev_reg_leng;
> > > + rte_eth_dev_reg_info;
> > > + rte_eth_dev_eeprom_leng;
> > > + rte_eth_dev_get_eeprom;
> > > + rte_eth_dev_set_eeprom;
> > > + rte_eth_dev_get_ringparam;
> > > + rte_eth_dev_set_ringparam;
> > >
> > > local: *;
> > > };
> > > --
> > > 2.1.4
next prev parent reply other threads:[~2015-06-11 13:08 UTC|newest]
Thread overview: 148+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-30 0:37 [dpdk-dev] [PATCH 0/2] User-space Ethtool Liang-Min Larry Wang
2015-05-30 0:37 ` [dpdk-dev] [PATCH 1/2] ethdev: add api to set default mac address Liang-Min Larry Wang
2015-05-30 1:57 ` Andrew Harvey (agh)
2015-05-30 0:37 ` [dpdk-dev] [PATCH 2/2] ethtool: add new library to provide ethtool-alike APIs Liang-Min Larry Wang
2015-05-30 15:48 ` Stephen Hemminger
2015-05-30 16:16 ` Wang, Liang-min
2015-05-30 19:26 ` Stephen Hemminger
2015-05-30 19:40 ` Wang, Liang-min
2015-05-31 16:48 ` Stephen Hemminger
2015-05-31 17:30 ` Wang, Liang-min
2015-05-31 18:31 ` Wang, Liang-min
2015-06-01 12:42 ` David Harton (dharton)
2015-06-10 15:09 ` [dpdk-dev] [PATCH v4 0/4] User-space Ethtool Liang-Min Larry Wang
2015-06-10 15:09 ` [dpdk-dev] [PATCH v4 1/4] ethdev: add apis to support access device info Liang-Min Larry Wang
2015-06-10 15:21 ` David Harton (dharton)
2015-06-11 12:26 ` Ananyev, Konstantin
2015-06-11 12:57 ` Wang, Liang-min
2015-06-11 13:07 ` Ananyev, Konstantin [this message]
2015-06-11 21:51 ` Wang, Liang-min
2015-06-12 12:30 ` Ananyev, Konstantin
2015-06-15 13:26 ` Wang, Liang-min
2015-06-15 13:45 ` Ananyev, Konstantin
2015-06-15 14:47 ` Wang, Liang-min
2015-06-15 18:10 ` Ananyev, Konstantin
2015-06-17 17:25 ` Ananyev, Konstantin
2015-06-15 16:05 ` David Harton (dharton)
2015-06-15 18:23 ` Ananyev, Konstantin
2015-06-16 18:15 ` Ananyev, Konstantin
2015-06-11 13:14 ` Ananyev, Konstantin
2015-06-11 13:25 ` Wang, Liang-min
2015-06-10 15:09 ` [dpdk-dev] [PATCH v4 2/4] ixgbe: add ops to support ethtool ops Liang-Min Larry Wang
2015-06-10 15:09 ` [dpdk-dev] [PATCH v4 3/4] igb: " Liang-Min Larry Wang
2015-06-10 15:09 ` [dpdk-dev] [PATCH v4 4/4] examples: new example: l2fwd-ethtool Liang-Min Larry Wang
2015-06-11 21:43 ` [dpdk-dev] [PATCH v5 0/4] User-space Ethtool Liang-Min Larry Wang
2015-06-11 21:43 ` [dpdk-dev] [PATCH v5 1/4] ethdev: add apis to support access device info Liang-Min Larry Wang
2015-06-11 21:43 ` [dpdk-dev] [PATCH v5 2/4] ixgbe: add ops to support ethtool ops Liang-Min Larry Wang
2015-06-11 21:43 ` [dpdk-dev] [PATCH v5 3/4] igb: " Liang-Min Larry Wang
2015-06-11 21:43 ` [dpdk-dev] [PATCH v5 4/4] examples: new example: l2fwd-ethtool Liang-Min Larry Wang
2015-06-12 22:03 ` [dpdk-dev] [PATCH v6 0/4] User-space Ethtool Liang-Min Larry Wang
2015-06-12 22:03 ` [dpdk-dev] [PATCH v6 1/4] ethdev: add apis to support access device info Liang-Min Larry Wang
2015-06-13 23:25 ` David Harton (dharton)
2015-06-12 22:03 ` [dpdk-dev] [PATCH v6 2/4] ixgbe: add ops to support ethtool ops Liang-Min Larry Wang
2015-06-12 22:03 ` [dpdk-dev] [PATCH v6 3/4] igb: " Liang-Min Larry Wang
2015-06-12 22:03 ` [dpdk-dev] [PATCH v6 4/4] examples: new example: l2fwd-ethtool Liang-Min Larry Wang
2015-06-13 0:21 ` [dpdk-dev] [PATCH v6 0/4] User-space Ethtool Andrew Harvey (agh)
2015-06-17 22:22 ` [dpdk-dev] [PATCH v7 " Liang-Min Larry Wang
2015-06-17 22:22 ` [dpdk-dev] [PATCH v7 1/4] ethdev: add apis to support access device info Liang-Min Larry Wang
2015-06-25 13:39 ` Stephen Hemminger
2015-06-25 20:58 ` Wang, Liang-min
2015-06-25 13:44 ` Stephen Hemminger
2015-06-25 21:05 ` Wang, Liang-min
2015-06-17 22:22 ` [dpdk-dev] [PATCH v7 2/4] ixgbe: add ops to support ethtool ops Liang-Min Larry Wang
2015-06-25 13:45 ` Stephen Hemminger
2015-06-26 6:26 ` Andrew Harvey (agh)
2015-06-17 22:22 ` [dpdk-dev] [PATCH v7 3/4] igb: " Liang-Min Larry Wang
2015-06-17 22:22 ` [dpdk-dev] [PATCH v7 4/4] examples: new example: l2fwd-ethtool Liang-Min Larry Wang
2015-06-18 2:04 ` [dpdk-dev] [PATCH v7 0/4] User-space Ethtool Stephen Hemminger
2015-06-18 12:47 ` Wang, Liang-min
2015-06-23 15:19 ` Wang, Liang-min
2015-06-24 13:55 ` Andrew Harvey (agh)
2015-06-24 17:16 ` David Harton (dharton)
2015-06-26 14:26 ` [dpdk-dev] [PATCH v8 0/5] " Liang-Min Larry Wang
2015-06-26 14:26 ` [dpdk-dev] [PATCH v8 1/5] ethdev: add apis to support access device info Liang-Min Larry Wang
2015-06-26 16:51 ` Stephen Hemminger
2015-06-26 17:05 ` Wang, Liang-min
2015-06-27 1:21 ` Wang, Liang-min
2015-06-26 14:26 ` [dpdk-dev] [PATCH v8 2/5] ixgbe: add ops to support ethtool ops Liang-Min Larry Wang
2015-06-26 14:26 ` [dpdk-dev] [PATCH v8 3/5] igb: " Liang-Min Larry Wang
2015-06-26 14:26 ` [dpdk-dev] [PATCH v8 4/5] examples: new example: l2fwd-ethtool Liang-Min Larry Wang
2015-06-26 14:26 ` [dpdk-dev] [PATCH v8 5/5] Changed register tables to const Liang-Min Larry Wang
2015-06-26 19:15 ` [dpdk-dev] [PATCH v8 0/5] User-space Ethtool Ananyev, Konstantin
2015-06-27 1:19 ` [dpdk-dev] [PATCH v9 " Liang-Min Larry Wang
2015-06-27 1:19 ` [dpdk-dev] [PATCH v9 1/5] ethdev: add apis to support access device info Liang-Min Larry Wang
2015-06-27 1:19 ` [dpdk-dev] [PATCH v9 2/5] ixgbe: add ops to support ethtool ops Liang-Min Larry Wang
2015-06-27 1:32 ` Stephen Hemminger
2015-06-27 2:37 ` Wang, Liang-min
2015-06-27 1:34 ` Stephen Hemminger
2015-06-27 2:39 ` Wang, Liang-min
2015-06-27 1:34 ` Stephen Hemminger
2015-06-27 1:19 ` [dpdk-dev] [PATCH v9 3/5] igb: " Liang-Min Larry Wang
2015-06-27 1:35 ` Stephen Hemminger
2015-06-27 1:19 ` [dpdk-dev] [PATCH v9 4/5] examples: new example: l2fwd-ethtool Liang-Min Larry Wang
2015-06-27 1:19 ` [dpdk-dev] [PATCH v9 5/5] ixgbe/igb: changed register tables to const Liang-Min Larry Wang
2015-06-27 1:36 ` Stephen Hemminger
2015-06-27 1:50 ` Wang, Liang-min
2015-06-27 2:40 ` Wang, Liang-min
2015-07-10 12:55 ` Wang, Liang-min
2015-06-27 2:36 ` [dpdk-dev] [PATCH v10 0/4] User-space Ethtool Liang-Min Larry Wang
2015-06-27 2:36 ` [dpdk-dev] [PATCH v10 1/4] ethdev: add apis to support access device info Liang-Min Larry Wang
2015-06-27 2:36 ` [dpdk-dev] [PATCH v10 2/4] ixgbe: add ops to support ethtool ops Liang-Min Larry Wang
2015-06-27 2:36 ` [dpdk-dev] [PATCH v10 3/4] igb: " Liang-Min Larry Wang
2015-06-27 2:36 ` [dpdk-dev] [PATCH v10 4/4] examples: new example: l2fwd-ethtool Liang-Min Larry Wang
2015-06-27 12:25 ` [dpdk-dev] [PATCH v11 0/4] User-space Ethtool Liang-Min Larry Wang
2015-06-27 12:25 ` [dpdk-dev] [PATCH v11 1/4] ethdev: add apis to support access device info Liang-Min Larry Wang
2015-06-27 12:25 ` [dpdk-dev] [PATCH v11 2/4] ixgbe: add ops to support ethtool ops Liang-Min Larry Wang
2015-06-27 12:25 ` [dpdk-dev] [PATCH v11 3/4] igb: " Liang-Min Larry Wang
2015-06-27 12:25 ` [dpdk-dev] [PATCH v11 4/4] examples: new example: l2fwd-ethtool Liang-Min Larry Wang
2015-07-07 17:39 ` [dpdk-dev] [PATCH v12 0/4] User-space Ethtool Liang-Min Larry Wang
2015-07-07 17:39 ` [dpdk-dev] [PATCH v12 1/4] ethdev: add apis to support access device info Liang-Min Larry Wang
2015-07-07 17:39 ` [dpdk-dev] [PATCH v12 2/4] ixgbe: add ops to support ethtool ops Liang-Min Larry Wang
2015-07-07 17:39 ` [dpdk-dev] [PATCH v12 3/4] igb: " Liang-Min Larry Wang
2015-07-07 17:39 ` [dpdk-dev] [PATCH v12 4/4] examples: new example: l2fwd-ethtool Liang-Min Larry Wang
2015-07-10 12:48 ` [dpdk-dev] [PATCH v13 0/4] User-space Ethtool Liang-Min Larry Wang
2015-07-10 12:48 ` [dpdk-dev] [PATCH v13 1/4] ethdev: add apis to support access device info Liang-Min Larry Wang
2015-07-10 12:48 ` [dpdk-dev] [PATCH v13 2/4] ixgbe: add ops to support ethtool ops Liang-Min Larry Wang
2015-07-10 12:48 ` [dpdk-dev] [PATCH v13 3/4] igb: " Liang-Min Larry Wang
2015-07-10 12:48 ` [dpdk-dev] [PATCH v13 4/4] examples: new example: l2fwd-ethtool Liang-Min Larry Wang
2015-07-12 21:22 ` [dpdk-dev] [PATCH v14 0/4] User-space Ethtool Liang-Min Larry Wang
2015-07-12 21:22 ` [dpdk-dev] [PATCH v14 1/4] ethdev: add apis to support access device info Liang-Min Larry Wang
2015-07-13 22:26 ` Thomas Monjalon
2015-07-12 21:22 ` [dpdk-dev] [PATCH v14 2/4] ixgbe: add ops to support ethtool ops Liang-Min Larry Wang
2015-07-12 21:22 ` [dpdk-dev] [PATCH v14 3/4] igb: " Liang-Min Larry Wang
2015-07-12 21:22 ` [dpdk-dev] [PATCH v14 4/4] examples: new example: l2fwd-ethtool Liang-Min Larry Wang
2015-07-14 2:18 ` [dpdk-dev] [PATCH v15 0/4] User-space Ethtool Liang-Min Larry Wang
2015-07-14 2:18 ` [dpdk-dev] [PATCH v15 1/4] ethdev: add apis to support access device info Liang-Min Larry Wang
2015-07-15 6:16 ` Thomas Monjalon
2015-07-15 10:07 ` Wang, Liang-min
2015-07-15 10:27 ` Thomas Monjalon
2015-07-15 10:48 ` Wang, Liang-min
2015-07-15 11:20 ` Thomas Monjalon
2015-07-15 11:36 ` Wang, Liang-min
2015-07-15 12:06 ` Thomas Monjalon
2015-07-14 2:18 ` [dpdk-dev] [PATCH v15 2/4] ixgbe: add ops to support ethtool ops Liang-Min Larry Wang
2015-07-14 2:18 ` [dpdk-dev] [PATCH v15 3/4] igb: " Liang-Min Larry Wang
2015-07-14 2:18 ` [dpdk-dev] [PATCH v15 4/4] examples: new example: l2fwd-ethtool Liang-Min Larry Wang
2015-07-14 13:11 ` [dpdk-dev] [PATCH v16 0/6] User-space Ethtool Liang-Min Larry Wang
2015-07-14 13:11 ` [dpdk-dev] [PATCH v16 1/6] ethdev: add apis to support access device info Liang-Min Larry Wang
2015-07-14 13:11 ` [dpdk-dev] [PATCH v16 2/6] ixgbe: add ops to support ethtool ops Liang-Min Larry Wang
2015-07-14 13:11 ` [dpdk-dev] [PATCH v16 3/6] igb: " Liang-Min Larry Wang
2015-07-14 13:11 ` [dpdk-dev] [PATCH v16 4/6] examples: new example: l2fwd-ethtool Liang-Min Larry Wang
2015-07-14 13:11 ` [dpdk-dev] [PATCH v16 5/6] ethdev: change api name, version information and fix macro Liang-Min Larry Wang
2015-07-14 13:11 ` [dpdk-dev] [PATCH v16 6/6] examples/l2fwd-ethtool: replace lib with new API name Liang-Min Larry Wang
2015-07-14 20:13 ` [dpdk-dev] [PATCH v16 0/6] User-space Ethtool Thomas Monjalon
2015-07-14 20:56 ` Wang, Liang-min
2015-07-15 5:53 ` Thomas Monjalon
2015-07-15 10:15 ` Wang, Liang-min
2015-07-15 10:30 ` Thomas Monjalon
2015-07-16 13:25 ` [dpdk-dev] [PATCH v17 0/5] " Liang-Min Larry Wang
2015-07-16 13:25 ` [dpdk-dev] [PATCH v17 1/5] ethdev: add api to support setting default mac addr Liang-Min Larry Wang
2015-07-16 13:25 ` [dpdk-dev] [PATCH v17 2/5] ethdev: add apis to support access device info Liang-Min Larry Wang
2015-07-16 13:25 ` [dpdk-dev] [PATCH v17 3/5] ixgbe: add ops to support ethtool ops Liang-Min Larry Wang
2015-07-16 13:25 ` [dpdk-dev] [PATCH v17 4/5] igb: " Liang-Min Larry Wang
2015-07-16 13:25 ` [dpdk-dev] [PATCH v17 5/5] examples: new example: l2fwd-ethtool Liang-Min Larry Wang
2015-07-16 21:25 ` Thomas Monjalon
2015-07-16 21:48 ` [dpdk-dev] [PATCH v17 0/5] User-space Ethtool Thomas Monjalon
2015-07-16 21:55 ` Wang, Liang-min
2015-07-16 22:09 ` Thomas Monjalon
2015-07-16 22:15 ` Wang, Liang-min
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2601191342CEEE43887BDE71AB97725836A08BD4@irsmsx105.ger.corp.intel.com \
--to=konstantin.ananyev@intel.com \
--cc=dev@dpdk.org \
--cc=liang-min.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).