From: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
To: HePeng <xnhp0320@icloud.com>, "Lu, Wenzhuo" <wenzhuo.lu@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] [new]ixgbe:set txep.mbuf to NULL when calling ixgbe_tx_free_bufs
Date: Mon, 3 Aug 2015 10:16:15 +0000 [thread overview]
Message-ID: <2601191342CEEE43887BDE71AB97725836A6C214@irsmsx105.ger.corp.intel.com> (raw)
In-Reply-To: <379327D6-D2AB-467E-9F95-88F449B7EF4E@icloud.com>
Hi Peng,
As Wenzhuo pointed, we have a special version of tx_release_mbufs fo vector TX:
ixgbe_tx_queue_release_mbufs_vec().
It only frees sw_ring[] entries that contains valid mbufs.
So we don't need to set sw_ring[].mbuf = NULL at ixgbe_tx_free_bufs().
About the panic you mentioned: I think that was fixed just few days ago.
Please have a look at:
http://dpdk.org/ml/archives/dev/2015-July/022146.html
Konstantin
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of HePeng
> Sent: Monday, August 03, 2015 10:12 AM
> To: Lu, Wenzhuo
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] [new]ixgbe:set txep.mbuf to NULL when calling ixgbe_tx_free_bufs
>
> Hi, wenzhuo,
> Have to check that because I really had the panic when compile my code with dpdk 2.0.0.
>
> Also I checked the code in the dpdk git repo. It does not check the reference count, it just only calculate
> the begin positions of mbufs that really needs to be recycled.
> my code is retrieved from git://dpdk.org/dpdk <git://dpdk.org/dpdk>.
>
> Thanks for reviewing.
>
> > 在 2015年8月3日，下午4:42，Lu, Wenzhuo <wenzhuo.lu@intel.com> 写道：
> >
> > Hi Peng,
> > There’re 2 versions of ixgbe_tx_queue_release_mbufs. One in ixgbe_rxtx.c, the other is in ixgbe_rxtx_vec.c.
> > What you shown is the one in ixgbe_rxtx.c. You can find the one in ixgbe_rxtx_vec.c already has the sanity check for reference
> count.
> > Thanks.
next prev parent reply other threads:[~2015-08-03 10:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-01 1:26 hepeng
2015-08-03 2:46 ` Lu, Wenzhuo
[not found] ` <179B898C-F03A-4250-8857-236CFC5274BA@icloud.com>
[not found] ` <6A0DE07E22DDAD4C9103DF62FEBC0909D1A59D@shsmsx102.ccr.corp.intel.com>
2015-08-03 7:09 ` HePeng
2015-08-03 8:10 ` Lu, Wenzhuo
2015-08-03 8:17 ` HePeng
2015-08-03 8:42 ` Lu, Wenzhuo
2015-08-03 9:12 ` HePeng
2015-08-03 10:16 ` Ananyev, Konstantin [this message]
2015-08-04 10:50 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2601191342CEEE43887BDE71AB97725836A6C214@irsmsx105.ger.corp.intel.com \
--to=konstantin.ananyev@intel.com \
--cc=dev@dpdk.org \
--cc=wenzhuo.lu@intel.com \
--cc=xnhp0320@icloud.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).