From: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
To: Amine Kherbouche <amine.kherbouche@6wind.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [dpdk-dev, PATCHv6 1/6] ethdev: enhance rte_eth_(tx|rx)q_info struct
Date: Tue, 20 Oct 2015 09:36:37 +0000 [thread overview]
Message-ID: <2601191342CEEE43887BDE71AB97725836AB2B07@irsmsx105.ger.corp.intel.com> (raw)
In-Reply-To: <1445292384-19815-2-git-send-email-amine.kherbouche@6wind.com>
Hi Amine,
> -----Original Message-----
> From: Amine Kherbouche [mailto:amine.kherbouche@6wind.com]
> Sent: Monday, October 19, 2015 11:06 PM
> To: dev@dpdk.org
> Cc: amine.kherbouche@6wind.com; vincent.jardin@6wind.com; Ananyev, Konstantin
> Subject: [dpdk-dev,PATCHv6 1/6] ethdev: enhance rte_eth_(tx|rx)q_info struct
>
> Add 2 fields in struct rte_eth_(tx|rx)q_info :
> - used_desc : for used queue descriptors
> - free_desc : for free queue descriptors
> for ability to query more information from queues.
As I can see your patch series should be applied on top of mine:
[PATCHv5 0/8] ethdev: add new API to retrieve RX/TX queue information
Which is not yet in the dpdk.org mainline.
I believe that is ok, but then you shouldn't replace previous version with the patch (v5)
with new one, but create a new patch for your changes and clearly state that dependency.
Konstantin
>
> Signed-off-by: Amine Kherbouche <amine.kherbouche@6wind.com>
> ---
> lib/librte_ether/rte_ethdev.h | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h
> index 4d7b6f2..5fc86a0 100644
> --- a/lib/librte_ether/rte_ethdev.h
> +++ b/lib/librte_ether/rte_ethdev.h
> @@ -874,6 +874,8 @@ struct rte_eth_rxq_info {
> struct rte_eth_rxconf conf; /**< queue config parameters. */
> uint8_t scattered_rx; /**< scattered packets RX supported. */
> uint16_t nb_desc; /**< configured number of RXDs. */
> + uint16_t used_desc; /**< number of used descriptors */
> + uint16_t free_desc; /**< number of free descriptors */
> } __rte_cache_aligned;
>
> /**
> @@ -883,6 +885,8 @@ struct rte_eth_rxq_info {
> struct rte_eth_txq_info {
> struct rte_eth_txconf conf; /**< queue config parameters. */
> uint16_t nb_desc; /**< configured number of TXDs. */
> + uint16_t used_desc; /**< number of used descriptors */
> + uint16_t free_desc; /**< number of free descriptors */
> } __rte_cache_aligned;
>
> struct rte_eth_dev;
> --
> 1.7.10.4
next prev parent reply other threads:[~2015-10-20 9:36 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-01 19:54 [dpdk-dev] [PATCHv5 0/8] ethdev: add new API to retrieve RX/TX queue information Konstantin Ananyev
2015-10-01 19:54 ` [dpdk-dev] [PATCHv5 1/8] " Konstantin Ananyev
2015-10-14 11:39 ` [dpdk-dev] [dpdk-dev, PATCHv5, " Amine Kherbouche
2015-10-14 11:49 ` Ananyev, Konstantin
2015-10-14 12:21 ` Amine Kherbouche
2015-10-14 12:42 ` Ananyev, Konstantin
2015-10-14 12:47 ` Amine Kherbouche
2015-10-14 12:48 ` Ananyev, Konstantin
2015-10-20 7:53 ` Qiu, Michael
2015-10-20 8:09 ` Vincent JARDIN
2015-10-20 8:32 ` Qiu, Michael
2015-10-14 12:44 ` [dpdk-dev] [PATCHv5 " Remy Horton
2015-10-14 16:09 ` Stephen Hemminger
2015-10-14 18:44 ` Ananyev, Konstantin
2015-10-16 13:16 ` Bruce Richardson
2015-10-19 22:06 ` [dpdk-dev] [dpdk-dev,PATCHv6 0/6] Enhance queue information API Amine Kherbouche
2015-10-19 22:06 ` [dpdk-dev] [dpdk-dev, PATCHv6 1/6] ethdev: enhance rte_eth_(tx|rx)q_info struct Amine Kherbouche
2015-10-19 22:44 ` Stephen Hemminger
2015-10-20 9:52 ` Ananyev, Konstantin
2015-10-20 14:55 ` Amine Kherbouche
2015-10-20 9:36 ` Ananyev, Konstantin [this message]
2015-10-20 15:16 ` Thomas Monjalon
2015-10-19 22:06 ` [dpdk-dev] [dpdk-dev, PATCHv6 2/6] testpmd: enhance the command to display RX/TX queue information Amine Kherbouche
2015-10-19 22:06 ` [dpdk-dev] [dpdk-dev, PATCHv6 3/6] virtio: add support for eth_(rxq|txq)_info_get Amine Kherbouche
2015-10-20 7:31 ` Tan, Jianfeng
2015-10-19 22:06 ` [dpdk-dev] [dpdk-dev, PATCHv6 4/6] e1000: enhance eth_(rxq|txq)_info_get to retrieve more queue information Amine Kherbouche
2015-10-19 22:06 ` [dpdk-dev] [dpdk-dev, PATCHv6 5/6] i40e: " Amine Kherbouche
2015-10-19 22:43 ` Stephen Hemminger
2015-10-19 22:06 ` [dpdk-dev] [dpdk-dev, PATCHv6 6/6] ixgbe: " Amine Kherbouche
2015-10-01 19:54 ` [dpdk-dev] [PATCHv5 2/8] i40e: add support for eth_(rxq|txq)_info_get and (rx|tx)_desc_lim Konstantin Ananyev
2015-10-14 12:46 ` Remy Horton
2015-10-01 19:54 ` [dpdk-dev] [PATCHv5 3/8] ixgbe: " Konstantin Ananyev
2015-10-14 12:47 ` Remy Horton
2015-10-01 19:54 ` [dpdk-dev] [PATCHv5 4/8] e1000: " Konstantin Ananyev
2015-10-14 12:48 ` Remy Horton
2015-10-01 19:54 ` [dpdk-dev] [PATCHv5 5/8] fm10k: add HW specific desc_lim data into dev_info Konstantin Ananyev
2015-10-14 12:48 ` Remy Horton
2015-10-01 19:54 ` [dpdk-dev] [PATCHv5 6/8] cxgbe: " Konstantin Ananyev
2015-10-14 12:49 ` Remy Horton
2015-10-01 19:54 ` [dpdk-dev] [PATCHv5 7/8] vmxnet3: " Konstantin Ananyev
2015-10-14 12:49 ` Remy Horton
2015-10-01 19:54 ` [dpdk-dev] [PATCHv5 8/8] testpmd: add new command to display RX/TX queue information Konstantin Ananyev
2015-10-14 12:49 ` Remy Horton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2601191342CEEE43887BDE71AB97725836AB2B07@irsmsx105.ger.corp.intel.com \
--to=konstantin.ananyev@intel.com \
--cc=amine.kherbouche@6wind.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).