From: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
To: "Pattan, Reshma" <reshma.pattan@intel.com>,
Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 1/3] examples/distributor: fix build for non-x86 arch
Date: Fri, 5 Feb 2016 15:15:14 +0000 [thread overview]
Message-ID: <2601191342CEEE43887BDE71AB97725836B0465D@irsmsx105.ger.corp.intel.com> (raw)
In-Reply-To: <3AEA2BF9852C6F48A459DA490692831FFBEB4C@IRSMSX109.ger.corp.intel.com>
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Pattan, Reshma
> Sent: Friday, February 05, 2016 3:08 PM
> To: Thomas Monjalon
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH 1/3] examples/distributor: fix build for non-x86 arch
>
> Hi Thomas,
>
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon
> > Sent: Friday, February 5, 2016 2:54 PM
> > To: Richardson, Bruce; Horton, Remy
> > Cc: dev@dpdk.org
> > Subject: [dpdk-dev] [PATCH 1/3] examples/distributor: fix build for non-x86 arch
> >
> > _mm_prefetch is defined only in x86 compilers.
> > rte_prefetch functions are defined in EAL for each arch, and must be preferred
> > over compiler intrinsics.
> >
> > Fixes: 07db4a975094 ("examples/distributor: new sample app")
> >
> > Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
> > ---
> > examples/distributor/main.c | 8 ++++----
> > 1 file changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/examples/distributor/main.c b/examples/distributor/main.c index
> > 4e74f8f..87344ac 100644
> > --- a/examples/distributor/main.c
> > +++ b/examples/distributor/main.c
> > @@ -335,13 +335,13 @@ lcore_tx(struct rte_ring *in_r)
> >
> > /* for traffic we receive, queue it up for transmit */
> > uint16_t i;
> > - _mm_prefetch((void *)bufs[0], 0);
> > - _mm_prefetch((void *)bufs[1], 0);
> > - _mm_prefetch((void *)bufs[2], 0);
> > + rte_prefetch0((void *)bufs[0]);
> > + rte_prefetch0((void *)bufs[1]);
> > + rte_prefetch0((void *)bufs[2]);
>
> Some time back Jerin Jacob has sent patch for replacing the _mm_prefetch with rte_prefetch_non_temporal. This is FYI.
Yep:
http://dpdk.org/dev/patchwork/patch/9369/
http://dpdk.org/dev/patchwork/patch/9370/
And on IA _mm_prefetch(p, 0) != rte_prefetch0(p).
I think, as in Jacob implementation, it should be PREFETCHNTA.
Konstantin
>
> Thanks,
> Reshma
>
> > for (i = 0; i < nb_rx; i++) {
> > struct output_buffer *outbuf;
> > uint8_t outp;
> > - _mm_prefetch((void *)bufs[i + 3], 0);
> > + rte_prefetch0((void *)bufs[i + 3]);
> > /*
> > * workers should update in_port to hold the
> > * output port value
> > --
> > 2.7.0
next prev parent reply other threads:[~2016-02-05 15:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-05 14:54 [dpdk-dev] [PATCH 0/3] fix compilation of examples for ARM Thomas Monjalon
2016-02-05 14:54 ` [dpdk-dev] [PATCH 1/3] examples/distributor: fix build for non-x86 arch Thomas Monjalon
2016-02-05 15:07 ` Pattan, Reshma
2016-02-05 15:15 ` Ananyev, Konstantin [this message]
2016-02-05 15:55 ` Thomas Monjalon
2016-02-05 14:54 ` [dpdk-dev] [PATCH 2/3] examples/ethtool: fix build Thomas Monjalon
2016-02-15 11:15 ` Remy Horton
2016-02-05 14:54 ` [dpdk-dev] [PATCH 3/3] examples: fix build dependencies Thomas Monjalon
2016-02-16 6:50 ` [dpdk-dev] [PATCH 0/3] fix compilation of examples for ARM Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2601191342CEEE43887BDE71AB97725836B0465D@irsmsx105.ger.corp.intel.com \
--to=konstantin.ananyev@intel.com \
--cc=dev@dpdk.org \
--cc=reshma.pattan@intel.com \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).