From: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"Kantecki, Tomasz" <tomasz.kantecki@intel.com>
Subject: Re: [dpdk-dev] [PATCH] eal: Initial implementation of PQoS EAL extension
Date: Wed, 24 Feb 2016 11:21:30 +0000 [thread overview]
Message-ID: <2601191342CEEE43887BDE71AB97725836B0AB6C@irsmsx105.ger.corp.intel.com> (raw)
In-Reply-To: <1520606.5uKYNpmzaU@xps13>
> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Wednesday, February 24, 2016 10:35 AM
> To: Ananyev, Konstantin
> Cc: Richardson, Bruce; dev@dpdk.org; Kantecki, Tomasz
> Subject: Re: [dpdk-dev] [PATCH] eal: Initial implementation of PQoS EAL extension
>
> 2016-02-24 10:22, Ananyev, Konstantin:
> >
> > > -----Original Message-----
> > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Bruce Richardson
> > > Sent: Wednesday, February 24, 2016 10:10 AM
> > > To: Thomas Monjalon
> > > Cc: dev@dpdk.org; Kantecki, Tomasz
> > > Subject: Re: [dpdk-dev] [PATCH] eal: Initial implementation of PQoS EAL extension
> > >
> > > On Wed, Feb 24, 2016 at 09:24:33AM +0100, Thomas Monjalon wrote:
> > > > 2016-02-23 23:03, Kantecki, Tomasz:
> > > > > > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> > > > > > If there is nothing specific in DPDK for PQos, why writing an example in
> > > > > > DPDK?
> > > > > The example makes it much easier to use the technology with DPDK.
> > > > >
> > > > > > Maybe the example should be better in the library itself.
> > > > > The library in question (https://github.com/01org/intel-cmt-cat) has a couple of examples but none of them refers to DPDK.
> > > > >
> > > > > > I suggest to mention the library in
> > > > > > doc/guides/linux_gsg/nic_perf_intel_platform.rst
> > > > > Ok it can be added to this document. Does it imply -1 for the sample code idea?
> > > >
> > > > I may be wrong but I have the feeling the example is more about PQoS than DPDK.
> > > > So yes, I would vote -1.
> > > >
> > > Well, the intersection of DPDK and PQoS is what the example is really all about,
> > > and as such it is relevant to both DPDK and the library itself. Platform QoS
> > > can be of great use to packet processing applications for helping to ensure that
> > > the app gets the resources it needed - especially in a virtualised world - and
> > > so we believe that having an example in DPDK showing how to use PQoS with DPDK
> > > is well worthwhile having. It's more effective than a simple doc update in
> > > raising awareness of the existence of the feature, and also provides for DPDK
> > > users a readily available app for the user to start playing with to evaluate
> > > PQoS for their own use-cases.
> >
> > +1
> > I also think it is a good thing to have.
> > Again user don't have to trust the whitepapers - instead he can run the app
> > and measure performance gain on his particular platform.
>
> I totally agree the example is good to have.
> Konstantin, are you thinking it must be hosted in the PQoS lib repository?
Personally I prefer it to be part of dpdk samples.
DPDK IO code path is a bit different from what the 'classical' user app usually does -
a lot of polling, avoid system calls, etc.
Also it would probably have much better visibility here.
Again, as Bruce already mentioned, we have QAT & TAP samples, why we can't have PQoS too.
Konstantin
next prev parent reply other threads:[~2016-02-24 11:21 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-22 13:12 Kantecki, Tomasz
2016-02-22 13:22 ` Thomas Monjalon
2016-02-23 10:03 ` Kantecki, Tomasz
2016-02-23 16:41 ` Thomas Monjalon
2016-02-23 23:03 ` Kantecki, Tomasz
2016-02-24 8:24 ` Thomas Monjalon
2016-02-24 10:10 ` Bruce Richardson
2016-02-24 10:22 ` Ananyev, Konstantin
2016-02-24 10:34 ` Thomas Monjalon
2016-02-24 11:21 ` Ananyev, Konstantin [this message]
2016-02-24 11:45 ` Thomas Monjalon
2016-02-24 13:47 ` Ananyev, Konstantin
2016-02-24 10:31 ` Thomas Monjalon
2016-02-24 11:00 ` Bruce Richardson
-- strict thread matches above, loose matches on Subject: below --
2016-02-24 15:14 Ananyev, Konstantin
2016-02-24 16:30 ` Thomas Monjalon
2016-01-29 13:29 Wojciech Andralojc
2016-02-16 16:36 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2601191342CEEE43887BDE71AB97725836B0AB6C@irsmsx105.ger.corp.intel.com \
--to=konstantin.ananyev@intel.com \
--cc=dev@dpdk.org \
--cc=thomas.monjalon@6wind.com \
--cc=tomasz.kantecki@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).