From: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
To: "Kulasek, TomaszX" <tomaszx.kulasek@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] examples/l3fwd: fix some packets lost when stops receiving
Date: Thu, 31 Mar 2016 13:52:44 +0000 [thread overview]
Message-ID: <2601191342CEEE43887BDE71AB97725836B22E89@irsmsx105.ger.corp.intel.com> (raw)
In-Reply-To: <1459431488-5408-1-git-send-email-tomaszx.kulasek@intel.com>
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Tomasz Kulasek
> Sent: Thursday, March 31, 2016 2:38 PM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH] examples/l3fwd: fix some packets lost when stops receiving
>
> Not all tx ports was included in tx_port_id array, used to periodically
> drain only available ports. This caused that some packets remain in buffer
> when application stops to receiving packets.
>
> Fixes: 52c97adc1f0f ("examples/l3fwd: fix exact match performance")
>
> Signed-off-by: Tomasz Kulasek <tomaszx.kulasek@intel.com>
> ---
> examples/l3fwd/main.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/examples/l3fwd/main.c b/examples/l3fwd/main.c
> index e10dab9..92fda3b 100644
> --- a/examples/l3fwd/main.c
> +++ b/examples/l3fwd/main.c
> @@ -836,7 +836,6 @@ main(int argc, char **argv)
> unsigned lcore_id;
> uint32_t n_tx_queue, nb_lcores;
> uint8_t portid, nb_rx_queue, queue, socketid;
> - uint8_t nb_tx_port;
>
> /* init EAL */
> ret = rte_eal_init(argc, argv);
> @@ -876,7 +875,6 @@ main(int argc, char **argv)
> rte_exit(EXIT_FAILURE, "check_port_config failed\n");
>
> nb_lcores = rte_lcore_count();
> - nb_tx_port = 0;
>
> /* Setup function pointers for lookup method. */
> setup_l3fwd_lookup_tables();
> @@ -954,12 +952,10 @@ main(int argc, char **argv)
> qconf->tx_queue_id[portid] = queueid;
> queueid++;
>
> - qconf->n_tx_port = nb_tx_port;
> qconf->tx_port_id[qconf->n_tx_port] = portid;
> + qconf->n_tx_port++;
> }
> printf("\n");
> -
> - nb_tx_port++;
> }
>
> for (lcore_id = 0; lcore_id < RTE_MAX_LCORE; lcore_id++) {
> --
Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
> 1.7.9.5
next prev parent reply other threads:[~2016-03-31 13:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-31 13:38 Tomasz Kulasek
2016-03-31 13:52 ` Ananyev, Konstantin [this message]
2016-03-31 20:42 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2601191342CEEE43887BDE71AB97725836B22E89@irsmsx105.ger.corp.intel.com \
--to=konstantin.ananyev@intel.com \
--cc=dev@dpdk.org \
--cc=tomaszx.kulasek@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).