From: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
To: "Dai, Wei" <wei.dai@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Dai, Wei" <wei.dai@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2 1/2] eal: remove redundant codes to parse --lcores
Date: Tue, 26 Jul 2016 11:51:57 +0000 [thread overview]
Message-ID: <2601191342CEEE43887BDE71AB97725836B820CA@irsmsx105.ger.corp.intel.com> (raw)
In-Reply-To: <1469526749-19698-1-git-send-email-wei.dai@intel.com>
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Wei Dai
> Sent: Tuesday, July 26, 2016 10:52 AM
> To: dev@dpdk.org
> Cc: Dai, Wei <wei.dai@intel.com>
> Subject: [dpdk-dev] [PATCH v2 1/2] eal: remove redundant codes to parse --lcores
>
> local variable i is not referred by other codes in the function eal_parse_lcores( ), so it can be removed.
>
> Signed-off-by: Wei Dai <wei.dai@intel.com>
> ---
> lib/librte_eal/common/eal_common_options.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/lib/librte_eal/common/eal_common_options.c b/lib/librte_eal/common/eal_common_options.c
> index 481c732..c5bf98c 100644
> --- a/lib/librte_eal/common/eal_common_options.c
> +++ b/lib/librte_eal/common/eal_common_options.c
> @@ -578,7 +578,6 @@ eal_parse_lcores(const char *lcores)
> struct rte_config *cfg = rte_eal_get_configuration();
> static uint16_t set[RTE_MAX_LCORE];
> unsigned idx = 0;
> - int i;
> unsigned count = 0;
> const char *lcore_start = NULL;
> const char *end = NULL;
> @@ -593,9 +592,6 @@ eal_parse_lcores(const char *lcores)
> /* Remove all blank characters ahead and after */
> while (isblank(*lcores))
> lcores++;
> - i = strlen(lcores);
> - while ((i > 0) && isblank(lcores[i - 1]))
> - i--;
I suppose originally it meant to do something like that:
while ((i > 0) && isblank(lcores[i - 1]))
lcores[i--] = 0;
to get rid of blank characters at the end of the line, no?
Konstantin
>
> CPU_ZERO(&cpuset);
>
> --
> 2.5.5
next prev parent reply other threads:[~2016-07-26 11:52 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-21 6:03 [dpdk-dev] [PATCH] eal: fix parsing of argument of option --lcores Wei Dai
2016-07-21 14:21 ` Thomas Monjalon
2016-07-21 20:44 ` bynes adam
2016-07-27 10:06 ` Dai, Wei
2016-07-26 9:52 ` [dpdk-dev] [PATCH v2 1/2] eal: remove redundant codes to parse --lcores Wei Dai
2016-07-26 11:51 ` Ananyev, Konstantin [this message]
2016-07-26 17:36 ` Adam Bynes
2016-07-27 9:15 ` Dai, Wei
2016-07-27 11:22 ` [dpdk-dev] [PATCH v3 1/4] " Wei Dai
2016-07-28 15:18 ` Ferruh Yigit
2016-07-27 11:25 ` [dpdk-dev] [PATCH v3 3/4] eal: fix tail blank check in --lcores argument Wei Dai
2016-07-28 15:18 ` Ferruh Yigit
2016-07-26 9:52 ` [dpdk-dev] [PATCH v2 2/2] eal: fix parsing of eal option --lcores Wei Dai
2016-07-27 11:23 ` [dpdk-dev] [PATCH v3 2/4] " Wei Dai
2016-07-28 15:18 ` Ferruh Yigit
2016-07-27 11:27 ` [dpdk-dev] [PATCH v3 4/4] eal: fix end character check in --lcores argument Wei Dai
2016-07-28 15:26 ` Ferruh Yigit
2016-07-28 16:05 ` Thomas Monjalon
2016-08-02 8:22 ` Dai, Wei
2016-08-02 10:45 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2601191342CEEE43887BDE71AB97725836B820CA@irsmsx105.ger.corp.intel.com \
--to=konstantin.ananyev@intel.com \
--cc=dev@dpdk.org \
--cc=wei.dai@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).