From: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
To: "Zhang, Qi Z" <qi.z.zhang@intel.com>,
"Wu, Jingjing" <jingjing.wu@intel.com>,
"Zhang, Helin" <helin.zhang@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "Zhang, Qi Z" <qi.z.zhang@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2 0/3] net: fix out of order Rx read issue
Date: Tue, 18 Oct 2016 11:33:43 +0000 [thread overview]
Message-ID: <2601191342CEEE43887BDE71AB9772583F0C2B37@irsmsx105.ger.corp.intel.com> (raw)
In-Reply-To: <1476728982-39985-1-git-send-email-qi.z.zhang@intel.com>
>
> In vPMD, when load Rx desc with _mm_loadu_si128,
> volatile point will be cast into non-volatile point.
> So GCC is allowed to reorder the load instructions,
> while Rx read's correctness is reply on these load
> instructions to follow a backward sequence strictly,
> so we add compile barrier to prevent compiler reorder.
> We already met this issue on i40e with GCC6 and we
> fixed this on ixgbe and fm10k also.
>
> v2:
> - fix check-git-log.sh warning.
> - add more detail commit message.
>
> Qi Zhang (3):
> net/i40e: fix out of order Rx read issue
> net/ixgbe: fix out of order Rx read issue
> net/fm10k: fix out of ofder Rx read issue
>
> drivers/net/fm10k/fm10k_rxtx_vec.c | 3 +++
> drivers/net/i40e/i40e_rxtx_vec.c | 3 +++
> drivers/net/ixgbe/ixgbe_rxtx_vec_sse.c | 3 +++
> 3 files changed, 9 insertions(+)
>
> --
Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
> 2.7.4
next prev parent reply other threads:[~2016-10-18 11:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-17 18:29 Qi Zhang
2016-10-17 18:29 ` [dpdk-dev] [PATCH v2 1/3] net/i40e: " Qi Zhang
2016-10-17 18:29 ` [dpdk-dev] [PATCH v2 2/3] net/ixgbe: " Qi Zhang
2016-10-17 18:29 ` [dpdk-dev] [PATCH v2 3/3] net/fm10k: fix out of ofder " Qi Zhang
2016-10-18 11:33 ` Ananyev, Konstantin [this message]
2016-10-19 9:52 ` [dpdk-dev] [PATCH v2 0/3] net: fix out of order " Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2601191342CEEE43887BDE71AB9772583F0C2B37@irsmsx105.ger.corp.intel.com \
--to=konstantin.ananyev@intel.com \
--cc=dev@dpdk.org \
--cc=helin.zhang@intel.com \
--cc=jingjing.wu@intel.com \
--cc=qi.z.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).