From: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
To: "Wu, Yanglong" <yanglong.wu@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Wu, Yanglong" <yanglong.wu@intel.com>
Subject: Re: [dpdk-dev] [PATCH 2/2] net/ixgbe: fix l3fwd start failed on PF
Date: Thu, 2 Nov 2017 14:05:47 +0000 [thread overview]
Message-ID: <2601191342CEEE43887BDE71AB9772585FAB87A3@irsmsx105.ger.corp.intel.com> (raw)
In-Reply-To: <20171102170432.168194-2-yanglong.wu@intel.com>
Hi,
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Yanglong Wu
> Sent: Thursday, November 2, 2017 5:05 PM
> To: dev@dpdk.org
> Cc: Wu, Yanglong <yanglong.wu@intel.com>
> Subject: [dpdk-dev] [PATCH 2/2] net/ixgbe: fix l3fwd start failed on PF
>
> which occurred when the SRIOV is active and tx_q > rx_q.
> The number of nb_q_per_pool should equeal to max number
> of queues supported by HW not nb_rx_q.
>
> Fixes: 27b609cbd1c6 (ethdev: move the multi-queue mode
> check to specific drivers)
>
> Signed-off-by: Yanglong Wu <yanglong.wu@intel.com>
> ---
> drivers/net/ixgbe/ixgbe_ethdev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
> index ae9c44421..0f0641da1 100644
> --- a/drivers/net/ixgbe/ixgbe_ethdev.c
> +++ b/drivers/net/ixgbe/ixgbe_ethdev.c
> @@ -2180,7 +2180,7 @@ ixgbe_check_vf_rss_rxq_num(struct rte_eth_dev *dev, uint16_t nb_rx_q)
> return -EINVAL;
> }
>
> - RTE_ETH_DEV_SRIOV(dev).nb_q_per_pool = nb_rx_q;
> + RTE_ETH_DEV_SRIOV(dev).nb_q_per_pool = 128/RTE_ETH_DEV_SRIOV(dev).active;
> RTE_ETH_DEV_SRIOV(dev).def_pool_q_idx = pci_dev->max_vfs * nb_rx_q;
>
> return 0;
> --
> 2.11.0
Not sure I understand what is the purpose of that patch...
Do you want to prevent RTE_ETH_DEV_SRIOV(dev).nb_q_per_pool = 1?
Konstantin
next prev parent reply other threads:[~2017-11-02 14:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-02 17:04 [dpdk-dev] [PATCH 1/2] net/ixgbe: fix l3fwd start failed on VF Yanglong Wu
2017-11-02 17:04 ` [dpdk-dev] [PATCH 2/2] net/ixgbe: fix l3fwd start failed on PF Yanglong Wu
2017-11-02 14:05 ` Ananyev, Konstantin [this message]
2017-11-07 8:39 ` Wu, Jingjing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2601191342CEEE43887BDE71AB9772585FAB87A3@irsmsx105.ger.corp.intel.com \
--to=konstantin.ananyev@intel.com \
--cc=dev@dpdk.org \
--cc=yanglong.wu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).