From: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
To: Jianbo Liu <jianbo.liu@arm.com>
Cc: Jia He <hejianet@gmail.com>,
"Richardson, Bruce" <bruce.richardson@intel.com>,
"jerin.jacob@caviumnetworks.com" <jerin.jacob@caviumnetworks.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"olivier.matz@6wind.com" <olivier.matz@6wind.com>,
"hemant.agrawal@nxp.com" <hemant.agrawal@nxp.com>,
"jia.he@hxt-semitech.com" <jia.he@hxt-semitech.com>
Subject: Re: [dpdk-dev] [PATCH 1/3] eal/arm64: remove the braces {} for dmb(), dsb()
Date: Thu, 9 Nov 2017 10:08:40 +0000 [thread overview]
Message-ID: <2601191342CEEE43887BDE71AB9772585FABB388@irsmsx105.ger.corp.intel.com> (raw)
In-Reply-To: <20171109095813.GB27104@arm.com>
> -----Original Message-----
> From: Jianbo Liu [mailto:jianbo.liu@arm.com]
> Sent: Thursday, November 9, 2017 9:58 AM
> To: Ananyev, Konstantin <konstantin.ananyev@intel.com>
> Cc: Jia He <hejianet@gmail.com>; Richardson, Bruce <bruce.richardson@intel.com>; jerin.jacob@caviumnetworks.com; dev@dpdk.org;
> olivier.matz@6wind.com; hemant.agrawal@nxp.com; jia.he@hxt-semitech.com
> Subject: Re: [PATCH 1/3] eal/arm64: remove the braces {} for dmb(),dsb()
>
> The 11/09/2017 09:38, Ananyev, Konstantin wrote:
> >
> >
> > > -----Original Message-----
> > > From: Jianbo Liu [mailto:jianbo.liu@arm.com]
> > > Sent: Thursday, November 9, 2017 4:56 AM
> > > To: Jia He <hejianet@gmail.com>
> > > Cc: Richardson, Bruce <bruce.richardson@intel.com>; jerin.jacob@caviumnetworks.com; dev@dpdk.org; olivier.matz@6wind.com;
> > > Ananyev, Konstantin <konstantin.ananyev@intel.com>; hemant.agrawal@nxp.com; jia.he@hxt-semitech.com
> > > Subject: Re: [PATCH 1/3] eal/arm64: remove the braces {} for dmb(),dsb()
> > >
> > > The 11/09/2017 12:43, Jia He wrote:
> > > > Hi Jianbo
> > > >
> > > >
> > > > On 11/9/2017 11:21 AM, Jianbo Liu Wrote:
> > > > >The 11/09/2017 11:14, Jia He wrote:
> > > > >>
> > > > >>On 11/9/2017 9:22 AM, Jia He Wrote:
> > > > >>>Hi Bruce
> > > > >>>
> > > > >>>
> > > > >>>On 11/8/2017 6:28 PM, Bruce Richardson Wrote:
> > > > >>>>On Wed, Nov 08, 2017 at 06:17:10AM +0000, Jia He wrote:
> > > > >>>>>for the code as follows:
> > > > >>>>>if (condition)
> > > > >>>>> rte_smp_rmb();
> > > > >>>>>else
> > > > >>>>> rte_smp_wmb();
> > > > >>>>>Without this patch, compiler will report this error:
> > > > >>>>>error: 'else' without a previous 'if'
> > > > >>>>>
> > > > >>>>>Signed-off-by: Jia He <hejianet@gmail.com>
> > > > >>>>>Signed-off-by: jia.he@hxt-semitech.com
> > > > >>>>>---
> > > > >>>>> lib/librte_eal/common/include/arch/arm/rte_atomic_64.h | 4 ++--
> > > > >>>>> 1 file changed, 2 insertions(+), 2 deletions(-)
> > > > >>>>>
> > > > >>>>>diff --git
> > > > >>>>>a/lib/librte_eal/common/include/arch/arm/rte_atomic_64.h
> > > > >>>>>b/lib/librte_eal/common/include/arch/arm/rte_atomic_64.h
> > > > >>>>>index 0b70d62..38c3393 100644
> > > > >>>>>--- a/lib/librte_eal/common/include/arch/arm/rte_atomic_64.h
> > > > >>>>>+++ b/lib/librte_eal/common/include/arch/arm/rte_atomic_64.h
> > > > >>>>>@@ -43,8 +43,8 @@ extern "C" {
> > > > >>>>> #include "generic/rte_atomic.h"
> > > > >>>>> -#define dsb(opt) { asm volatile("dsb " #opt : : : "memory"); }
> > > > >>>>>-#define dmb(opt) { asm volatile("dmb " #opt : : : "memory"); }
> > > > >>>>>+#define dsb(opt) asm volatile("dsb " #opt : : : "memory");
> > > > >>>>>+#define dmb(opt) asm volatile("dmb " #opt : : : "memory");
> > > > >>>>Need to remove the trailing ";" I too I think.
> > > > >>>>Alternatively, to keep the braces, the standard practice is to use
> > > > >>>>do { ... } while(0)
> > > > >>>If trailing ";" is not removed
> > > > >>>the code:
> > > > >>>if (condition)
> > > > >>> rte_smp_rmb();
> > > > >>>else
> > > > >>> anything();
> > > > >>>
> > > > >Sorry, why not use two different functions as your conditions passed in
> > > > >are fixed in the calling functions.
> > > > Do you mean to split update_tail() into update_tail_enqueue() and
> > > > update_tail_dequeue()?
> > >
> > > Yes. So it's not need to change dsb/dmb.
> >
> > That's a good idea - but you still might hit the same problem in
> > Some different place in future...
>
> I think there is no any issue if we add {} for if/else sections.
>
> - if (enqueue)
> + if (enqueue) {
> rte_smp_wmb();
> - else
> + } else {
> rte_smp_rmb();
> + }
>
> It's not a good way to ommit {}.
That's the preferred DPDK coding style these days :)
http://dpdk.org/doc/guides-16.04/contributing/coding_style.html
1.6.2. Control Statements and Loops
Include a space after keywords (if, while, for, return, switch).
Do not use braces ({ and }) for control statements with zero or just a single statement, unless that statement is more than a single line in which case the braces are permitted.
Konstantin
>
> Jianbo
>
> > Why not to convert these macros into 'always_inline' functions then?
> > Konstantin
> >
> > >
> > > Jianbo
> > > IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the
> > > intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or
> > > store or copy the information in any medium. Thank you.
>
> --
> IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the
> intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or
> store or copy the information in any medium. Thank you.
next prev parent reply other threads:[~2017-11-09 10:08 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-08 6:17 Jia He
2017-11-08 6:17 ` [dpdk-dev] [PATCH 2/3] ring: guarantee load ordering of cons/prod when doing enqueue/dequeue Jia He
2017-11-08 7:27 ` Jerin Jacob
2017-11-08 9:49 ` Ananyev, Konstantin
2017-11-08 6:17 ` [dpdk-dev] [PATCH 3/3] config: support C11 memory model for arm64 Jia He
2017-11-08 7:17 ` [dpdk-dev] [PATCH 1/3] eal/arm64: remove the braces {} for dmb(), dsb() Jerin Jacob
2017-11-08 10:28 ` Bruce Richardson
2017-11-09 1:22 ` Jia He
2017-11-09 3:14 ` Jia He
2017-11-09 3:21 ` Jianbo Liu
2017-11-09 4:43 ` Jia He
2017-11-09 4:56 ` Jianbo Liu
2017-11-09 9:38 ` Ananyev, Konstantin
2017-11-09 9:58 ` Jianbo Liu
2017-11-09 10:08 ` Ananyev, Konstantin [this message]
2017-11-10 2:06 ` Jia He
2017-11-10 3:09 ` Jianbo Liu
2017-11-10 10:06 ` Ananyev, Konstantin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2601191342CEEE43887BDE71AB9772585FABB388@irsmsx105.ger.corp.intel.com \
--to=konstantin.ananyev@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=hejianet@gmail.com \
--cc=hemant.agrawal@nxp.com \
--cc=jerin.jacob@caviumnetworks.com \
--cc=jia.he@hxt-semitech.com \
--cc=jianbo.liu@arm.com \
--cc=olivier.matz@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).