From: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
To: "Wu, Yanglong" <yanglong.wu@intel.com>,
"Lu, Wenzhuo" <wenzhuo.lu@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v5] net/ixgbe: fix l3fwd start failed on
Date: Tue, 9 Jan 2018 12:39:44 +0000 [thread overview]
Message-ID: <2601191342CEEE43887BDE71AB97725880E3A7A7@irsmsx105.ger.corp.intel.com> (raw)
In-Reply-To: <B73B41DFFD120A45AEE57672FCA463BA0195B346@shsmsx102.ccr.corp.intel.com>
Hi Yanglong,
Sorry, I was just confused by the description of the patch.
The code itself seems ok... probably need to rephrase the description
(remove mentioning l3fwd?).
Konstantin
> Hi, Konstantin
>
> Thanks for your comments!
> Do you means that tx_q is must less than rx_q when the SRIOV is active and if not, the application case will not be supported?
> Do you think my patch will cause to 2 (or more cores) could try to TX packets through the same TX queue? And as far as I know, the way of
> core using tx_q queue is depend on the application (e.g. in l3fwd tx_q equal to number of core) and multi core use same tx_q is not
> suggested for locker is needed in this situation. So why do you think my patch will lead to multi core using same queue?
>
> Yanglong Wu
>
>
> -----Original Message-----
> From: Ananyev, Konstantin
> Sent: Monday, January 8, 2018 7:55 PM
> To: Wu, Yanglong <yanglong.wu@intel.com>; dev@dpdk.org
> Subject: RE: [PATCH v5] net/ixgbe: fix l3fwd start failed on
>
>
>
> > -----Original Message-----
> > From: Wu, Yanglong
> > Sent: Monday, January 8, 2018 3:06 AM
> > To: dev@dpdk.org
> > Cc: Ananyev, Konstantin <konstantin.ananyev@intel.com>; Wu, Yanglong
> > <yanglong.wu@intel.com>
> > Subject: [PATCH v5] net/ixgbe: fix l3fwd start failed on
> >
> > L3fwd start failed on PF, for tx_q check failed.
> > That occurred when the SRIOV is active and tx_q > rx_q.
> > The tx_q is equal to nb_q_per_pool. The number of nb_q_per_pool should
> > equeal to max number of queues supported by HW not nb_rx_q.
>
> But then 2 (or more cores) could try to TX packets through the same TX queue?
> Why not just fil to start gracefully (call rte_exit() or so) if such situation occurred?
> Konstantin
>
> >
> > Fixes: 27b609cbd1c6 (ethdev: move the multi-queue mode check to
> > specific drivers)
> >
> > Signed-off-by: Yanglong Wu <yanglong.wu@intel.com>
> > ---
> > v5:
> > Rework according to comments
> > ---
> > drivers/net/ixgbe/ixgbe_ethdev.c | 10 +++++++---
> > 1 file changed, 7 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c
> > b/drivers/net/ixgbe/ixgbe_ethdev.c
> > index ff19a564a..baaeee5d9 100644
> > --- a/drivers/net/ixgbe/ixgbe_ethdev.c
> > +++ b/drivers/net/ixgbe/ixgbe_ethdev.c
> > @@ -95,6 +95,9 @@
> > /* Timer value included in XOFF frames. */ #define IXGBE_FC_PAUSE
> > 0x680
> >
> > +/*Default value of Max Rx Queue*/
> > +#define IXGBE_MAX_RX_QUEUE_NUM 128
> > +
> > #define IXGBE_LINK_DOWN_CHECK_TIMEOUT 4000 /* ms */
> > #define IXGBE_LINK_UP_CHECK_TIMEOUT 1000 /* ms */
> > #define IXGBE_VMDQ_NUM_UC_MAC 4096 /* Maximum nb. of UC MAC addr. */
> > @@ -2194,9 +2197,10 @@ ixgbe_check_vf_rss_rxq_num(struct rte_eth_dev *dev, uint16_t nb_rx_q)
> > return -EINVAL;
> > }
> >
> > - RTE_ETH_DEV_SRIOV(dev).nb_q_per_pool = nb_rx_q;
> > - RTE_ETH_DEV_SRIOV(dev).def_pool_q_idx = pci_dev->max_vfs * nb_rx_q;
> > -
> > + RTE_ETH_DEV_SRIOV(dev).nb_q_per_pool =
> > + IXGBE_MAX_RX_QUEUE_NUM / RTE_ETH_DEV_SRIOV(dev).active;
> > + RTE_ETH_DEV_SRIOV(dev).def_pool_q_idx =
> > + pci_dev->max_vfs * RTE_ETH_DEV_SRIOV(dev).nb_q_per_pool;
> > return 0;
> > }
> >
> > --
> > 2.11.0
next prev parent reply other threads:[~2018-01-09 12:39 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20171102161031.167892-2-yanglong.wu@intel.com>
2017-11-20 1:53 ` [dpdk-dev] [PATCH v2] net/ixgbe: fix l3fwd start failed on PF Yanglong Wu
2017-11-20 2:29 ` [dpdk-dev] [PATCH v3] " Yanglong Wu
2017-11-20 2:40 ` [dpdk-dev] [PATCH v4] " Yanglong Wu
2017-11-20 10:43 ` Ananyev, Konstantin
2017-11-21 2:17 ` Wu, Yanglong
2018-01-07 15:34 ` Zhang, Helin
2018-01-08 3:06 ` [dpdk-dev] [PATCH v5] net/ixgbe: fix l3fwd start failed on Yanglong Wu
2018-01-08 11:54 ` Ananyev, Konstantin
2018-01-09 2:29 ` Wu, Yanglong
2018-01-09 12:39 ` Ananyev, Konstantin [this message]
2018-01-10 1:51 ` [dpdk-dev] [PATCH v6] net/ixgbe: fix tx_q check failed on PF Yanglong Wu
2018-01-10 1:57 ` Ananyev, Konstantin
2018-01-10 2:23 ` Zhang, Helin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2601191342CEEE43887BDE71AB97725880E3A7A7@irsmsx105.ger.corp.intel.com \
--to=konstantin.ananyev@intel.com \
--cc=dev@dpdk.org \
--cc=wenzhuo.lu@intel.com \
--cc=yanglong.wu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).