From: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
To: "Awal, Mohammad Abdul" <mohammad.abdul.awal@intel.com>,
"thomas@monjalon.net" <thomas@monjalon.net>
Cc: "rkerur@gmail.com" <rkerur@gmail.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] ether: fix invalid string length in ethdev name comparison
Date: Tue, 27 Feb 2018 09:38:48 +0000 [thread overview]
Message-ID: <2601191342CEEE43887BDE71AB977258905783AF@irsmsx105.ger.corp.intel.com> (raw)
In-Reply-To: <1519721907-25198-1-git-send-email-mohammad.abdul.awal@intel.com>
> -----Original Message-----
> From: Awal, Mohammad Abdul
> Sent: Tuesday, February 27, 2018 8:58 AM
> To: thomas@monjalon.net
> Cc: rkerur@gmail.com; dev@dpdk.org; Ananyev, Konstantin <konstantin.ananyev@intel.com>; Awal, Mohammad Abdul
> <mohammad.abdul.awal@intel.com>
> Subject: [PATCH v2] ether: fix invalid string length in ethdev name comparison
>
> The current code compares two strings upto the length of 1st string
> (searched name). If the 1st string is prefix of 2nd string (existing name),
> the string comparison returns the port_id of earliest prefix matches.
> This patch fixes the bug by using strcmp instead of strncmp.
>
> Fixes: 9c5b8d8b9fe ("ethdev: clean port id retrieval when attaching")
>
> Signed-off-by: Mohammad Abdul Awal <mohammad.abdul.awal@intel.com>
> ---
> lib/librte_ether/rte_ethdev.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c
> index 0590f0c..3b885a6 100644
> --- a/lib/librte_ether/rte_ethdev.c
> +++ b/lib/librte_ether/rte_ethdev.c
> @@ -572,8 +572,7 @@ rte_eth_dev_get_port_by_name(const char *name, uint16_t *port_id)
>
> for (pid = 0; pid < RTE_MAX_ETHPORTS; pid++) {
> if (rte_eth_devices[pid].state != RTE_ETH_DEV_UNUSED &&
> - !strncmp(name, rte_eth_dev_shared_data->data[pid].name,
> - strlen(name))) {
> + !strcmp(name, rte_eth_dev_shared_data->data[pid].name)) {
> *port_id = pid;
> return 0;
> }
> --
Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
> 2.7.4
next prev parent reply other threads:[~2018-02-27 9:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-27 8:58 Mohammad Abdul Awal
2018-02-27 9:38 ` Ananyev, Konstantin [this message]
2018-03-07 15:25 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2601191342CEEE43887BDE71AB977258905783AF@irsmsx105.ger.corp.intel.com \
--to=konstantin.ananyev@intel.com \
--cc=dev@dpdk.org \
--cc=mohammad.abdul.awal@intel.com \
--cc=rkerur@gmail.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).