From: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
To: "Doherty, Declan" <declan.doherty@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "Doherty, Declan" <declan.doherty@intel.com>
Subject: Re: [dpdk-dev] [PATCH 3/3] net/ixgbe: add null pointer check for pf_ethdev
Date: Tue, 1 May 2018 09:47:48 +0000 [thread overview]
Message-ID: <2601191342CEEE43887BDE71AB977258AEDC0C74@irsmsx105.ger.corp.intel.com> (raw)
In-Reply-To: <20180430153258.1101-3-declan.doherty@intel.com>
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Declan Doherty
> Sent: Monday, April 30, 2018 4:33 PM
> To: dev@dpdk.org
> Cc: Doherty, Declan <declan.doherty@intel.com>
> Subject: [dpdk-dev] [PATCH 3/3] net/ixgbe: add null pointer check for pf_ethdev
>
> Add NULL parameter check for rte_eth_dev_allocated() API call to
> eth_ixgbe_pci_probe().
>
> Coverity Issue: 277216
> Fixes: cf80ba6e2038 ("net/ixgbe: add support for representor ports")
>
> Signed-off-by: Declan Doherty <declan.doherty@intel.com>
> ---
> drivers/net/ixgbe/ixgbe_ethdev.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
> index 283dd7e49..75f927c06 100644
> --- a/drivers/net/ixgbe/ixgbe_ethdev.c
> +++ b/drivers/net/ixgbe/ixgbe_ethdev.c
> @@ -1747,6 +1747,9 @@ eth_ixgbe_pci_probe(struct rte_pci_driver *pci_drv __rte_unused,
> struct rte_eth_dev *pf_ethdev = rte_eth_dev_allocated(
> pci_dev->device.name);
>
> + if (pf_ethdev == NULL)
> + return -ENODEV;
> +
> for (i = 0; i < eth_da.nb_representor_ports; i++) {
> struct ixgbe_vf_info *vfinfo;
> struct ixgbe_vf_representor representor;
> --
Looks good - can I just ask to move pf_ethdev definition to the top of the function?
To comply with dpdk coding style.
Konstantin
> 2.14.3
next prev parent reply other threads:[~2018-05-01 9:47 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-30 15:32 [dpdk-dev] [PATCH 1/3] net/ixgbe: revert default PF PMD device name Declan Doherty
2018-04-30 15:32 ` [dpdk-dev] [PATCH 2/3] net/ixgbe: initialise nb_representor_ports value Declan Doherty
2018-05-01 9:46 ` Ananyev, Konstantin
2018-05-01 12:53 ` Doherty, Declan
2018-04-30 15:32 ` [dpdk-dev] [PATCH 3/3] net/ixgbe: add null pointer check for pf_ethdev Declan Doherty
2018-05-01 9:47 ` Ananyev, Konstantin [this message]
2018-05-01 12:53 ` Doherty, Declan
2018-05-02 15:59 ` [dpdk-dev] [dpdk-dev 1/3][PATCH v2] net/ixgbe: revert default PF PMD device name Declan Doherty
2018-05-02 15:59 ` [dpdk-dev] [dpdk-dev 2/3][PATCH v2] net/ixgbe: default eth_da parameter Declan Doherty
2018-05-02 15:59 ` [dpdk-dev] [dpdk-dev 3/3][PATCH v2] net/ixgbe: add null pointer check for pf_ethdev Declan Doherty
2018-05-02 16:48 ` [dpdk-dev] [dpdk-dev 1/3][PATCH v2] net/ixgbe: revert default PF PMD device name Ferruh Yigit
2018-05-02 17:05 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2601191342CEEE43887BDE71AB977258AEDC0C74@irsmsx105.ger.corp.intel.com \
--to=konstantin.ananyev@intel.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).