From: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
To: "Richardson, Bruce" <bruce.richardson@intel.com>
Cc: "Xing, Beilei" <beilei.xing@intel.com>,
"Zhang, Qi Z" <qi.z.zhang@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"Yigit, Ferruh" <ferruh.yigit@intel.com>
Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix Tx fn selection when using new ethdev offloads
Date: Tue, 1 May 2018 14:11:16 +0000 [thread overview]
Message-ID: <2601191342CEEE43887BDE71AB977258AEDC0E2D@irsmsx105.ger.corp.intel.com> (raw)
In-Reply-To: <20180501135249.GB79992@bricha3-MOBL.ger.corp.intel.com>
> -----Original Message-----
> From: Richardson, Bruce
> Sent: Tuesday, May 1, 2018 2:53 PM
> To: Ananyev, Konstantin <konstantin.ananyev@intel.com>
> Cc: Xing, Beilei <beilei.xing@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>; dev@dpdk.org; Yigit, Ferruh <ferruh.yigit@intel.com>
> Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix Tx fn selection when using new ethdev offloads
>
> On Tue, May 01, 2018 at 02:24:39PM +0100, Ananyev, Konstantin wrote:
> > Hi Bruce,
> >
> > >
> > > The Tx function selection code in the driver only used the older txq
> > > flags values to check whether the scalar or vector functions should be
> > > used. This caused performance regressions with testpmd io-fwd as the
> > > scalar path rather than the vector one was being used in the default
> > > case. Fix this by changing the code to take account of new offloads and
> > > deleting the defines used for the old ones.
> > >
> > > Fixes: 7497d3e2f777 ("net/i40e: convert to new Tx offloads API")
> > >
> > > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> > > ---
> > > drivers/net/i40e/i40e_rxtx.c | 45 +++++++++++++++++++++++---------------------
> > > 1 file changed, 24 insertions(+), 21 deletions(-)
> > >
> > > diff --git a/drivers/net/i40e/i40e_rxtx.c b/drivers/net/i40e/i40e_rxtx.c
> > > index ec1ce54ca..c523af575 100644
> > > --- a/drivers/net/i40e/i40e_rxtx.c
> > > +++ b/drivers/net/i40e/i40e_rxtx.c
> > > @@ -40,9 +40,6 @@
> > > /* Base address of the HW descriptor ring should be 128B aligned. */
> > > #define I40E_RING_BASE_ALIGN 128
> > >
> > > -#define I40E_SIMPLE_FLAGS ((uint32_t)ETH_TXQ_FLAGS_NOMULTSEGS | \
> > > - ETH_TXQ_FLAGS_NOOFFLOADS)
> > > -
> > > #define I40E_TXD_CMD (I40E_TX_DESC_CMD_EOP | I40E_TX_DESC_CMD_RS)
> > >
> > > #ifdef RTE_LIBRTE_IEEE1588
> > > @@ -70,6 +67,12 @@
> > > #define I40E_TX_OFFLOAD_NOTSUP_MASK \
> > > (PKT_TX_OFFLOAD_MASK ^ I40E_TX_OFFLOAD_MASK)
> > >
> > > +static const uint64_t i40e_simple_ol_mask = (DEV_TX_OFFLOAD_MULTI_SEGS |
> > > + DEV_TX_OFFLOAD_VLAN_INSERT |
> > > + DEV_TX_OFFLOAD_SCTP_CKSUM |
> > > + DEV_TX_OFFLOAD_UDP_CKSUM |
> > > + DEV_TX_OFFLOAD_TCP_CKSUM);
> > > +
> >
> > Seems incomplete.
> > From i40e_ethdev.c full-featured tx supports:
> > dev_info->tx_offload_capa =
> > DEV_TX_OFFLOAD_VLAN_INSERT |
> > DEV_TX_OFFLOAD_QINQ_INSERT |
> > DEV_TX_OFFLOAD_IPV4_CKSUM |
> > DEV_TX_OFFLOAD_UDP_CKSUM |
> > DEV_TX_OFFLOAD_TCP_CKSUM |
> > DEV_TX_OFFLOAD_SCTP_CKSUM |
> > DEV_TX_OFFLOAD_OUTER_IPV4_CKSUM |
> > DEV_TX_OFFLOAD_TCP_TSO |
> > DEV_TX_OFFLOAD_VXLAN_TNL_TSO |
> > DEV_TX_OFFLOAD_GRE_TNL_TSO |
> > DEV_TX_OFFLOAD_IPIP_TNL_TSO |
> > DEV_TX_OFFLOAD_GENEVE_TNL_TSO;
> >
> > So we probably need the same here plus multiseg.
> > BTW, it is really strange that we don't have multiseg in tx_offload_capa.
> > Should be present I think.
> > Might be worse to create a new define for it, or just use dev_info->tx_offload_capa directly.
> > Konstantin
> >
> Thinking about this more, it seems that right now we don't need a masks at
> all. Any bits set in the offloads is going to cause us to use the scalar
> path or to error out with an invalid offload requested. Yes, it's not
> future-proofed in that it will need to be changed if we do end up
> supporting some offloads with the vector path in future, but then the same
> problem would occur if we just re-use the advertised capabilities too, like
> you suggest.
>
> Therefore I think for V2 we'll just check for a non-zero offloads value.
Ok by me.
Konstantin
next prev parent reply other threads:[~2018-05-01 14:11 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-01 13:03 Bruce Richardson
2018-05-01 13:24 ` Ananyev, Konstantin
2018-05-01 13:28 ` Bruce Richardson
2018-05-01 13:52 ` Bruce Richardson
2018-05-01 14:11 ` Ananyev, Konstantin [this message]
2018-05-01 14:13 ` [dpdk-dev] [PATCH v2] " Bruce Richardson
2018-05-01 14:16 ` Bruce Richardson
2018-05-01 14:37 ` Ferruh Yigit
2018-05-01 15:48 ` Ferruh Yigit
2018-05-01 17:52 ` Ananyev, Konstantin
2018-05-02 8:24 ` Bruce Richardson
2018-05-02 8:30 ` Zhang, Qi Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2601191342CEEE43887BDE71AB977258AEDC0E2D@irsmsx105.ger.corp.intel.com \
--to=konstantin.ananyev@intel.com \
--cc=beilei.xing@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=qi.z.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).