From: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] bpf: add missed EXPERIMENTAL tags
Date: Mon, 14 May 2018 14:55:13 +0000 [thread overview]
Message-ID: <2601191342CEEE43887BDE71AB977258AEDC72E8@irsmsx105.ger.corp.intel.com> (raw)
In-Reply-To: <2420395.OS6qY2Y8eq@xps>
> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> Sent: Monday, May 14, 2018 3:31 PM
> To: Ananyev, Konstantin <konstantin.ananyev@intel.com>
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] bpf: add missed EXPERIMENTAL tags
>
> 14/05/2018 15:15, Konstantin Ananyev:
> > - add EXPERIMENTAL tag for the section in MAINTAINERS.
> > - add EXPERIMENTAL tag to BPF public API files.
> > - add attribute __rte_experimental to BPF public API declarations.
> >
> > Fixes: 94972f35a02e ("bpf: add BPF loading and execution framework")
> > Fixes: 5dba93ae5f2d ("bpf: add ability to load eBPF program from ELF")
> > Fixes: a93ff62a8938 ("bpf: add BPF loading and execution framework")
> >
> > Reported-by: Thomas Monjalon <thomas@monjalon.net>
> > Signed-off-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
> > ---
> > MAINTAINERS | 2 +-
> > lib/librte_bpf/rte_bpf.h | 26 ++++++++++++++++----------
> > lib/librte_bpf/rte_bpf_ethdev.h | 15 ++++++++++-----
> > 3 files changed, 27 insertions(+), 16 deletions(-)
>
> You need to add __rte_experimental in function definitions too (.c file).
I believe that was done in initial commit.
>
> There is a tool to check it: buildtools/check-experimental-syms.sh
>
./buildtools/check-experimental-syms.sh lib/librte_bpf/rte_bpf_version.map x86_64-native-linuxapp-gcc-meson/lib/librte_bpf.a
Don't produce any errors/warnings for me.
Do I miss something here?
Konstantin
next prev parent reply other threads:[~2018-05-14 14:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-14 1:33 [dpdk-dev] BPF in DPDK 18.05 as experimental Thomas Monjalon
2018-05-14 13:15 ` [dpdk-dev] [PATCH] bpf: add missed EXPERIMENTAL tags Konstantin Ananyev
2018-05-14 14:20 ` Ferruh Yigit
2018-05-14 14:24 ` Thomas Monjalon
2018-05-14 14:31 ` Thomas Monjalon
2018-05-14 14:55 ` Ananyev, Konstantin [this message]
2018-05-14 14:59 ` Thomas Monjalon
2018-05-14 15:37 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2601191342CEEE43887BDE71AB977258AEDC72E8@irsmsx105.ger.corp.intel.com \
--to=konstantin.ananyev@intel.com \
--cc=dev@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).