From: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
To: "Wu, Yanglong" <yanglong.wu@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Zhang, Qi Z" <qi.z.zhang@intel.com>,
"Bie, Tiwei" <tiwei.bie@intel.com>,
"Yao, Lei A" <lei.a.yao@intel.com>,
"Wu, Yanglong" <yanglong.wu@intel.com>
Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix max frame size checking
Date: Thu, 26 Jul 2018 09:16:37 +0000 [thread overview]
Message-ID: <2601191342CEEE43887BDE71AB977258DF51E2AE@irsmsx105.ger.corp.intel.com> (raw)
In-Reply-To: <20180726064602.157850-1-yanglong.wu@intel.com>
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Yanglong Wu
> Sent: Thursday, July 26, 2018 7:46 AM
> To: dev@dpdk.org
> Cc: Zhang, Qi Z <qi.z.zhang@intel.com>; Bie, Tiwei <tiwei.bie@intel.com>; Yao, Lei A <lei.a.yao@intel.com>; Wu, Yanglong
> <yanglong.wu@intel.com>
> Subject: [dpdk-dev] [PATCH] net/i40e: fix max frame size checking
>
> No need to check max frame size in TX, the checking
> should be done in up layer protocal. This checking will
> lead to fail for TSO or other application cases.
Not sure why is that?
i40e doesn't support single packet bigger then 9.5KB (or so), as I remember.
For TSO the limit is 256KB - yes, it is bibber, but still there is a limit.
Might be we need to change that check, but I think we still need to keep it.
Konstantin
>
> Fixes: bfeed0262b0c ("net/i40e: check illegal packets")
>
> Signed-off-by: Yanglong Wu <yanglong.wu@intel.com>
> ---
> drivers/net/i40e/i40e_rxtx.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/net/i40e/i40e_rxtx.c b/drivers/net/i40e/i40e_rxtx.c
> index 3be87fe6a..baad433a7 100644
> --- a/drivers/net/i40e/i40e_rxtx.c
> +++ b/drivers/net/i40e/i40e_rxtx.c
> @@ -1459,8 +1459,7 @@ i40e_prep_pkts(__rte_unused void *tx_queue, struct rte_mbuf **tx_pkts,
> }
>
> /* check the size of packet */
> - if (m->pkt_len > I40E_FRAME_SIZE_MAX ||
> - m->pkt_len < I40E_TX_MIN_PKT_LEN) {
> + if (m->pkt_len < I40E_TX_MIN_PKT_LEN) {
> rte_errno = -EINVAL;
> return i;
> }
> --
> 2.11.0
next prev parent reply other threads:[~2018-07-26 9:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-26 6:46 Yanglong Wu
2018-07-26 9:16 ` Ananyev, Konstantin [this message]
2018-07-26 12:13 ` Zhang, Qi Z
2018-07-26 12:25 ` Zhang, Qi Z
2018-07-26 12:33 ` Ananyev, Konstantin
2018-07-26 12:47 ` Zhang, Qi Z
2018-07-26 12:56 ` Ananyev, Konstantin
2018-07-27 4:40 ` [dpdk-dev] [PATCH v2] " Yanglong Wu
2018-07-27 8:13 ` Ananyev, Konstantin
2018-07-30 1:05 ` Zhang, Qi Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2601191342CEEE43887BDE71AB977258DF51E2AE@irsmsx105.ger.corp.intel.com \
--to=konstantin.ananyev@intel.com \
--cc=dev@dpdk.org \
--cc=lei.a.yao@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=tiwei.bie@intel.com \
--cc=yanglong.wu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).