From: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
To: "Pattan, Reshma" <reshma.pattan@intel.com>,
"longtb5@viettel.com.vn" <longtb5@viettel.com.vn>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] latencystats: fix timestamp marking and latency calculation
Date: Tue, 25 Sep 2018 14:30:50 +0000 [thread overview]
Message-ID: <2601191342CEEE43887BDE71AB977258EA95B151@irsmsx105.ger.corp.intel.com> (raw)
In-Reply-To: <1537878252-21061-1-git-send-email-reshma.pattan@intel.com>
Hi Reshma,
>
>
> Latency calculation logic is not correct for the case where
> packets gets dropped before TX. As for the dropped packets,
> the timestamp is not cleared, and such packets still gets
> counted for latency calculation in next runs, that will result
> in inaccurate latency measurement.
>
> So fix this issue as below,
>
> Before setting timestamp in mbuf, check mbuf don't have
> any prior valid time stamp flag set and after marking
> the timestamp, set mbuf flags to indicate timestamp is
> valid.
>
> Before calculating timestamp check mbuf flags are set to
> indicate timestamp is valid.
>
> With the above logic it is guaranteed that correct timestamps
> have been used.
>
> Fixes: 5cd3cac9ed ("latency: added new library for latency stats")
>
> Reported-by: Bao-Long Tran <longtb5@viettel.com.vn>
> Signed-off-by: Reshma Pattan <reshma.pattan@intel.com>
> Tested-by: Bao-Long Tran <longtb5@viettel.com.vn>
>
> ---
> v2: remove check for mbuf->timestamp
> ---
> lib/librte_latencystats/rte_latencystats.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/lib/librte_latencystats/rte_latencystats.c b/lib/librte_latencystats/rte_latencystats.c
> index 1fdec68e3..0f702b722 100644
> --- a/lib/librte_latencystats/rte_latencystats.c
> +++ b/lib/librte_latencystats/rte_latencystats.c
> @@ -125,8 +125,11 @@ add_time_stamps(uint16_t pid __rte_unused,
> for (i = 0; i < nb_pkts; i++) {
> diff_tsc = now - prev_tsc;
> timer_tsc += diff_tsc;
> - if (timer_tsc >= samp_intvl) {
> +
> + if ((pkts[i]->ol_flags & PKT_RX_TIMESTAMP) == 0
> + && (timer_tsc >= samp_intvl)) {
As a nit - I think you need extra tab here, to follow dpdk codying style.
Apart from that:
Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
> pkts[i]->timestamp = now;
> + pkts[i]->ol_flags |= PKT_RX_TIMESTAMP;
> timer_tsc = 0;
> }
> prev_tsc = now;
> @@ -156,7 +159,7 @@ calc_latency(uint16_t pid __rte_unused,
>
> now = rte_rdtsc();
> for (i = 0; i < nb_pkts; i++) {
> - if (pkts[i]->timestamp)
> + if (pkts[i]->ol_flags & PKT_RX_TIMESTAMP)
> latency[cnt++] = now - pkts[i]->timestamp;
> }
>
> --
> 2.14.4
next prev parent reply other threads:[~2018-09-25 14:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-21 16:01 [dpdk-dev] [PATCH] " Reshma Pattan
2018-09-22 2:58 ` longtb5
2018-09-24 13:07 ` Pattan, Reshma
2018-09-25 15:22 ` longtb5
2018-09-24 7:10 ` longtb5
2018-09-25 12:24 ` [dpdk-dev] [PATCH v2] " Reshma Pattan
2018-09-25 14:30 ` Ananyev, Konstantin [this message]
2018-09-25 14:51 ` [dpdk-dev] [PATCH v3] " Reshma Pattan
2018-10-25 8:31 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2601191342CEEE43887BDE71AB977258EA95B151@irsmsx105.ger.corp.intel.com \
--to=konstantin.ananyev@intel.com \
--cc=dev@dpdk.org \
--cc=longtb5@viettel.com.vn \
--cc=reshma.pattan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).