DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: Jerin Jacob <jerin.jacob@caviumnetworks.com>,
	Bruce Richardson <bruce.richardson@intel.com>,
	Harry van Haaren <harry.van.haaren@intel.com>,
	dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2 1/3] net/thunderx: disable pmd for older compilers
Date: Thu, 06 Apr 2017 15:59:09 +0200	[thread overview]
Message-ID: <2608561.Cu0AakAGmg@xps13> (raw)
In-Reply-To: <20170406134637.4484-1-ferruh.yigit@intel.com>

2017-04-06 14:46, Ferruh Yigit:
> --- a/mk/toolchain/gcc/rte.toolchain-compat.mk
> +++ b/mk/toolchain/gcc/rte.toolchain-compat.mk
> @@ -89,4 +89,8 @@ else
>  	ifeq ($(shell test $(GCC_VERSION) -lt 42 && echo 1), 1)
>  		MACHINE_CFLAGS := $(filter-out -march% -mtune% -msse%,$(MACHINE_CFLAGS))
>  	endif
> +
> +	ifeq ($(shell test $(GCC_VERSION) -lt 47 && echo 1), 1)
> +		CONFIG_RTE_LIBRTE_THUNDERX_NICVF_PMD=n
> +	endif

In previous version you were disabling the PMD inside the PMD Makefile.
It was better.

  parent reply	other threads:[~2017-04-06 13:59 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-06 12:14 [dpdk-dev] [PATCH 1/3] net/thunderx: disable pmd for gcc < 4.7 Ferruh Yigit
2017-04-06 12:14 ` [dpdk-dev] [PATCH 2/3] event/octeontx: fix compilation for gcc < 4.6 Ferruh Yigit
2017-04-06 12:26   ` Jerin Jacob
2017-04-06 12:14 ` [dpdk-dev] [PATCH 3/3] event/sw: fix build error for gcc 4.5.1 Ferruh Yigit
2017-04-06 12:21   ` Van Haaren, Harry
2017-04-06 12:33 ` [dpdk-dev] [PATCH 1/3] net/thunderx: disable pmd for gcc < 4.7 Jerin Jacob
2017-04-06 13:05 ` Ferruh Yigit
2017-04-06 13:46 ` [dpdk-dev] [PATCH v2 1/3] net/thunderx: disable pmd for older compilers Ferruh Yigit
2017-04-06 13:46   ` [dpdk-dev] [PATCH v2 2/3] event/octeontx: fix build error for gcc < 4.6 Ferruh Yigit
2017-04-06 13:46   ` [dpdk-dev] [PATCH v2 3/3] event/sw: fix build error for gcc 4.5.1 Ferruh Yigit
2017-04-06 13:59   ` Thomas Monjalon [this message]
2017-04-06 14:05     ` [dpdk-dev] [PATCH v2 1/3] net/thunderx: disable pmd for older compilers Ferruh Yigit
2017-04-06 14:09       ` Thomas Monjalon
2017-04-06 14:46         ` Ferruh Yigit
2017-04-06 17:05   ` [dpdk-dev] [PATCH v3 1/3] net/thunderx: disable PMD " Ferruh Yigit
2017-04-06 17:05     ` [dpdk-dev] [PATCH v3 2/3] event/octeontx: fix build error for gcc < 4.6 Ferruh Yigit
2017-04-06 17:05     ` [dpdk-dev] [PATCH v3 3/3] event/sw: fix build error for gcc 4.5.1 Ferruh Yigit
2017-04-06 18:40     ` [dpdk-dev] [PATCH v3 1/3] net/thunderx: disable PMD for older compilers Thomas Monjalon
2017-04-06 13:52 ` [dpdk-dev] [PATCH 1/3] net/thunderx: disable pmd for gcc < 4.7 Thomas Monjalon
2017-04-06 14:00   ` Jerin Jacob

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2608561.Cu0AakAGmg@xps13 \
    --to=thomas.monjalon@6wind.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=harry.van.haaren@intel.com \
    --cc=jerin.jacob@caviumnetworks.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).