From: Thomas Monjalon <thomas@monjalon.net>
To: Amit Prakash Shukla <amitprakashs@marvell.com>
Cc: fengchengwen <fengchengwen@huawei.com>,
dev@dpdk.org, Kevin Laatz <kevin.laatz@intel.com>,
Bruce Richardson <bruce.richardson@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>, Jerin Jacob <jerinj@marvell.com>,
Vamsi Krishna Attunuru <vattunuru@marvell.com>,
Nithin Kumar Dabilpuram <ndabilpuram@marvell.com>,
Anoob Joseph <anoobj@marvell.com>,
"mb@smartsharesystems.com" <mb@smartsharesystems.com>
Subject: Re: [EXT] Re: [PATCH v2] lib/dmadev: get DMA device using device ID
Date: Fri, 09 Feb 2024 18:36:29 +0100 [thread overview]
Message-ID: <2625483.9Mp67QZiUf@thomas> (raw)
In-Reply-To: <SJ0PR18MB5161F3C951E1E1C7A858C6B1C84B2@SJ0PR18MB5161.namprd18.prod.outlook.com>
09/02/2024 12:30, Amit Prakash Shukla:
>
> <snip>
> > > >
> > > > invoke (*dev->dev_ops->dma_adapter_vchan_add)(dev, dma_dev_id,
> > > > vchan, event),
> > > >
> > > > at cnxk driver, this ops will check whether the DMA is
> > > > cnxk_dmadev_pci_driver.
> > > >
> > > > I think this is because the cnxk's event-and-dma implement has deep
> > > > coupling
> > > >
> > > > (because the cnxk's event device could interact with another
> > > > vendor's dma device).
> > > >
> > > >
> > > > Maybe we should think of a better way to solve this kind of coupling
> > > > problem.
> > >
> > > Id, is the DMA dev id which is used in looking up DMA dev. This API is in-line
> > with the other libraries.
> > > Crypto library has an api rte_cryptodev_pmd_get_dev to get crypto device
> > based on device id.
> >
> > OK I think I understand.
> > It is the library ID, the same as returned by int
> > rte_dma_get_dev_id_by_name(const char *name);
> >
> > I can remove the const and apply if you are OK.
>
> Sure, I am okay.
>
> > I would just change this comment:
> >
> > + * @param dev_id
> > + * Device ID value to select the device structure.
> >
> > into
> >
> > + * DMA device index in dmadev library.
>
> Sure.
> Thanks.
I've also fixed the ID type to be int16_t.
Applied
prev parent reply other threads:[~2024-02-09 17:36 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-08 7:55 [PATCH] " Amit Prakash Shukla
2023-12-09 7:11 ` fengchengwen
2023-12-18 10:41 ` [EXT] " Amit Prakash Shukla
2023-12-11 10:23 ` Bruce Richardson
2023-12-18 11:27 ` [EXT] " Amit Prakash Shukla
2023-12-19 11:00 ` [PATCH v2] " Amit Prakash Shukla
2024-01-08 14:47 ` Anoob Joseph
2024-02-06 6:24 ` Amit Prakash Shukla
2024-02-08 16:25 ` Thomas Monjalon
2024-02-09 8:18 ` fengchengwen
2024-02-09 11:05 ` [EXT] " Amit Prakash Shukla
2024-02-09 11:18 ` Thomas Monjalon
2024-02-09 11:30 ` Amit Prakash Shukla
2024-02-09 17:36 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2625483.9Mp67QZiUf@thomas \
--to=thomas@monjalon.net \
--cc=amitprakashs@marvell.com \
--cc=anoobj@marvell.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=fengchengwen@huawei.com \
--cc=jerinj@marvell.com \
--cc=kevin.laatz@intel.com \
--cc=mb@smartsharesystems.com \
--cc=ndabilpuram@marvell.com \
--cc=vattunuru@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).