From: Thomas Monjalon <thomas@monjalon.net>
To: "Burakov, Anatoly" <anatoly.burakov@intel.com>
Cc: Bruce Richardson <bruce.richardson@intel.com>,
David Marchand <david.marchand@redhat.com>,
dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] eal: move compat includes to common meson file
Date: Thu, 10 Jan 2019 09:52:43 +0100 [thread overview]
Message-ID: <2632071.H5f8aPozaM@xps> (raw)
In-Reply-To: <b767da98-9c78-58e1-cd9d-97bd2dea9470@intel.com>
10/01/2019 09:45, Burakov, Anatoly:
> On 09-Jan-19 9:36 PM, Thomas Monjalon wrote:
> > 09/01/2019 21:51, Bruce Richardson:
> >> On Wed, Jan 09, 2019 at 06:29:32PM +0100, David Marchand wrote:
> >>> On Wed, Jan 9, 2019 at 6:18 PM Anatoly Burakov
> >>> <[1]anatoly.burakov@intel.com> wrote:
> >>>
> >>> Currently, while EAL does depend on librte_compat as far as common
> >>> meson build is concerned, for some reason the headers for that
> >>> library are not added into the list of includes. This is fixed in
> >>> Linuxapp-specific meson file, but is absent from FreeBSD meson file.
> >>> This worked fine up until recently, when an rte_compat dependency
> >>> was added to rte_log, which is a common header. Fix this issue by
> >>> adding librte_compat includes to common EAL meson file.
> >>> Fixes: 844514c73569 ("eal: build with meson")
> >>> Fixes: a8499f65a1d1 ("log: add missing experimental tag")
> >>> Cc: [2]bruce.richardson@intel.com
> >>> Cc: [3]david.marchand@redhat.com
> >>> Cc: [4]stable@dpdk.org
> >>> Signed-off-by: Anatoly Burakov <[5]anatoly.burakov@intel.com>
> >>>
> >>> lgtm, thanks.
> >>> Reviewed-by: David Marchand <[6]david.marchand@redhat.com>
> >>> --
> >>> David Marchand
> >>>
> >> Agreed.
> >> One other point I'd make is that having compat as a separate library seems
> >> a little like overkill to me - it's just one header file! Is there a reason
> >> why we don't just move it into the EAL where everyone can use it without
> >> having to specify another dependency?
> >
> > +1 for moving compat into EAL.
> >
>
> Presumably the reason to keep it separate would be to enable depending
> on it for libraries that EAL itself depends on (i.e. kvargs).
Yes, forgot this one.
next prev parent reply other threads:[~2019-01-10 8:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-09 17:18 Anatoly Burakov
2019-01-09 17:29 ` David Marchand
2019-01-09 20:51 ` Bruce Richardson
2019-01-09 21:36 ` Thomas Monjalon
2019-01-10 8:45 ` Burakov, Anatoly
2019-01-10 8:52 ` Thomas Monjalon [this message]
2019-01-10 10:02 ` Bruce Richardson
2019-01-10 10:33 ` Thomas Monjalon
2019-01-10 10:34 ` Burakov, Anatoly
2019-01-10 10:41 ` Bruce Richardson
2019-01-10 10:44 ` David Marchand
2019-01-10 10:48 ` Bruce Richardson
2019-01-10 11:13 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2632071.H5f8aPozaM@xps \
--to=thomas@monjalon.net \
--cc=anatoly.burakov@intel.com \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).