From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: David Marchand <david.marchand@6wind.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 0/3] eal / bonding pmd cleanup
Date: Mon, 29 Sep 2014 14:12:40 +0200 [thread overview]
Message-ID: <2664722.6NP5qZZqUi@xps13> (raw)
In-Reply-To: <20140922130426.GE25406@hmsreliant.think-freely.org>
> > >> This patchset reworks the bonding pmd so that we don't need to modify the
> > >> eal
> > >> for this pmd to work.
> > >>
> > >> Basically, the arguments parsed at bond_init are stored in the bond
> > >> private
> > >> structure to be used at dev_configure time.
> > >> If no argument are present, we suppose that the bonding api has been
> > >> called.
> > >>
> > >
> > > I did not get any comment on these patches.
> > > Anyone ?
> > >
> > > The idea here is to keep pmd stuff in the pmds and avoid polluting the eal.
> >
> > ping
>
> Sorry, it was on my todo list and it kept getting pushed back. I like the
> change, its makes great sense and does proper isolation of the PMD.
>
> Acked-by: Neil Horman <nhorman@tuxdriver.com>
Acked-by: Thomas Monjalon <thomas.monjalon@6wind.com>
Applied.
Patches 2 and 3 were merged since 2 is a revert and 3 is a partial revert
of the revert ;)
This patchset prove that my initial request was not so complex :)
(http://dpdk.org/ml/archives/dev/2014-June/003833.html)
Thanks
--
Thomas
prev parent reply other threads:[~2014-09-29 12:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-26 14:12 David Marchand
2014-08-26 14:12 ` [dpdk-dev] [PATCH 1/3] bond: move param parsing in dev_configure David Marchand
2014-08-26 14:12 ` [dpdk-dev] [PATCH 2/3] Revert "eal: support link bonding device initialization" David Marchand
2014-08-26 14:12 ` [dpdk-dev] [PATCH 3/3] eal: probe pci devices at rte_eal_init time David Marchand
2014-09-16 13:05 ` [dpdk-dev] [PATCH 0/3] eal / bonding pmd cleanup David Marchand
2014-09-22 11:02 ` David Marchand
2014-09-22 13:04 ` Neil Horman
2014-09-29 12:12 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2664722.6NP5qZZqUi@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=david.marchand@6wind.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).