DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Yuying Zhang <Yuying.Zhang@intel.com>,
	Beilei Xing <beilei.xing@intel.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH] net/i40e: fix build with MinGW GCC 12
Date: Tue, 04 Oct 2022 13:21:56 +0200	[thread overview]
Message-ID: <2673690.9PvXe5no7K@thomas> (raw)
In-Reply-To: <20221004111742.1497105-1-thomas@monjalon.net>

04/10/2022 13:17, Thomas Monjalon:
> When compiling with MinGW GCC 12,
> the rte_flow_item array is seen as read out of bound:
> 
> net/i40e/i40e_hash.c:389:47: error:
> 	array subscript 50 is above array bounds of ‘const uint64_t[50]’
> 	{aka ‘const long long unsigned int[50]’} [-Werror=array-bounds]
> 	389 | item_hdr = pattern_item_header[last_item_type];
> 	    |            ~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~
> 
> It seems the assert check done above this line has no impact.
> A check is added to make the compiler happy.

We could add those lines as the real issue is the item array:

Fixes: ef4c16fd9148 ("net/i40e: refactor RSS flow")
Cc: stable@dpdk.org

> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---
>  drivers/net/i40e/i40e_hash.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/net/i40e/i40e_hash.c b/drivers/net/i40e/i40e_hash.c
> index 8962e9d97a..ba616aea9f 100644
> --- a/drivers/net/i40e/i40e_hash.c
> +++ b/drivers/net/i40e/i40e_hash.c
> @@ -386,6 +386,8 @@ i40e_hash_get_pattern_type(const struct rte_flow_item pattern[],
>  		prev_item_type = last_item_type;
>  		assert(last_item_type < (enum rte_flow_item_type)
>  				RTE_DIM(pattern_item_header));
> +		if (last_item_type >= RTE_DIM(pattern_item_header))
> +			goto not_sup;
>  		item_hdr = pattern_item_header[last_item_type];
>  		assert(item_hdr);
>  
> 






  reply	other threads:[~2022-10-04 11:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-04 11:17 Thomas Monjalon
2022-10-04 11:21 ` Thomas Monjalon [this message]
2022-10-06 10:27   ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2673690.9PvXe5no7K@thomas \
    --to=thomas@monjalon.net \
    --cc=Yuying.Zhang@intel.com \
    --cc=beilei.xing@intel.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).