DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Zhang, Fan" <fanzhang.oss@gmail.com>
To: dev@dpdk.org
Subject: Re: [PATCH v1] eventdev/crypto: wrong crypto enqueue count stats
Date: Fri, 24 Feb 2023 14:41:22 +0000	[thread overview]
Message-ID: <26912e28-fbd7-0e95-a8ad-3e66537febc8@gmail.com> (raw)
In-Reply-To: <20221130151159.1678917-1-ganapati.kundapura@intel.com>

On 11/30/2022 3:11 PM, Ganapati Kundapura wrote:
> crypto_enq_count is updated on failure to enqueue ops to cryptodev.
>
> Updated crypto_enq_count on successful enqueue of ops to cryptodev.
>
> Signed-off-by: Ganapati Kundapura <ganapati.kundapura@intel.com>
>
> diff --git a/lib/eventdev/rte_event_crypto_adapter.c b/lib/eventdev/rte_event_crypto_adapter.c
> index c293a62..e1a0367 100644
> --- a/lib/eventdev/rte_event_crypto_adapter.c
> +++ b/lib/eventdev/rte_event_crypto_adapter.c
> @@ -485,6 +485,9 @@ eca_enq_to_cryptodev(struct event_crypto_adapter *adapter, struct rte_event *ev,
>   								cdev_id,
>   								qp_id,
>   								&nb_enqueued);
> +			stats->crypto_enq_count += nb_enqueued;
> +			n += nb_enqueued;
> +
>   			/**
>   			 * If some crypto ops failed to flush to cdev and
>   			 * space for another batch is not available, stop
> @@ -495,9 +498,6 @@ eca_enq_to_cryptodev(struct event_crypto_adapter *adapter, struct rte_event *ev,
>   							&qp_info->cbuf)))
>   				adapter->stop_enq_to_cryptodev = true;
>   		}
> -
> -		stats->crypto_enq_count += nb_enqueued;
> -		n += nb_enqueued;
>   	}
>   
>   	return n;
Acked-by: Fan Zhang <fanzhang.oss@gmail.com>

      reply	other threads:[~2023-02-24 14:41 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-30 15:11 Ganapati Kundapura
2023-02-24 14:41 ` Zhang, Fan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=26912e28-fbd7-0e95-a8ad-3e66537febc8@gmail.com \
    --to=fanzhang.oss@gmail.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).