From: Thomas Monjalon <thomas@monjalon.net>
To: "Hunt, David" <david.hunt@intel.com>
Cc: dev@dpdk.org, "De Lara Guarch,
Pablo" <pablo.de.lara.guarch@intel.com>,
"Wu, Jingjing" <jingjing.wu@intel.com>
Subject: Re: [dpdk-dev] [PATCH v1] app/testpmd: fix Tx first with LSC interrupt
Date: Thu, 03 Aug 2017 23:44:03 +0200 [thread overview]
Message-ID: <2692805.uYAMR96KvV@xps> (raw)
In-Reply-To: <E115CCD9D858EF4F90C690B0DCB4D8976CBE5B53@IRSMSX108.ger.corp.intel.com>
> > The lsc_interrupt flag is enabled by default, and when the --tx-first is used
> > as a command line parameter, the 32 packets can be sent out before the
> > link state is up, resulting in the loss of the packets, and no further
> > forwarding will take place.
> >
> > E.g. ./build/app/testpmd -c f0 -- --tx-first --stats-period 1
> >
> > When the --tx-first is used, the lsc_interrupt flag needs to be disabled,
> > ensuring the links are up before forwarding traffic. Therefore, during the
> > parameter checking at startup, if --tx-first is used, we now warn the user,
> > and set lsc_interrupt to 0.
> >
> > Fixes: 99cabef08855 ("app/testpmd: add parameter to start forwarding Tx
> > first")
> > Signed-off-by: David Hunt <david.hunt@intel.com>
>
> Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Applied, thanks
prev parent reply other threads:[~2017-08-03 21:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-25 10:27 David Hunt
2017-08-01 12:54 ` De Lara Guarch, Pablo
2017-08-03 21:44 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2692805.uYAMR96KvV@xps \
--to=thomas@monjalon.net \
--cc=david.hunt@intel.com \
--cc=dev@dpdk.org \
--cc=jingjing.wu@intel.com \
--cc=pablo.de.lara.guarch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).