From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Takuya ASADA <syuu@cloudius-systems.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [RFC PATCHv3 0/7] add OSv support
Date: Thu, 09 Jul 2015 01:35:51 +0200 [thread overview]
Message-ID: <2695914.AOYJdCUfZl@xps13> (raw)
In-Reply-To: <CAPWdgggjvMZGUpY6_GPjCgqN00UiWkm50M8z3oLa7gU8x1BmbA@mail.gmail.com>
Hi Takuya,
It has been difficult to receive comments on this series during 2.1 cycle.
I see 3 reasons:
- few people know OSv
- the series is mixing C++ support and OSv environment
- you are adding a third system to support while some work is in progress
to reduce differences between Linux and BSD support.
I suggest to:
- fix doc with John's help
- split C++ and OSv patches
- help to merge Linux and BSD common code
- introduce a common config file for every environments
- re-send OSv support series at the beginning of 2.2 cycle without RFC keyword
Thanks for your work
2015-04-21 03:37, Takuya ASADA:
> Any comments/suggestions?
>
> On Tue, Apr 7, 2015 at 3:58 AM, Takuya ASADA <syuu@cloudius-systems.com>
> wrote:
>
> > This is 3rd version of OSv support patchset.
> >
> > Changelist:
> > - sync with latest master
> > - updated Capstan build script for OSv v0.19
> > - rte_eal_version.map fix
> > - CONFIG_RTE_BUILD_SHARED_LIB=y and CONFIG_RTE_BUILD_COMBINE_LIBS=y by
> > default
> > - Check OSv NIC driver is loaded for each device, attach PMD only if OSv
> > driver is not loaded
> > - Use --maxnic on cmdline to skip loading OSv NIC driver
> > - Don't enable MSI-X on virtio, since it's not enable when OSv NIC driver
> > is not loaded
> >
> > Takuya ASADA (7):
> > mk: support compiling C++ code
> > eal: Add extern C on eal_hugepages.h
> > eal: Add extern C on eal_thread.h
> > eal: Add extern C on eal_private.h
> > add OSv support
> > app/test: support OSv
> > doc: Add Getting Started Guide for OSv
prev parent reply other threads:[~2015-07-08 23:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-06 18:58 Takuya ASADA
2015-04-06 18:58 ` [dpdk-dev] [RFC PATCHv3 1/7] mk: support compiling C++ code Takuya ASADA
2015-04-06 18:58 ` [dpdk-dev] [RFC PATCHv3 2/7] eal: Add extern C on eal_hugepages.h Takuya ASADA
2015-04-06 18:58 ` [dpdk-dev] [RFC PATCHv3 3/7] eal: Add extern C on eal_thread.h Takuya ASADA
2015-04-06 18:58 ` [dpdk-dev] [RFC PATCHv3 4/7] eal: Add extern C on eal_private.h Takuya ASADA
2015-04-06 18:58 ` [dpdk-dev] [RFC PATCHv3 5/7] add OSv support Takuya ASADA
2015-04-06 18:58 ` [dpdk-dev] [RFC PATCHv3 6/7] app/test: support OSv Takuya ASADA
2015-04-06 18:58 ` [dpdk-dev] [RFC PATCHv3 7/7] doc: Add Getting Started Guide for OSv Takuya ASADA
2015-06-18 14:09 ` Mcnamara, John
2015-04-20 18:37 ` [dpdk-dev] [RFC PATCHv3 0/7] add OSv support Takuya ASADA
2015-07-08 23:35 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2695914.AOYJdCUfZl@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=syuu@cloudius-systems.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).