From: Thomas Monjalon <thomas@monjalon.net>
To: Ophir Munk <ophirmu@mellanox.com>
Cc: dev@dpdk.org, "De Lara Guarch,
Pablo" <pablo.de.lara.guarch@intel.com>,
"Wu, Jingjing" <jingjing.wu@intel.com>
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v2] app/testpmd: fix forwarding between non consecutive ports
Date: Tue, 07 Nov 2017 21:42:40 +0100 [thread overview]
Message-ID: <2698635.jqlqO458xW@xps> (raw)
In-Reply-To: <E115CCD9D858EF4F90C690B0DCB4D8976CC45FC1@IRSMSX108.ger.corp.intel.com>
07/11/2017 18:43, De Lara Guarch, Pablo:
> From: Ophir Munk
> >
> > When defining two failsafe devices in testpmd the port numbers of the
> > failsafe devices may not be consecutive.
> > For example: if failsafe device includes a PCI device and a TAP device then
> > failsafe port numbers would be 0 and 3.
> > Port 0 - failsafe #1 device
> > Port 1 - PCI #1 device
> > Port 2 - TAP #1 device
> > Port 3 - failsafe #2 device
> > Port 4 - PCI #2 device
> > Port 5 - TAP #2 device
> >
> > If forwarding is defined between the failsafe devices including a peer
> > address the forwarding should be between peer addresses of ports 0 and 3.
> > Instead testpmd establishes forwarding between peer addresses of
> > consecutive ports 0 and 1. This commit fixes this bug.
> >
> > Fixes: af75078fece3 ("first public release")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Ophir Munk <ophirmu@mellanox.com>
> > Signed-off-by: Raslan Darawsheh <rasland@mellanox.com>
>
> Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Applied, thanks
prev parent reply other threads:[~2017-11-07 20:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-06 14:19 [dpdk-dev] [PATCH v1] app/testpmd: fix fwd between two failsafe devices Ophir Munk
2017-11-07 13:31 ` [dpdk-dev] [PATCH v2] app/testpmd: fix forwarding between non consecutive ports Ophir Munk
2017-11-07 13:47 ` Ophir Munk
2017-11-07 13:52 ` Ophir Munk
2017-11-07 14:26 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
2017-11-07 17:43 ` De Lara Guarch, Pablo
2017-11-07 20:42 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2698635.jqlqO458xW@xps \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=jingjing.wu@intel.com \
--cc=ophirmu@mellanox.com \
--cc=pablo.de.lara.guarch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).