From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Christian Ehrhardt <christian.ehrhardt@canonical.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] examples: fix unusual-interpreter
Date: Mon, 01 Aug 2016 15:26:15 +0200 [thread overview]
Message-ID: <2698928.TdmtWMiOju@xps13> (raw)
In-Reply-To: <CAATJJ0JXd-vgGcFoMvbCvTKMM4mfPPSvEfp=7+d2h3qtaLvmEA@mail.gmail.com>
2016-08-01 15:12, Christian Ehrhardt:
> On Mon, Aug 1, 2016 at 2:50 PM, Thomas Monjalon <thomas.monjalon@6wind.com>
> wrote:
> > 2016-08-01 14:28, Christian Ehrhardt:
> > > Due to regular lintian checks in Debian packaging it surfaced that these
> > > two scripts had a space in their #! statement which renders it to be
> > > human, but not shell readable.
> > [...]
> > > -#! /usr/bin/python2
> > > +#!/usr/bin/python2
> >
> > I think we can have a space in the shebang (it works with shells I know).
> > But maybe lintian do not like it (and it is a sufficient reason to accept
> > this trivial patch).
> >
> > However, a better fix would be to run something else than python2,
> > like /usr/bin/env python.
> >
> > Some other python scripts in tools dir may be fixed.
>
> I agree on both changes you suggested, but not being the scripts author I
> wanted to change as few as possible.
> Also thanks for taking it into consideration even if just for lintian :-)
>
> If acceptable to you I'd ask to accept this as-is and consider the patch a
> head-up for all script owners to change their headers.
We can remove the space in every scripts, at least.
Then we can wait a little for the opinion of the script authors to do
more changes.
PS: Please avoid top posting.
next prev parent reply other threads:[~2016-08-01 13:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-01 12:28 Christian Ehrhardt
2016-08-01 12:50 ` Thomas Monjalon
2016-08-01 13:12 ` Christian Ehrhardt
2016-08-01 13:26 ` Thomas Monjalon [this message]
2016-08-01 15:11 ` Mcnamara, John
2016-08-02 6:40 ` [dpdk-dev] [PATCH v2] " Christian Ehrhardt
2016-08-02 10:01 ` Dumitrescu, Cristian
2016-08-24 16:14 ` Thomas Monjalon
2016-08-01 15:05 ` [dpdk-dev] [PATCH] " Dumitrescu, Cristian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2698928.TdmtWMiOju@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=christian.ehrhardt@canonical.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).