From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Shrikrishna Khare <skhare@vmware.com>, yongwang@vmware.com
Cc: dev@dpdk.org, Guolin Yang <gyang@vmware.com>
Subject: Re: [dpdk-dev] [PATCH 6/7] vmxnet3: introduce command to register memory region
Date: Fri, 3 Mar 2017 10:46:25 +0000 [thread overview]
Message-ID: <26cbffea-5ccd-a2b1-346b-dca6fea9c141@intel.com> (raw)
In-Reply-To: <1488059989-6930-7-git-send-email-skhare@vmware.com>
On 2/25/2017 9:59 PM, Shrikrishna Khare wrote:
> In vmxnet3 version 3, the emulation added support for the vmxnet3 driver
> to communicate information about the memory regions the driver will use
> for rx/tx buffers. The driver can also indicate which rx/tx queue the
> memory region is applicable for. If this information is communicated
> to the emulation, the emulation will always keep these memory regions
> mapped, thereby avoiding the mapping/unmapping overhead for every packet.
>
> Signed-off-by: Shrikrishna Khare <skhare@vmware.com>
> Signed-off-by: Guolin Yang <gyang@vmware.com>
> Acked-by: Yong Wang <yongwang@vmware.com>
> Acked-by: Jin Heo <heoj@vmware.com>
<...>
> + PMD_INIT_LOG(INFO,
> + "index: %u startPA: %lu length: %u, rxBits: %x",
> + j, mr->startPA, mr->length, mr->rxQueueBits);
> + j++;
> + }
> + hw->memRegs->numRegs = j;
> + PMD_INIT_LOG("numRegs: %u", j);
Macro argument is not correct, causing following build error:
.../drivers/net/vmxnet3/vmxnet3_ethdev.c:568:2: error: pasting formed
'RTE_LOG_"numRegs: %u"', an invalid preprocessing token
PMD_INIT_LOG("numRegs: %u", j);
^
next prev parent reply other threads:[~2017-03-03 10:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-25 21:59 [dpdk-dev] [PATCH 0/7] vmxnet3: upgrade to version 3 Shrikrishna Khare
2017-02-25 21:59 ` [dpdk-dev] [PATCH 1/7] vmxnet3: prepare for version 3 changes Shrikrishna Khare
2017-02-25 21:59 ` [dpdk-dev] [PATCH 2/7] vmxnet3: introduce generalized command interface to configure the device Shrikrishna Khare
2017-02-25 21:59 ` [dpdk-dev] [PATCH 3/7] vmxnet3: allow variable length transmit data ring buffer Shrikrishna Khare
2017-02-25 21:59 ` [dpdk-dev] [PATCH 4/7] vmxnet3: add receive data ring support Shrikrishna Khare
2017-02-25 21:59 ` [dpdk-dev] [PATCH 5/7] vmxnet3: add reserved version 3 command Shrikrishna Khare
2017-02-25 21:59 ` [dpdk-dev] [PATCH 6/7] vmxnet3: introduce command to register memory region Shrikrishna Khare
2017-03-03 10:46 ` Ferruh Yigit [this message]
2017-03-03 10:51 ` Ferruh Yigit
2017-02-25 21:59 ` [dpdk-dev] [PATCH 7/7] vmxnet3: update to version 3 Shrikrishna Khare
2017-03-03 10:57 ` [dpdk-dev] [PATCH 0/7] vmxnet3: upgrade " Ferruh Yigit
2017-03-06 17:25 ` Shrikrishna Khare
2017-03-07 12:17 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=26cbffea-5ccd-a2b1-346b-dca6fea9c141@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=gyang@vmware.com \
--cc=skhare@vmware.com \
--cc=yongwang@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).