From: Akhil Goyal <akhil.goyal@nxp.com>
To: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "Doherty, Declan" <declan.doherty@intel.com>,
"hemant.agrawal@nxp.com" <hemant.agrawal@nxp.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [PATCH] test/crypto: fix dpaa2_sec macros and definitions
Date: Thu, 5 Oct 2017 17:55:50 +0530 [thread overview]
Message-ID: <2771f09c-b502-6f35-74b4-d6b0829b91fd@nxp.com> (raw)
In-Reply-To: <E115CCD9D858EF4F90C690B0DCB4D8976CC2B192@IRSMSX108.ger.corp.intel.com>
Hi Pablo,
On 10/5/2017 1:49 PM, De Lara Guarch, Pablo wrote:
> Hi Akhil,
>
>> -----Original Message-----
>> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Akhil Goyal
>> Sent: Tuesday, October 3, 2017 10:29 AM
>> To: dev@dpdk.org
>> Cc: Doherty, Declan <declan.doherty@intel.com>; De Lara Guarch, Pablo
>> <pablo.de.lara.guarch@intel.com>; hemant.agrawal@nxp.com;
>> stable@dpdk.org; Akhil Goyal <akhil.goyal@nxp.com>
>> Subject: [dpdk-dev] [PATCH] test/crypto: fix dpaa2_sec macros and
>> definitions
>>
>> Fixes: 7a364faef185 ("cryptodev: remove crypto device type enumeration")
>>
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Akhil Goyal <akhil.goyal@nxp.com>
>> ---
>> test/test/test_cryptodev.c | 2 +-
>> test/test/test_cryptodev_perf.c | 4 ++--
>> 2 files changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/test/test/test_cryptodev.c b/test/test/test_cryptodev.c index
>> a4116c6..132f99c 100644
>> --- a/test/test/test_cryptodev.c
>> +++ b/test/test/test_cryptodev.c
>> @@ -1816,7 +1816,7 @@ test_authonly_dpaa2_sec_all(void)
>> ts_params->session_mpool,
>> ts_params->valid_devs[0],
>> rte_cryptodev_driver_id_get(
>> - RTE_STR(RTE_CRYPTODEV_DPAA2_SEC_PMD)),
>> + RTE_STR(CRYPTODEV_NAME_DPAA2_SEC_PMD)),
>> BLKCIPHER_AUTHONLY_TYPE);
>>
>> TEST_ASSERT_EQUAL(status, 0, "Test failed"); diff --git
>> a/test/test/test_cryptodev_perf.c b/test/test/test_cryptodev_perf.c index
>> 3b57e6d..5df2e6e 100644
>> --- a/test/test/test_cryptodev_perf.c
>> +++ b/test/test/test_cryptodev_perf.c
>> @@ -211,7 +211,7 @@ static const char *pmd_name(uint8_t driver_id) {
>> uint8_t null_pmd = rte_cryptodev_driver_id_get(
>> RTE_STR(CRYPTODEV_NAME_NULL_PMD));
>> - uint8_t dpaa2_pmd = rte_cryptodev_driver_id_get(
>> + uint8_t dpaa2_sec_pmd = rte_cryptodev_driver_id_get(
>
> I think, in order to keep consistency, you should make this change also in test_cryptodev.c:
>
> test/test/test_cryptodev_blockcipher.c
> 580: int dpaa2_pmd = rte_cryptodev_driver_id_get(
> 646: else if (driver_id == dpaa2_pmd)
>
> Also, I submitted a patch to remove test_cryptodev_perf.c.
> I will apply this patch first, so it is easier to integrate in the stable version,
> but could you ack my patch if you are OK with it?
>
> The sooner we remove it, the better, as we are investing a lot of time
> in the crypto-perf app, and there is no need to maintain a duplicate, in my opinion.
>
thanks for pointing this out. I would send a v2.
I have a question regarding test_cryptodev_perf.c for dpaa_sec patches.
The patchset for dpaa_sec includes changes in test_cryptodev_perf.c.
Do you plan to add those patches on the tree as well before removing
this file or I need to send another version?
In test/test/test_cryptodev_blockcipher.c, I missed out this change for
dpaa_sec also. So, I was sending another version for dpaa_sec patches to
include this change. Should I remove the changes in the
test_cryptodev_perf.c from the dpaa_sec patchset also?
Thanks,
Akhil
next prev parent reply other threads:[~2017-10-05 12:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-03 9:29 Akhil Goyal
2017-10-05 8:19 ` [dpdk-stable] [dpdk-dev] " De Lara Guarch, Pablo
2017-10-05 12:25 ` Akhil Goyal [this message]
2017-10-05 12:59 ` [dpdk-stable] " De Lara Guarch, Pablo
2017-10-05 12:50 ` [dpdk-stable] [PATCH v2] " Akhil Goyal
2017-10-05 13:30 ` De Lara Guarch, Pablo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2771f09c-b502-6f35-74b4-d6b0829b91fd@nxp.com \
--to=akhil.goyal@nxp.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=hemant.agrawal@nxp.com \
--cc=pablo.de.lara.guarch@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).