From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: "dumitru.ceara@gmail.com" <dumitru.ceara@gmail.com>
Cc: dev@dpdk.org, "Ananyev,
Konstantin" <konstantin.ananyev@intel.com>,
"Xing, Beilei" <beilei.xing@intel.com>,
"Zhang, Helin" <helin.zhang@intel.com>,
"Wu, Jingjing" <jingjing.wu@intel.com>
Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix setting RSS in i40e_recv_scattered_pkts
Date: Thu, 28 Jul 2016 15:48:18 +0200 [thread overview]
Message-ID: <2794870.2VdubtuQhq@xps13> (raw)
In-Reply-To: <2601191342CEEE43887BDE71AB97725836B820EF@irsmsx105.ger.corp.intel.com>
> > From: Dumitru Ceara <dumitru.ceara@gmail.com>
> >
> > The driver is incorrectly setting the RSS field in the last mbuf in the packet chain instead of the first. Moreover, the last mbuf might have
> > already been freed if it only contained the Ethernet CRC.
> >
> > Also, fix the call to i40e_rxd_build_fdir to store the fdir flags in the first mbuf of the chain instead of the last.
> >
> > Signed-off-by: Dumitru Ceara <dumitru.ceara@gmail.com>
>
> Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
Fixes: 4861cde46116 ("i40e: new poll mode driver")
Fixes: 5a21d9715f81 ("i40e: report flow director matching")
Title reworded: net/i40e: fix metadata in first mbuf of scattered Rx
Applied, thanks
prev parent reply other threads:[~2016-07-28 13:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-26 9:23 [dpdk-dev] [dpdk-users] RSS Hash not working for XL710/X710 NICs for some RX mbuf sizes Ananyev, Konstantin
2016-07-26 10:46 ` [dpdk-dev] [PATCH] net/i40e: fix setting RSS in i40e_recv_scattered_pkts dumitru.ceara
2016-07-26 12:11 ` Ananyev, Konstantin
2016-07-28 13:48 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2794870.2VdubtuQhq@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=dumitru.ceara@gmail.com \
--cc=helin.zhang@intel.com \
--cc=jingjing.wu@intel.com \
--cc=konstantin.ananyev@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).