From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Andrew Rybchenko <arybchenko@solarflare.com>,
Stephen Hemminger <stephen@networkplumber.org>,
dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v5 00/15] common ethdev linkstatus functions
Date: Wed, 17 Jan 2018 14:32:17 +0000 [thread overview]
Message-ID: <27f327e5-5632-69cc-feaa-10cf9384a701@intel.com> (raw)
In-Reply-To: <42f4f5a2-008d-c3e8-4c00-ed9ef59065c8@solarflare.com>
On 1/17/2018 7:56 AM, Andrew Rybchenko wrote:
> On 01/16/2018 09:37 PM, Stephen Hemminger wrote:
>> While reviewing drivers, noticed a lot of unnecessary
>> duplication of code in drivers for handling the eth_dev link status
>> information. While consolidating this, it also became obvious that
>> some drivers behave differently for no good reason.
>>
>> It also was a good chance to introduce atomic exchange primitives
>> in EAL because there are other places using cmpset where not
>> necessary (such as bonding).
>>
>> Mostly only compile tested only, don't have all of the hardware
>> available (except ixgbe and virtio) to test.
>>
>> Note: the eth_dev_link_update function return value is inconsistent
>> across drivers. Should be changed to be void.
>
> I would say "link_update" callback return value is inconsistent across
> drivers. I'm not sure which direction is right here: make it consistent
> or make it void. Also any changes in link information could be
> important. As I understand it should not happen without up/down,
> but bugs with loss of intermediate transitions are definitely possible.
> So, notifying about any changes in link information is definitely safer.
> May be not now.
Again, why not return previous link status, it is simple enough to prevent
inconsistent usage.
rte_eth_link_get() already discards the return value, so won't be a problem there.
For the cases PMD would like know about link changes, they will need to
implement almost same link_update function with a return value, so why not use
existing link_update function?
Like been in virtio, link_update() used in interrupt handler, and calls a
callback process if status changes. When link_update() return status changed to
void, I guess they will need to implement another version of the link_update
with return and use it.
>
>>
>> v5
>> - checkpatch whitespace cleanup
>>
>> v4
>> - incorporate review feedback
>> - rename _rte_linkstatus to rte_linkstatus
>> - change return value of _rte_linkstatus
>> - optimize get on 64bit platforms
>> - change return value of rte_linkstatus_set
>>
>> v3
>> - align rte_linkstatus_get with rte_atomic64_read
>> - virtio use ETH_SPEED_NUM_10G
>> - add net/
>>
>> v2
>> - function names changed
>> - rebased to current master
>>
>> Stephen Hemminger (15):
>> eal: introduce atomic exchange operation
>> ethdev: add linkstatus get/set helper functions
>> net/virtio: use eth_linkstatus_set
>> net/vmxnet3: use rte_eth_linkstatus_set
>> net/dpaa2: use rte_eth_linkstatus_set
>> net/nfp: use rte_eth_linkstatus functions
>> net/e1000: use rte_eth_linkstatus helpers
>> net/ixgbe: use rte_eth_linkstatus functions
>> net/sfc: use new rte_eth_linkstatus functions
>> net/i40e: use rte_eth_linkstatus functions
>> net/liquidio: use rte_eth_linkstatus_set
>> net/thunderx: use rte_eth_linkstatus_set
>> net/szedata: use _rte_eth_linkstatus_set
>> net/octeontx: use rte_eth_linkstatus_set
>> net/enic: use rte_eth_linkstatus_set
>>
>> drivers/net/dpaa2/dpaa2_ethdev.c | 75 ++---------------
>> drivers/net/e1000/em_ethdev.c | 69 ++--------------
>> drivers/net/e1000/igb_ethdev.c | 70 ++--------------
>> drivers/net/enic/enic_ethdev.c | 5 +-
>> drivers/net/enic/enic_main.c | 17 ++--
>> drivers/net/i40e/i40e_ethdev.c | 43 ++--------
>> drivers/net/i40e/i40e_ethdev_vf.c | 18 +---
>> drivers/net/ixgbe/ixgbe_ethdev.c | 96 ++++------------------
>> drivers/net/liquidio/lio_ethdev.c | 53 ++----------
>> drivers/net/nfp/nfp_net.c | 77 ++---------------
>> drivers/net/octeontx/octeontx_ethdev.c | 17 +---
>> drivers/net/sfc/sfc_ethdev.c | 21 +----
>> drivers/net/sfc/sfc_ev.c | 20 +----
>> drivers/net/szedata2/rte_eth_szedata2.c | 19 ++---
>> drivers/net/thunderx/nicvf_ethdev.c | 18 +---
>> drivers/net/virtio/virtio_ethdev.c | 65 +++------------
>> drivers/net/vmxnet3/vmxnet3_ethdev.c | 86 ++++---------------
>> .../common/include/arch/x86/rte_atomic.h | 24 ++++++
>> .../common/include/arch/x86/rte_atomic_32.h | 12 +++
>> .../common/include/arch/x86/rte_atomic_64.h | 12 +++
>> lib/librte_eal/common/include/generic/rte_atomic.h | 78 ++++++++++++++++++
>> lib/librte_ether/rte_ethdev.c | 22 +----
>> lib/librte_ether/rte_ethdev.h | 62 ++++++++++++++
>> 23 files changed, 302 insertions(+), 677 deletions(-)
>>
>
next prev parent reply other threads:[~2018-01-17 14:32 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-16 18:37 Stephen Hemminger
2018-01-16 18:37 ` [dpdk-dev] [PATCH v5 01/15] eal: introduce atomic exchange operation Stephen Hemminger
2018-01-16 18:37 ` [dpdk-dev] [PATCH v5 02/15] ethdev: add linkstatus get/set helper functions Stephen Hemminger
2018-01-17 7:49 ` Andrew Rybchenko
2018-01-16 18:37 ` [dpdk-dev] [PATCH v5 03/15] net/virtio: use eth_linkstatus_set Stephen Hemminger
2018-01-16 18:37 ` [dpdk-dev] [PATCH v5 04/15] net/vmxnet3: use rte_eth_linkstatus_set Stephen Hemminger
2018-01-16 18:37 ` [dpdk-dev] [PATCH v5 05/15] net/dpaa2: " Stephen Hemminger
2018-01-16 18:37 ` [dpdk-dev] [PATCH v5 06/15] net/nfp: use rte_eth_linkstatus functions Stephen Hemminger
2018-01-16 18:37 ` [dpdk-dev] [PATCH v5 07/15] net/e1000: use rte_eth_linkstatus helpers Stephen Hemminger
2018-01-16 18:37 ` [dpdk-dev] [PATCH v5 08/15] net/ixgbe: use rte_eth_linkstatus functions Stephen Hemminger
2018-01-16 18:37 ` [dpdk-dev] [PATCH v5 09/15] net/sfc: use new " Stephen Hemminger
2018-01-16 18:37 ` [dpdk-dev] [PATCH v5 10/15] net/i40e: use " Stephen Hemminger
2018-01-16 18:37 ` [dpdk-dev] [PATCH v5 11/15] net/liquidio: use rte_eth_linkstatus_set Stephen Hemminger
2018-01-16 18:37 ` [dpdk-dev] [PATCH v5 12/15] net/thunderx: " Stephen Hemminger
2018-01-16 18:37 ` [dpdk-dev] [PATCH v5 13/15] net/szedata: use _rte_eth_linkstatus_set Stephen Hemminger
2018-01-16 18:37 ` [dpdk-dev] [PATCH v5 14/15] net/octeontx: use rte_eth_linkstatus_set Stephen Hemminger
2018-01-16 18:37 ` [dpdk-dev] [PATCH v5 15/15] net/enic: " Stephen Hemminger
2018-01-17 5:19 ` [dpdk-dev] [PATCH v5 00/15] common ethdev linkstatus functions Shreyansh Jain
2018-01-17 7:56 ` Andrew Rybchenko
2018-01-17 14:32 ` Ferruh Yigit [this message]
2018-01-17 16:05 ` Stephen Hemminger
2018-01-17 16:18 ` Ferruh Yigit
2018-01-19 16:35 ` Ferruh Yigit
2018-01-21 18:35 ` Ferruh Yigit
2018-01-21 18:59 ` [dpdk-dev] [PATCH v6 01/14] eal: introduce atomic exchange operation Ferruh Yigit
2018-01-21 18:59 ` [dpdk-dev] [PATCH v6 02/14] ethdev: add linkstatus get/set helper functions Ferruh Yigit
2018-01-21 18:59 ` [dpdk-dev] [PATCH v6 03/14] net/virtio: use ethdev linkstatus " Ferruh Yigit
2018-01-21 18:59 ` [dpdk-dev] [PATCH v6 04/14] net/vmxnet3: " Ferruh Yigit
2018-01-21 18:59 ` [dpdk-dev] [PATCH v6 05/14] net/dpaa2: " Ferruh Yigit
2018-01-22 12:28 ` Shreyansh Jain
2018-01-21 18:59 ` [dpdk-dev] [PATCH v6 06/14] net/nfp: " Ferruh Yigit
2018-01-21 18:59 ` [dpdk-dev] [PATCH v6 07/14] net/e1000: " Ferruh Yigit
2018-01-21 18:59 ` [dpdk-dev] [PATCH v6 08/14] net/ixgbe: " Ferruh Yigit
2018-01-21 18:59 ` [dpdk-dev] [PATCH v6 09/14] net/i40e: " Ferruh Yigit
2018-01-21 18:59 ` [dpdk-dev] [PATCH v6 10/14] net/liquidio: " Ferruh Yigit
2018-01-21 18:59 ` [dpdk-dev] [PATCH v6 11/14] net/thunderx: " Ferruh Yigit
2018-01-21 18:59 ` [dpdk-dev] [PATCH v6 12/14] net/szedata2: " Ferruh Yigit
2018-01-21 18:59 ` [dpdk-dev] [PATCH v6 13/14] net/octeontx: " Ferruh Yigit
2018-01-21 18:59 ` [dpdk-dev] [PATCH v6 14/14] net/enic: " Ferruh Yigit
2018-01-21 19:25 ` [dpdk-dev] [PATCH v6 01/14] eal: introduce atomic exchange operation Ferruh Yigit
2018-01-21 23:50 ` Thomas Monjalon
2018-01-22 16:56 ` Stephen Hemminger
2018-01-22 21:03 ` Thomas Monjalon
2018-01-22 21:48 ` Stephen Hemminger
2018-01-22 22:09 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=27f327e5-5632-69cc-feaa-10cf9384a701@intel.com \
--to=ferruh.yigit@intel.com \
--cc=arybchenko@solarflare.com \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).