DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: John Daley <johndale@cisco.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v6] enic: receive path performance improvements
Date: Tue, 15 Mar 2016 21:42:54 +0100	[thread overview]
Message-ID: <2804669.uFzlJRKE3s@xps13> (raw)
In-Reply-To: <1457125740-13233-1-git-send-email-johndale@cisco.com>

2016-03-04 13:09, John Daley:
> +#ifdef RTE_NEXT_ABI
> +               pkt_err_flags |= PKT_RX_MAC_ERR;
> +#else
> +               pkt_err_flags |= PKT_EXT_RX_PKT_ERROR;
> +#endif
> +       }
> +
> +       /* Check for bad FCS. MAC error isn't quite, but no other choice */
> +       if (!enic_cq_rx_desc_fcs_ok(cqrd)) {
> +#ifdef RTE_NEXT_ABI
> +               pkt_err_flags |= PKT_RX_MAC_ERR;
> +#else
> +               pkt_err_flags |= PKT_EXT_RX_BAD_FCS;
> +#endif

It seems to be a mistake, leading to build failure when NEXT_ABI is disabled.
Will be fixed when rebased on master branch.

      parent reply	other threads:[~2016-03-15 20:44 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-22  1:17 [dpdk-dev] [PATCH v2] " johndale
2016-02-22  2:04 ` [dpdk-dev] [PATCH v3] " johndale
2016-03-03  1:44   ` [dpdk-dev] [PATCH v4] " John Daley
2016-03-04  8:06   ` [dpdk-dev] [PATCH v5 1/2] " John Daley
2016-03-04  8:06     ` [dpdk-dev] [PATCH v5 2/2] enic: remove unused functions John Daley
2016-03-04 21:09   ` [dpdk-dev] [PATCH v6] enic: receive path performance improvements John Daley
2016-03-08 14:43     ` Bruce Richardson
2016-03-15 20:42     ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2804669.uFzlJRKE3s@xps13 \
    --to=thomas.monjalon@6wind.com \
    --cc=dev@dpdk.org \
    --cc=johndale@cisco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).