From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Zbigniew Bodek <zbigniew.bodek@caviumnetworks.com>
Cc: dev@dpdk.org, jerin.jacob@caviumnetworks.com,
bruce.richardson@intel.com, konstantin.ananyev@intel.com
Subject: Re: [dpdk-dev] [PATCH] mk: fix build of assembly files for ARM64
Date: Fri, 27 Jan 2017 08:20:01 -0800 (PST) [thread overview]
Message-ID: <2810758.uGRdNRuYUv@xps13> (raw)
In-Reply-To: <fbfcf0f8-9607-f2b5-e7a7-2fc2d790dcf1@caviumnetworks.com>
2017-01-18 12:31, Zbigniew Bodek:
>
> On 17.01.2017 23:45, Thomas Monjalon wrote:
> > 2017-01-17 15:35, zbigniew.bodek@caviumnetworks.com:
> >> -# for now, we don't use as but nasm.
> >> -# AS = $(CROSS)as
> >
> > It looks to be a very very old comment.
> >
> >> +ifeq ($(CONFIG_RTE_ARCH_X86),y)
> >> AS = nasm
> >
> > There is no asm file in DPDK as far as I know.
> > So why would we have a dependency on nasm for x86?
>
> Yes, there is no such file now. We were to add assembly code but
> eventually we decided to put it in a separate library. Nevertheless this
> fix should be harmless if there is no ASM file and will behave correctly
> if someone will add ASM file in the future.
Please remove the ifeq and keep only $(CROSS)as as below.
> >> +else
> >> +AS = $(CROSS)as
> >> +endif
> >
prev parent reply other threads:[~2017-01-27 16:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-17 14:35 zbigniew.bodek
2017-01-17 22:45 ` Thomas Monjalon
2017-01-18 11:31 ` Zbigniew Bodek
2017-01-27 16:20 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2810758.uGRdNRuYUv@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=jerin.jacob@caviumnetworks.com \
--cc=konstantin.ananyev@intel.com \
--cc=zbigniew.bodek@caviumnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).