From: Thomas Monjalon <thomas@monjalon.net>
To: Jerin Jacob <jerinj@marvell.com>
Cc: Jerin Jacob <jerinjacobk@gmail.com>,
dev@dpdk.org, dpdk-dev <dev@dpdk.org>,
Andrew Rybchenko <arybchenko@solarflare.com>,
"Richardson, Bruce" <bruce.richardson@intel.com>,
"Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
Hemant Agrawal <hemant.agrawal@nxp.com>,
Shahaf Shuler <shahafs@mellanox.com>,
Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>,
Gavin Hu <gavin.hu@arm.com>,
Jan Viktorin <viktorin@rehivetech.com>,
David Christensen <drc@linux.vnet.ibm.com>,
Anatoly Burakov <anatoly.burakov@intel.com>,
Olivier Matz <olivier.matz@6wind.com>
Subject: Re: [dpdk-dev] [PATCH v4] mempool: remove memory wastage on non x86
Date: Mon, 20 Jan 2020 13:29:34 +0100 [thread overview]
Message-ID: <2816605.f0I1acK8xe@xps> (raw)
In-Reply-To: <20200120122459.GH14387@glumotte.dev.6wind.com>
20/01/2020 13:24, Olivier Matz:
> On Thu, Jan 16, 2020 at 06:40:23PM +0530, Jerin Jacob wrote:
> > On Wed, Jan 15, 2020 at 2:35 AM <jerinj@marvell.com> wrote:
> > >
> > > From: Jerin Jacob <jerinj@marvell.com>
> > >
> > > The existing optimize_object_size() function address the memory object
> > > alignment constraint on x86 for better performance.
> > >
> > > Different (micro) architecture may have different memory alignment
> > > constraint for better performance and it not the same as the existing
> > > optimize_object_size().
> > >
> > > Some use, XOR(kind of CRC) scheme to enable DRAM channel distribution
> > > based on the address and some may have a different formula.
> > >
> > > Introducing arch_mem_object_align() function to abstract
> > > the difference between different (micro) architectures to avoid
> > > wasting memory for mempool object alignment for the architecture
> > > that it is not required to do so.
> > >
> > > Details on the amount of memory saving:
> > >
> > > Currently, arm64 based architectures use the default (nchan=4,
> > > nrank=1). The worst case is for an object whose size (including mempool
> > > header) is 2 cache lines, where it is optimized to 3 cache lines (+50%).
> > >
> > > Examples for cache lines size = 64:
> > > orig optimized
> > > 64 -> 64 +0%
> > > 128 -> 192 +50%
> > > 192 -> 192 +0%
> > > 256 -> 320 +25%
> > > 320 -> 320 +0%
> > > 384 -> 448 +16%
> > > ...
> > > 2304 -> 2368 +2.7% (~mbuf size)
> > >
> > > Additional details:
> > > https://www.mail-archive.com/dev@dpdk.org/msg149157.html
> > >
> > > Signed-off-by: Jerin Jacob <jerinj@marvell.com>
> > > Reviewed-by: Gavin Hu <gavin.hu@arm.com>
> >
> > Ping for merge.
>
> Acked-by: Olivier Matz <olivier.matz@6wind.com>
Applied, thanks
prev parent reply other threads:[~2020-01-20 12:29 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-19 13:42 [dpdk-dev] [PATCH] mempool: fix mempool obj alignment for " jerinj
2019-12-20 3:26 ` Gavin Hu
2019-12-20 3:45 ` Jerin Jacob
2019-12-20 10:54 ` [dpdk-dev] [PATCH] mempool: fix mempool obj alignment for nonx86 Morten Brørup
2019-12-20 15:55 ` [dpdk-dev] [PATCH] mempool: fix mempool obj alignment for non x86 Honnappa Nagarahalli
2019-12-20 16:55 ` Jerin Jacob
2019-12-20 21:07 ` Honnappa Nagarahalli
2019-12-21 5:06 ` Jerin Jacob
2019-12-27 15:54 ` Olivier Matz
2020-01-11 13:34 ` [dpdk-dev] [PATCH v2] " jerinj
2020-01-11 17:41 ` Stephen Hemminger
2020-01-13 6:49 ` [dpdk-dev] [PATCH v3] " jerinj
2020-01-13 9:46 ` [dpdk-dev] [dpdk-stable] " David Marchand
2020-01-13 11:46 ` [dpdk-dev] [EXT] " Jerin Jacob Kollanukkaran
2020-01-14 21:06 ` [dpdk-dev] [PATCH v4] mempool: remove memory wastage on " jerinj
2020-01-16 13:10 ` Jerin Jacob
2020-01-20 12:24 ` Olivier Matz
2020-01-20 12:29 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2816605.f0I1acK8xe@xps \
--to=thomas@monjalon.net \
--cc=anatoly.burakov@intel.com \
--cc=arybchenko@solarflare.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=drc@linux.vnet.ibm.com \
--cc=gavin.hu@arm.com \
--cc=hemant.agrawal@nxp.com \
--cc=honnappa.nagarahalli@arm.com \
--cc=jerinj@marvell.com \
--cc=jerinjacobk@gmail.com \
--cc=konstantin.ananyev@intel.com \
--cc=olivier.matz@6wind.com \
--cc=shahafs@mellanox.com \
--cc=viktorin@rehivetech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).