From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Jingjing Wu <jingjing.wu@intel.com>
Cc: dev@dpdk.org, helin.zhang@intel.com
Subject: Re: [dpdk-dev] [PATCH] i40evf: fix link info update
Date: Fri, 01 Apr 2016 10:23:35 +0200 [thread overview]
Message-ID: <2849253.L9bo604lkH@xps13> (raw)
In-Reply-To: <1459474604-2049-1-git-send-email-jingjing.wu@intel.com>
Hi Jingjing,
Please rebase on top of Marc's patches.
2016-04-01 09:36, Jingjing Wu:
> +* **i40e: Fixed link info of VF
a blank line is missing
> + Previously, the VF's link speed kept as 10G and status always was up. It did not
> + change even the physical link's status changed. Now this issue is fixed to make
> + VF's link info consistent with physical link.
[...]
> + new_link.link_speed = ETH_LINK_SPEED_100;
> + break;
> + case I40E_LINK_SPEED_1GB:
> + new_link.link_speed = ETH_LINK_SPEED_1000;
These speeds have new names after Marc's rework.
> + new_link.link_status = vf->link_up ? 1 : 0;
Please use new constants for link up and down.
next prev parent reply other threads:[~2016-04-01 8:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-01 1:36 Jingjing Wu
2016-04-01 8:23 ` Thomas Monjalon [this message]
2016-04-05 2:01 ` [dpdk-dev] [PATCH v2] " Jingjing Wu
2016-04-06 13:39 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2849253.L9bo604lkH@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=helin.zhang@intel.com \
--cc=jingjing.wu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).