From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: ciara.loftus@intel.com
Cc: dev@dpdk.org, Anthony Fee <anthonyx.fee@intel.com>
Subject: Re: [dpdk-dev] [PATCH] vhost: add interface name to virtio-net struct
Date: Thu, 18 Dec 2014 16:33:14 +0100 [thread overview]
Message-ID: <2861628.6qtiPmT13X@xps13> (raw)
In-Reply-To: <1418914523-24530-1-git-send-email-ciara.loftus@intel.com>
2014-12-18 14:55, ciara.loftus@intel.com:
> This patch fixes the issue whereby when using userspace vhost ports
> in the context of vSwitching, the name provided to the hypervisor/QEMU
> of the vhost tap device needs to be exposed in the library, in order
> for the vSwitch to be able to direct packets to the correct device.
Do you mean that vhost was not working at all?
Please precise the context and how it is critical.
More informations are needed to understand wether it should be merged in
release 1.8.0 or not.
> --- a/lib/librte_vhost/rte_virtio_net.h
> +++ b/lib/librte_vhost/rte_virtio_net.h
> @@ -96,6 +96,7 @@ struct virtio_net {
> uint64_t features; /**< Negotiated feature set. */
> uint64_t device_fh; /**< device identifier. */
> uint32_t flags; /**< Device flags. Only used to check if device is running on data core. */
> + char ifname[32]; /** Name of the tap device **/
Wrong comment style.
--
Thomas
next prev parent reply other threads:[~2014-12-18 15:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-18 14:55 ciara.loftus
2014-12-18 15:33 ` Thomas Monjalon [this message]
2014-12-18 17:01 ` Loftus, Ciara
2014-12-18 17:16 ` Xie, Huawei
2014-12-18 17:20 ` Czesnowicz, Przemyslaw
2014-12-18 16:20 ` Stephen Hemminger
2014-12-18 16:26 ` Vincent JARDIN
2014-12-18 17:03 ` Ananyev, Konstantin
2014-12-18 18:11 ` Loftus, Ciara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2861628.6qtiPmT13X@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=anthonyx.fee@intel.com \
--cc=ciara.loftus@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).