From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Hernan Vargas <hernan.vargas@intel.com>,
dev@dpdk.org, gakhil@marvell.com, trix@redhat.com
Cc: nicolas.chautru@intel.com, qi.z.zhang@intel.com,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [PATCH v2 4/7] baseband/acc: acc100 fix queue mapping to 64 bits
Date: Fri, 6 Jan 2023 10:13:01 +0100 [thread overview]
Message-ID: <28a661d2-d037-8497-70f5-7ba9f4216f27@redhat.com> (raw)
In-Reply-To: <3982580c-efa0-441a-1599-1f9243aeaf7a@redhat.com>
On 1/6/23 10:12, Maxime Coquelin wrote:
>
>
> On 1/6/23 06:44, Hernan Vargas wrote:
>> Fix potential overflow for Q mapping extension to 64 bits.
>>
>> Fixes: 32e8b7ea35d ("baseband/acc100: refactor to segregate common code")
>>
>> Signed-off-by: Hernan Vargas <hernan.vargas@intel.com>
>> ---
>> drivers/baseband/acc/rte_acc100_pmd.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/baseband/acc/rte_acc100_pmd.c
>> b/drivers/baseband/acc/rte_acc100_pmd.c
>> index 2f65f290b5..1ca95f4440 100644
>> --- a/drivers/baseband/acc/rte_acc100_pmd.c
>> +++ b/drivers/baseband/acc/rte_acc100_pmd.c
>> @@ -664,7 +664,7 @@ acc100_find_free_queue_idx(struct rte_bbdev *dev,
>> for (aq_idx = 0; aq_idx < qtop->num_aqs_per_groups; aq_idx++) {
>> if (((d->q_assigned_bit_map[group_idx] >> aq_idx) & 0x1) ==
>> 0) {
>> /* Mark the Queue as assigned */
>> - d->q_assigned_bit_map[group_idx] |= (1 << aq_idx);
>> + d->q_assigned_bit_map[group_idx] |= (1ULL << aq_idx);
>> /* Report the AQ Index */
>> return (group_idx << ACC100_GRP_ID_SHIFT) + aq_idx;
>> }
>
> Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Also cc'ing stable since it is in v22.11 at least.
> Thanks,
> Maxime
next prev parent reply other threads:[~2023-01-06 9:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230106054443.199473-1-hernan.vargas@intel.com>
2023-01-06 5:44 ` [PATCH v2 1/7] baseband/acc: acc100 free harq layout pointer Hernan Vargas
2023-01-06 8:53 ` Maxime Coquelin
2023-01-11 16:45 ` Vargas, Hernan
2023-01-06 5:44 ` [PATCH v2 2/7] baseband/acc: acc100 fix iteration counter in TB Hernan Vargas
2023-01-06 8:54 ` Maxime Coquelin
[not found] ` <20230106054443.199473-5-hernan.vargas@intel.com>
[not found] ` <3982580c-efa0-441a-1599-1f9243aeaf7a@redhat.com>
2023-01-06 9:13 ` Maxime Coquelin [this message]
2023-01-06 22:06 ` [PATCH v2 4/7] baseband/acc: acc100 fix queue mapping to 64 bits Vargas, Hernan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=28a661d2-d037-8497-70f5-7ba9f4216f27@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=dev@dpdk.org \
--cc=gakhil@marvell.com \
--cc=hernan.vargas@intel.com \
--cc=nicolas.chautru@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=stable@dpdk.org \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).