DPDK patches and discussions
 help / color / mirror / Atom feed
From: Akhil Goyal <akhil.goyal@nxp.com>
To: Arek Kusztal <arkadiuszx.kusztal@intel.com>,
	"dev@dpdk.org" <dev@dpdk.org>,
	"fiona.trahe@intel.com" <fiona.trahe@intel.com>
Cc: "damianx.nowak@intel.com" <damianx.nowak@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2 0/4] Add PMD for asymmetric cryptography operations using Intel QuickAssist Technology devices
Date: Fri, 22 Mar 2019 12:34:10 +0000	[thread overview]
Message-ID: <28b1f636-95c7-b906-033b-e2f6e203e540@nxp.com> (raw)
In-Reply-To: <20190318124515.4660-1-arkadiuszx.kusztal@intel.com>

Hi Fiona,

Could you please review/ack this series.

Hi Arek,

I can see a few checkpatch warnings. Could you please correct those.

Thanks,
Akhil

On 3/18/2019 6:15 PM, Arek Kusztal wrote:
> This patchset adds Poll Mode Driver to use asymmetric cryptography
> functions using Intel QuickAssist Techology devices.
>
> Following functions are available with this patchset:
> *	Modular Exponentiation
> *	Modular Inverse
>
> This patch depends on a QAT PF driver for device initialization. See
> the file docs/guides/cryptodevs/qat.rst for configuration details.
>
> Limitations:
> *	Maximum parameter size: 4096 bits
> 	-	For both modular exponentiaion and modular multiplicative inverse
> 	
> This patchset depends on following patches:
> - [v2,1/3] cryptodev: add result field to mod exp and inverse operations
> (http://patchwork.dpdk.org/patch/50256/)
> - [v2] lib/cryptodev: fix driver name comparison
> (http://patchwork.dpdk.org/patch/51027/)
>
> v2:
> - added Meson build
> - fixed segfault on cookie
> - fixed mod inverse problem
>
> Arek Kusztal (4):
>    common/qat: add headers for asymmetric crypto
>    crypto/qat: add asymmetric cryptography PMD
>    crypto/qat: add modular exponentiation to qat asym pmd
>    crypto/qat: add modular multiplicative inverse to qat asym pmd
>
>   config/common_base                                 |    1 +
>   doc/guides/cryptodevs/qat.rst                      |   10 +
>   drivers/common/qat/Makefile                        |    8 +
>   drivers/common/qat/qat_adf/icp_qat_fw_mmp_ids.h    | 1538 ++++++++++++++++++++
>   drivers/common/qat/qat_adf/icp_qat_fw_pke.h        |  426 ++++++
>   .../qat/qat_adf/qat_pke_functionality_arrays.h     |   52 +
>   drivers/common/qat/qat_device.h                    |   12 +-
>   drivers/common/qat/qat_qp.c                        |    8 +
>   drivers/crypto/qat/meson.build                     |    5 +-
>   drivers/crypto/qat/qat_asym.c                      |  407 ++++++
>   drivers/crypto/qat/qat_asym.h                      |  106 ++
>   drivers/crypto/qat/qat_asym_capabilities.h         |   42 +
>   drivers/crypto/qat/qat_asym_pmd.c                  |  310 ++++
>   drivers/crypto/qat/qat_asym_pmd.h                  |   46 +
>   drivers/crypto/qat/qat_sym_pmd.c                   |    1 -
>   drivers/crypto/qat/qat_sym_pmd.h                   |    3 +-
>   16 files changed, 2970 insertions(+), 5 deletions(-)
>   create mode 100644 drivers/common/qat/qat_adf/icp_qat_fw_mmp_ids.h
>   create mode 100644 drivers/common/qat/qat_adf/icp_qat_fw_pke.h
>   create mode 100644 drivers/common/qat/qat_adf/qat_pke_functionality_arrays.h
>   create mode 100644 drivers/crypto/qat/qat_asym.c
>   create mode 100644 drivers/crypto/qat/qat_asym.h
>   create mode 100644 drivers/crypto/qat/qat_asym_capabilities.h
>   create mode 100644 drivers/crypto/qat/qat_asym_pmd.c
>   create mode 100644 drivers/crypto/qat/qat_asym_pmd.h
>


  parent reply	other threads:[~2019-03-22 12:34 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-18 12:45 Arek Kusztal
2019-03-18 12:45 ` Arek Kusztal
2019-03-18 12:45 ` [dpdk-dev] [PATCH v2 1/4] common/qat: add headers for asymmetric crypto Arek Kusztal
2019-03-18 12:45   ` Arek Kusztal
2019-03-18 12:45 ` [dpdk-dev] [PATCH v2 2/4] crypto/qat: add asymmetric cryptography PMD Arek Kusztal
2019-03-18 12:45   ` Arek Kusztal
2019-03-18 12:45 ` [dpdk-dev] [PATCH v2 3/4] crypto/qat: add modular exponentiation to qat asym pmd Arek Kusztal
2019-03-18 12:45   ` Arek Kusztal
2019-03-18 12:45 ` [dpdk-dev] [PATCH v2 4/4] crypto/qat: add modular multiplicative inverse " Arek Kusztal
2019-03-18 12:45   ` Arek Kusztal
2019-03-22 12:34 ` Akhil Goyal [this message]
2019-03-22 12:34   ` [dpdk-dev] [PATCH v2 0/4] Add PMD for asymmetric cryptography operations using Intel QuickAssist Technology devices Akhil Goyal
2019-03-22 13:34   ` Kusztal, ArkadiuszX
2019-03-22 13:34     ` Kusztal, ArkadiuszX

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=28b1f636-95c7-b906-033b-e2f6e203e540@nxp.com \
    --to=akhil.goyal@nxp.com \
    --cc=arkadiuszx.kusztal@intel.com \
    --cc=damianx.nowak@intel.com \
    --cc=dev@dpdk.org \
    --cc=fiona.trahe@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).