DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Hunt, David" <david.hunt@intel.com>
To: "Burakov, Anatoly" <anatoly.burakov@intel.com>, dev@dpdk.org
Cc: liang.j.ma@intel.com
Subject: Re: [dpdk-dev] [PATCH v4 1/2] lib/power: add bit for high frequency cores
Date: Mon, 1 Apr 2019 16:49:20 +0100	[thread overview]
Message-ID: <28b75883-2dd5-bd9d-69bb-cbc7d263a182@intel.com> (raw)
In-Reply-To: <9b50355f-06ab-fb44-5aa6-1089fd7e64d6@intel.com>

Hi Anatoly,

On 1/4/2019 4:43 PM, Burakov, Anatoly wrote:
> On 01-Apr-19 4:30 PM, David Hunt wrote:
>> This patch adds a new bit in the capabilities mask that's returned by
>> rte_power_get_capabilities(), allowing application to query which cores
>> have the higher frequencies, and can then pin the workloads accordingly.
>>
>> Returned Bits:
>>   0 - Turbo Boost enabled
>>   1 - Higher core base_frequency
>>
>> Signed-off-by: David Hunt <david.hunt@intel.com>
>> ---
>
> <snip>
>
>>       /* Add MSR read to detect turbo status */
>>         if (power_rdmsr(PLATFORM_INFO, &max_non_turbo, pi->lcore_id) 
>> < 0)
>> @@ -179,6 +207,14 @@ power_init_for_setting_freq(struct 
>> pstate_power_info *pi)
>>         pi->non_turbo_max_ratio = max_non_turbo;
>>   +    /*Add the compare for base frequency  */
>
> The comment here looks meaningless, and needs to be reworded to 
> explain why this is done, not what is done.
>
> Otherwise,
>
> Reviewed-by: Anatoly Burakov <anatoly.burakov@intel.com>
>

OK, Thanks for that. I'll push a v5 shortly, including your Reviewed-by tag.

Rgds,
Dave.

  parent reply	other threads:[~2019-04-01 15:49 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-22 11:45 [dpdk-dev] [PATCH v1] examples/distributor: detect " David Hunt
2019-03-27 13:58 ` Burakov, Anatoly
2019-03-27 13:58   ` Burakov, Anatoly
2019-03-28 10:20   ` Hunt, David
2019-03-28 10:20     ` Hunt, David
2019-03-28 13:13 ` [dpdk-dev] [PATCH v2] " David Hunt
2019-03-28 13:13   ` David Hunt
2019-03-28 13:58   ` Burakov, Anatoly
2019-03-28 13:58     ` Burakov, Anatoly
2019-03-28 14:42     ` Hunt, David
2019-03-28 14:42       ` Hunt, David
2019-03-28 15:10       ` Burakov, Anatoly
2019-03-28 15:10         ` Burakov, Anatoly
2019-03-28 15:20         ` Hunt, David
2019-03-28 15:20           ` Hunt, David
2019-03-29 13:15   ` [dpdk-dev] [PATCH v3] " David Hunt
2019-03-29 13:15     ` David Hunt
2019-04-01  9:07     ` Hunt, David
2019-04-01  9:07       ` Hunt, David
2019-04-01 15:30     ` [dpdk-dev] [PATCH v4 1/2] lib/power: add bit for " David Hunt
2019-04-01 15:30       ` David Hunt
2019-04-01 15:30       ` [dpdk-dev] [PATCH v4 2/2] examples/distributor: detect " David Hunt
2019-04-01 15:30         ` David Hunt
2019-04-01 15:43       ` [dpdk-dev] [PATCH v4 1/2] lib/power: add bit for " Burakov, Anatoly
2019-04-01 15:43         ` Burakov, Anatoly
2019-04-01 15:49         ` Hunt, David [this message]
2019-04-01 15:49           ` Hunt, David
2019-04-01 16:14       ` [dpdk-dev] [PATCH v5 " David Hunt
2019-04-01 16:14         ` David Hunt
2019-04-01 16:14         ` [dpdk-dev] [PATCH v5 2/2] examples/distributor: detect " David Hunt
2019-04-01 16:14           ` David Hunt
2019-04-02  0:06           ` Thomas Monjalon
2019-04-02  0:06             ` Thomas Monjalon
2019-04-02  0:20             ` Thomas Monjalon
2019-04-02  0:20               ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=28b75883-2dd5-bd9d-69bb-cbc7d263a182@intel.com \
    --to=david.hunt@intel.com \
    --cc=anatoly.burakov@intel.com \
    --cc=dev@dpdk.org \
    --cc=liang.j.ma@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).