From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Dmitriy Yakovlev <bombermag@gmail.com>
Cc: dev@dpdk.org, "Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>
Subject: Re: [dpdk-dev] [PATCH] cfgfile: fix uninitialized variable on load error
Date: Tue, 14 Feb 2017 18:14:27 +0100 [thread overview]
Message-ID: <2924499.9xLPenM5g3@xps13> (raw)
In-Reply-To: <3EB4FA525960D640B5BDFFD6A3D891265274CEFD@IRSMSX108.ger.corp.intel.com>
> > Uninitialized scalar variable. Using uninitialized value cfg-
> > >sections[curr_section]->num_entries when calling rte_cfgfile_close.
> > And memory in variables cfg->sections[curr_section], sect-
> > >entries[curr_entry] maybe not equal NULL. We must decrement counters
> > curr_section, curr_entry when failed to realloc.
> >
> > Fixes: eaafbad419bf ("cfgfile: library to interpret config files")
> >
> > Signed-off-by: Dmitriy Yakovlev <bombermag@gmail.com>
> > ---
> > lib/librte_cfgfile/rte_cfgfile.c | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
>
> Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
Applied, thanks
prev parent reply other threads:[~2017-02-14 17:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-07 2:51 Dmitriy Yakovlev
2017-02-13 21:07 ` Thomas Monjalon
2017-02-14 16:46 ` Dumitrescu, Cristian
2017-02-14 17:14 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2924499.9xLPenM5g3@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=bombermag@gmail.com \
--cc=cristian.dumitrescu@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).