From: Thomas Monjalon <thomas@monjalon.net>
To: "Morten Brørup" <mb@smartsharesystems.com>
Cc: bruce.richardson@intel.com, konstantin.v.ananyev@yandex.ru, dev@dpdk.org
Subject: Re: [PATCH] x86: rte_mov256 was missing for AVX2
Date: Mon, 29 Aug 2022 15:12:37 +0200 [thread overview]
Message-ID: <2996728.ktpJ11cQ8Q@thomas> (raw)
In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35D872CB@smartserver.smartshare.dk>
29/08/2022 14:18, Morten Brørup:
> At SmartShare Systems we follow a coding convention of including the declaration header file at the absolute top of the file implementing it. This reveals at build time if anything is missing in the declaration header file. The DPDK Project could do the same, and find bugs like this.
>
> Here's an example:
>
> foo.h:
> ------
> // Declaration
> static inline uint32_t bar(uint32_t x);
>
> foo.c:
> ------
> #include <foo.h> // <-- Note: At the absolute top!
> #include <stdint.h>
>
> // Implementation
> static inline uint32_t bar(uint32_t x)
> {
> return x * 2;
> }
>
> Following our coding convention will reveal that <stdint.h> is required for using <foo.h>, and thus should be included in foo.h (not in foo.c) - because someone else might include <foo.h>, and then <stdint.h> could be missing there.
Yes we could follow this convention.
next prev parent reply other threads:[~2022-08-29 13:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-20 10:30 Morten Brørup
2022-08-29 10:55 ` Thomas Monjalon
2022-08-29 12:18 ` Morten Brørup
2022-08-29 13:12 ` Thomas Monjalon [this message]
2022-09-28 19:44 ` Morten Brørup
2022-09-29 8:25 ` Bruce Richardson
2022-09-30 8:34 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2996728.ktpJ11cQ8Q@thomas \
--to=thomas@monjalon.net \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=konstantin.v.ananyev@yandex.ru \
--cc=mb@smartsharesystems.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).