From: "Wiles, Keith" <keith.wiles@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] usertools: script to output version string
Date: Mon, 7 Aug 2017 13:17:17 +0000 [thread overview]
Message-ID: <2BCD1863-1C9C-422D-83C1-2FFA8673B45A@intel.com> (raw)
In-Reply-To: <2588998.vour8g1xmE@xps>
> On Aug 7, 2017, at 6:35 AM, Thomas Monjalon <thomas@monjalon.net> wrote:
>
> Hi,
>
> 06/07/2017 16:56, Keith Wiles:
>> +# Locate the rte_version.h file and parse out the version strings.
>
> I think this script is not needed because we have already
> something in mk/rte.sdkconfig.mk.
> Example:
> % make showversion
> 17.08.0-rc4
Executing make to find out a version seems to bit of over kill to me and a simple script would be much easier IMO. I do not really see harm in having this script that can output the version into different formats is helpful when running external scripts. Also in the future we are most like going to replace the build system and then we would need to add this support to that build system and having it in a standalone script is easier manage in the long run.
>
> Do you need more?
Regards,
Keith
next prev parent reply other threads:[~2017-08-07 13:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-06 14:56 Keith Wiles
2017-08-07 11:35 ` Thomas Monjalon
2017-08-07 13:17 ` Wiles, Keith [this message]
2017-08-07 16:49 ` Thomas Monjalon
2017-08-07 17:31 ` Wiles, Keith
2019-01-23 19:16 ` Ferruh Yigit
2019-03-01 16:46 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2BCD1863-1C9C-422D-83C1-2FFA8673B45A@intel.com \
--to=keith.wiles@intel.com \
--cc=dev@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).