From: Yongseok Koh <yskoh@mellanox.com>
To: Shahaf Shuler <shahafs@mellanox.com>
Cc: "Nélio Laranjeiro" <nelio.laranjeiro@6wind.com>,
"Adrien Mazarguil" <adrien.mazarguil@6wind.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [PATCH v4 2/4] net/mlx5: fix Tx stats error counter definition
Date: Wed, 13 Sep 2017 17:59:56 +0000 [thread overview]
Message-ID: <2CEDC921-AE45-4A58-84A5-B2477ADA9DFD@mellanox.com> (raw)
In-Reply-To: <f27a7e9603697aeafc683aa2cbbdb81a737e0cfa.1505299539.git.shahafs@mellanox.com>
> On Sep 13, 2017, at 3:50 AM, Shahaf Shuler <shahafs@mellanox.com> wrote:
>
> The current Tx error counter counts, according to its description,
> the total number of packets not sent when TX ring full. It is reported
> to application as part of oerrors field.
>
> The drop due to full ring is not the statistic that should be set on
> oerrors field. Such number can be counted by the application using the
> return value of the Tx burst function.
> The number that should be set there is the number of packets the device
> could not transmit in any way, even when it has resources.
>
> Therefore, replace this counter to count the total number of failed
> transmitted packets.
>
> Fixes: 87011737b715 ("mlx5: add software counters")
> Cc: stable@dpdk.org
> Cc: adrien.mazarguil@6wind.com
>
> Signed-off-by: Shahaf Shuler <shahafs@mellanox.com>
> ---
Acked-by: Yongseok Koh <yskoh@mellanox.com>
next prev parent reply other threads:[~2017-09-13 17:59 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-23 7:33 [dpdk-stable] [PATCH 1/2] net/mlx5: fix num seg assumption on vPMD Shahaf Shuler
2017-08-23 7:33 ` [dpdk-stable] [PATCH 2/2] net/mlx5: enforce Tx num of segments limitation Shahaf Shuler
2017-08-24 13:28 ` Nélio Laranjeiro
2017-08-24 13:23 ` [dpdk-stable] [PATCH 1/2] net/mlx5: fix num seg assumption on vPMD Nélio Laranjeiro
2017-08-30 7:07 ` [dpdk-stable] [PATCH v2 " Shahaf Shuler
2017-09-04 14:57 ` Nélio Laranjeiro
2017-09-11 12:50 ` [dpdk-stable] [PATCH v3 1/3] " Shahaf Shuler
2017-09-13 10:50 ` [dpdk-stable] [PATCH v4 1/4] " Shahaf Shuler
2017-09-14 10:50 ` [dpdk-stable] [PATCH v5 " Shahaf Shuler
2017-09-15 10:51 ` Ferruh Yigit
2017-09-14 10:50 ` [dpdk-stable] [PATCH v5 2/4] net/mlx5: fix Tx stats error counter definition Shahaf Shuler
2017-09-14 10:50 ` [dpdk-stable] [PATCH v5 3/4] net/mlx5: fix Tx stats error counter logic Shahaf Shuler
2017-09-14 10:50 ` [dpdk-stable] [PATCH v5 4/4] net/mlx5: enforce Tx num of segments limitation Shahaf Shuler
2017-09-14 19:21 ` Yongseok Koh
2017-09-15 8:11 ` Nélio Laranjeiro
2017-09-13 10:50 ` [dpdk-stable] [PATCH v4 2/4] net/mlx5: fix Tx stats error counter definition Shahaf Shuler
2017-09-13 17:59 ` Yongseok Koh [this message]
2017-09-14 8:11 ` Nélio Laranjeiro
2017-09-13 10:50 ` [dpdk-stable] [PATCH v4 3/4] net/mlx5: fix Tx stats error counter logic Shahaf Shuler
2017-09-13 18:17 ` Yongseok Koh
2017-09-14 8:12 ` Nélio Laranjeiro
2017-09-13 10:50 ` [dpdk-stable] [PATCH v4 4/4] net/mlx5: enforce Tx num of segments limitation Shahaf Shuler
2017-09-13 19:51 ` Yongseok Koh
2017-09-14 5:23 ` Shahaf Shuler
2017-09-14 8:05 ` Yongseok Koh
2017-09-11 12:50 ` [dpdk-stable] [PATCH v3 2/3] net/mlx5: fix Tx stats error counter Shahaf Shuler
2017-09-11 12:50 ` [dpdk-stable] [PATCH v3 3/3] net/mlx5: enforce Tx num of segments limitation Shahaf Shuler
2017-08-30 7:07 ` [dpdk-stable] [PATCH v2 2/2] " Shahaf Shuler
2017-09-04 14:57 ` Nélio Laranjeiro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2CEDC921-AE45-4A58-84A5-B2477ADA9DFD@mellanox.com \
--to=yskoh@mellanox.com \
--cc=adrien.mazarguil@6wind.com \
--cc=dev@dpdk.org \
--cc=nelio.laranjeiro@6wind.com \
--cc=shahafs@mellanox.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).