From: "Wiles, Keith" <keith.wiles@intel.com>
To: "Richardson, Bruce" <bruce.richardson@intel.com>
Cc: Thomas Monjalon <thomas@monjalon.net>,
"gaetan.rivet@6wind.com" <gaetan.rivet@6wind.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [RFC PATCH] mk: symlink every headers first
Date: Wed, 21 Jun 2017 14:27:49 +0000 [thread overview]
Message-ID: <2D791B20-6CAC-482D-811B-4B4829242710@intel.com> (raw)
In-Reply-To: <20170621102702.GA93468@bricha3-MOBL3.ger.corp.intel.com>
> On Jun 21, 2017, at 5:27 AM, Bruce Richardson <bruce.richardson@intel.com> wrote:
>
> On Tue, Jun 20, 2017 at 11:21:39PM +0200, Thomas Monjalon wrote:
>> If a library or a build tool uses a definition from a driver,
>> there is a build ordering issue, like seen when moving PCI code
>> into a bus driver.
>>
>> One option is to keep PCI helpers and some common definitions in EAL.
>> The other option is to symlink every headers at the beginning of
>> the build so they can be included by any other component.
>>
>> This patch shows how to achieve the second option.
>>
>> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
>> ---
>
> My 2c.
>
> This may be worth doing, however, two points to consider.
>
> 1. If we look to change build system this may not be worth doing unless
> a compelling need becomes obvious in the short term. In the meantime,
> for cases where it is needed...
> 2. libraries can already access the includes from drivers or other
> places fairly easily, just by adding the relevant "-I" flag to the
> CFLAGS for that lib.
>
> That said, since the work is already done developing this, and if it
> doesn't hurt in terms of build time, I suppose we might as well merge
> it in.
>
> So tentative ack from me, subject to testing and feedback from others.
+1, I already have to make sure everything is symlinked first in my private DPDK work for other reasons. This patch would allow me to remove that special code.
>
> /Bruce
Regards,
Keith
next prev parent reply other threads:[~2017-06-21 14:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-20 21:21 Thomas Monjalon
2017-06-21 10:27 ` Bruce Richardson
2017-06-21 10:41 ` Thomas Monjalon
2017-06-21 12:52 ` Richardson, Bruce
2017-06-21 14:27 ` Wiles, Keith [this message]
2017-06-21 15:14 ` Gaëtan Rivet
2017-06-21 15:53 ` Wiles, Keith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2D791B20-6CAC-482D-811B-4B4829242710@intel.com \
--to=keith.wiles@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=gaetan.rivet@6wind.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).