From: "Yao, Lei A" <lei.a.yao@intel.com>
To: "Yigit, Ferruh" <ferruh.yigit@intel.com>,
"Yang, Zhiyong" <zhiyong.yang@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
"Richardson, Bruce" <bruce.richardson@intel.com>
Subject: Re: [dpdk-dev] [PATCH v3 0/5] consistent PMD batching behaviour
Date: Fri, 31 Mar 2017 07:00:01 +0000 [thread overview]
Message-ID: <2DBBFF226F7CF64BAFCA79B681719D953A1798FA@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <f2c93e41-7312-7316-3488-56d4266f1df1@intel.com>
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Ferruh Yigit
> Sent: Thursday, March 30, 2017 8:55 PM
> To: Yang, Zhiyong <zhiyong.yang@intel.com>; dev@dpdk.org
> Cc: Ananyev, Konstantin <konstantin.ananyev@intel.com>; Richardson,
> Bruce <bruce.richardson@intel.com>
> Subject: Re: [dpdk-dev] [PATCH v3 0/5] consistent PMD batching behaviour
>
> On 3/29/2017 8:16 AM, Zhiyong Yang wrote:
> > The rte_eth_tx_burst() function in the file Rte_ethdev.h is invoked to
> > transmit output packets on the output queue for DPDK applications as
> > follows.
> >
> > static inline uint16_t
> > rte_eth_tx_burst(uint8_t port_id, uint16_t queue_id,
> > struct rte_mbuf **tx_pkts, uint16_t nb_pkts);
> >
> > Note: The fourth parameter nb_pkts: The number of packets to transmit.
> >
> > The rte_eth_tx_burst() function returns the number of packets it actually
> > sent. Most of PMD drivers can support the policy "send as many packets to
> > transmit as possible" at the PMD level. but the few of PMDs have some
> sort
> > of artificial limits for the pkts sent successfully. For example, VHOST tx
> > burst size is limited to 32 packets. Some rx_burst functions have the
> > similar problem. The main benefit is consistent batching behavior for user
> > to simplify their logic and avoid misusage at the application level, there
> > is unified rte_eth_tx/rx_burst interface already, there is no reason for
> > inconsistent behaviors.
> > This patchset fixes it via adding wrapper function at the PMD level.
> >
> > Changes in V3:
> >
> > 1. Updated release_17_05 in patch 5/5
> > 2. Rebase on top of next net tree. i40e_rxtx_vec_altivec.c is updated in
> > patch 2/5.
> > 3. fix one checkpatch issue in 2/5.
> >
> > Changes in V2:
> > 1. rename ixgbe, i40e and fm10k vec function XXX_xmit_pkts_vec to new
> name
> > XXX_xmit_fixed_burst_vec, new wrapper functions use original name
> > XXX_xmit_pkts_vec according to Bruce's suggestion.
> > 2. simplify the code to avoid the if or if/else.
> >
> > Zhiyong Yang (5):
> > net/fm10k: remove limit of fm10k_xmit_pkts_vec burst size
> > net/i40e: remove limit of i40e_xmit_pkts_vec burst size
> > net/ixgbe: remove limit of ixgbe_xmit_pkts_vec burst size
> > net/vhost: remove limit of vhost TX burst size
> > net/vhost: remove limit of vhost RX burst size
>
> Series applied to dpdk-next-net/master, thanks.
>
> (doc patch exported into separate patch)
>
> This is the PMD update on fast path, effected PMDs, can you please
> confirm the performance after test?
Hi,
I have compare the vhost PVP performance with and without Zhiyong's
Patch. Almost no performance drop
Mergeable path: -0.2%
Normal Path: -0.73%
Vector Path : -0.55%
Test bench:
Ubutnu16.04
Kernal: 4.4.0
gcc : 5.4.0
BRs
Lei
next prev parent reply other threads:[~2017-03-31 7:00 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-24 8:48 [dpdk-dev] [PATCH " Zhiyong Yang
2017-02-24 8:48 ` [dpdk-dev] [PATCH 1/5] net/fm10k: remove limit of fm10k_xmit_pkts_vec burst size Zhiyong Yang
2017-02-24 9:32 ` Bruce Richardson
2017-02-24 9:36 ` Bruce Richardson
2017-02-24 9:48 ` Yang, Zhiyong
2017-03-03 11:17 ` [dpdk-dev] [PATCH v2 0/5] consistent PMD batching behaviour Zhiyong Yang
2017-03-03 11:17 ` [dpdk-dev] [PATCH v2 1/5] net/fm10k: remove limit of fm10k_xmit_pkts_vec burst size Zhiyong Yang
2017-03-29 7:16 ` [dpdk-dev] [PATCH v3 0/5] consistent PMD batching behaviour Zhiyong Yang
2017-03-29 7:16 ` [dpdk-dev] [PATCH v3 1/5] net/fm10k: remove limit of fm10k_xmit_pkts_vec burst size Zhiyong Yang
2017-03-29 7:16 ` [dpdk-dev] [PATCH v3 2/5] net/i40e: remove limit of i40e_xmit_pkts_vec " Zhiyong Yang
2017-03-29 7:16 ` [dpdk-dev] [PATCH v3 3/5] net/ixgbe: remove limit of ixgbe_xmit_pkts_vec " Zhiyong Yang
2017-03-29 7:16 ` [dpdk-dev] [PATCH v3 4/5] net/vhost: remove limit of vhost TX " Zhiyong Yang
2017-03-29 7:16 ` [dpdk-dev] [PATCH v3 5/5] net/vhost: remove limit of vhost RX " Zhiyong Yang
2017-03-30 12:54 ` [dpdk-dev] [PATCH v3 0/5] consistent PMD batching behaviour Ferruh Yigit
2017-03-31 7:00 ` Yao, Lei A [this message]
2017-03-03 11:17 ` [dpdk-dev] [PATCH v2 2/5] net/i40e: remove limit of i40e_xmit_pkts_vec burst size Zhiyong Yang
2017-03-24 14:03 ` Ferruh Yigit
2017-03-03 11:17 ` [dpdk-dev] [PATCH v2 3/5] net/ixgbe: remove limit of ixgbe_xmit_pkts_vec " Zhiyong Yang
2017-03-03 11:17 ` [dpdk-dev] [PATCH v2 4/5] net/vhost: remove limit of vhost TX " Zhiyong Yang
2017-03-03 11:17 ` [dpdk-dev] [PATCH v2 5/5] net/vhost: remove limit of vhost RX " Zhiyong Yang
2017-03-05 13:02 ` [dpdk-dev] [PATCH v2 0/5] consistent PMD batching behaviour Ananyev, Konstantin
2017-03-06 2:13 ` Yang, Zhiyong
2017-03-24 14:02 ` Ferruh Yigit
2017-03-25 6:29 ` Yang, Zhiyong
2017-03-28 10:00 ` Yang, Zhiyong
2017-03-28 10:05 ` Ferruh Yigit
2017-02-24 8:48 ` [dpdk-dev] [PATCH 2/5] net/i40e: remove limit of i40e_xmit_pkts_vec burst size Zhiyong Yang
2017-02-24 8:48 ` [dpdk-dev] [PATCH 3/5] net/ixgbe: remove limit of ixgbe_xmit_pkts_vec " Zhiyong Yang
2017-02-24 8:48 ` [dpdk-dev] [PATCH 4/5] net/vhost: remove limit of vhost TX " Zhiyong Yang
2017-02-24 11:08 ` Kevin Traynor
2017-02-24 13:04 ` Bruce Richardson
2017-02-24 13:33 ` Kevin Traynor
2017-03-01 9:44 ` Maxime Coquelin
2017-03-01 13:24 ` Yang, Zhiyong
2017-02-24 8:48 ` [dpdk-dev] [PATCH 5/5] net/vhost: remove limit of vhost RX " Zhiyong Yang
2017-02-24 11:41 ` Kevin Traynor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2DBBFF226F7CF64BAFCA79B681719D953A1798FA@shsmsx102.ccr.corp.intel.com \
--to=lei.a.yao@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=konstantin.ananyev@intel.com \
--cc=zhiyong.yang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).